Skip to content

[OSDEV-1789] SLC. "Search results" scrolls from the bottom#547

Merged
roman-stolar merged 4 commits intomainfrom
OSDEV-1789-search-result-scrolls-from-bottom
Mar 5, 2025
Merged

[OSDEV-1789] SLC. "Search results" scrolls from the bottom#547
roman-stolar merged 4 commits intomainfrom
OSDEV-1789-search-result-scrolls-from-bottom

Conversation

@roman-stolar
Copy link
Contributor

@roman-stolar roman-stolar commented Mar 5, 2025

OSDEV-1789 SLC. "Search results" scrolls from the bottom

  • Fixed an issue where the scroll position was not resetting to the top when navigating through SLC workflow pages.

… when navigating through SLC workflow pages.
@roman-stolar roman-stolar self-assigned this Mar 5, 2025
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 08:53 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 08:53 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 08:53 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 08:53 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 08:53 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 08:53 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 08:53 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 08:53 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 08:53 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 08:53 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 08:54 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 08:54 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 08:54 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 08:54 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 08:56 — with GitHub Actions Inactive
@barecheck
Copy link

barecheck bot commented Mar 5, 2025

React App | Jest test suite - Code coverage report

Total: 32.31%

Your code coverage diff: 0.04% ▴

✅ All code changes are covered

@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2025

Warning

Rate limit exceeded

@roman-stolar has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 57 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 6217c01 and 1ff0a75.

📒 Files selected for processing (2)
  • doc/release/RELEASE-NOTES.md (1 hunks)
  • src/react/src/components/Contribute/ProductionLocationInfo.jsx (2 hunks)
📝 Walkthrough

Walkthrough

This pull request updates the release notes by appending a new bug fix entry for release 1.32 addressing the scroll position not resetting issue on SLC workflow pages. Additionally, several React components have been modified to utilize a new custom hook, useResetScrollPosition, which resets the scroll position when the location changes. The SearchByOsIdResult.jsx component also imports the useLocation hook to access the current location. These changes document a UI behavior fix without altering existing component logic.

Changes

File(s) Change Summary
doc/release/RELEASE-NOTES.md Appended bug fix entry for OSDEV-1789 detailing the scroll reset issue on SLC workflow pages.
src/react/src/components/Contribute/ContributeProductionLocation.jsx, .../SearchByNameAndAddressResult.jsx, .../SearchByOsIdResult.jsx, .../ProductionLocationInfo.jsx Added useResetScrollPosition hook to manage scroll position on location change; SearchByOsIdResult.jsx additionally imports useLocation to access the current location.
src/react/src/util/hooks.js Introduced useResetScrollPosition hook that resets scroll position based on location changes.

Possibly related PRs

Suggested reviewers

  • vladsha-dev
  • mazursasha1990
  • VadimKovalenkoSNF

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 09:00 — with GitHub Actions Inactive
@barecheck
Copy link

barecheck bot commented Mar 5, 2025

Dedupe Hub App | Unittest test suite - Code coverage report

Total: 56.14%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 09:01 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 09:01 — with GitHub Actions Inactive
@barecheck
Copy link

barecheck bot commented Mar 5, 2025

Countries App | Unittest test suite - Code coverage report

Total: 100%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@barecheck
Copy link

barecheck bot commented Mar 5, 2025

Contricleaner App | Unittest test suite - Code coverage report

Total: 98.91%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 09:11 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 11:57 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 11:58 — with GitHub Actions Inactive
# Conflicts:
#	src/react/src/components/Contribute/ProductionLocationInfo.jsx
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 11:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 11:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 11:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 11:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 11:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 11:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 11:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 11:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 11:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 11:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 11:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 11:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 11:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment March 5, 2025 11:59 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2025

Copy link
Contributor

@vladsha-dev vladsha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@VadimKovalenkoSNF VadimKovalenkoSNF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants