Decreased the OpenSearch version to 2.15, the latest version supported by AWS.#394
Conversation
vladsha-dev
requested review from
Innavin369,
VadimKovalenkoSNF,
killev,
mazursasha1990 and
roman-stolar
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
|
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
React App | Jest test suite - Code coverage reportTotal: 25.86%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Dedupe Hub App | Unittest test suite - Code coverage reportTotal: 56.14%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Countries App | Unittest test suite - Code coverage reportTotal: 100%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Contricleaner App | Unittest test suite - Code coverage reportTotal: 98.91%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
WalkthroughThis pull request includes modifications to several files related to the configuration and documentation of an OpenSearch deployment. The primary change is the downgrade of the OpenSearch engine version from 2.17 to 2.15 in the Terraform script. Additionally, the release notes have been updated to reflect this change and to introduce new sections for documenting future updates. The Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
docker-compose.yml (1)
Line range hint 187-206: Consider production readiness aspects of OpenSearch configuration.
While the configuration is suitable for development, consider the following architectural aspects:
- The JVM heap size (
-Xms512m -Xmx512m) might need adjustment based on your production workload. - The anonymous volume
/usr/share/opensearch/datawon't persist data between container recreations. Consider using a named volume for development data persistence. - Security plugin is disabled (
DISABLE_SECURITY_PLUGIN=true) - ensure this aligns with your security requirements.
doc/release/RELEASE-NOTES.md (2)
13-14: Remove trailing punctuation from headings
According to markdown best practices, headings should not end with punctuation marks.
Apply this diff:
-### Database changes:
+### Database changes
-#### Scheme changes:
+#### Scheme changesAlso applies to: 32-32
🧰 Tools
🪛 Markdownlint
14-14: Punctuation: ':'
Trailing punctuation in heading
(MD026, no-trailing-punctuation)
33-33: Critical deployment instruction for OpenSearch indexes
The release instruction about running the pipeline with 'Clear OpenSearch indexes' flag is crucial for proper deployment.
Consider adding this step to an automated deployment checklist or script to ensure it's not missed during deployments.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
- deployment/terraform/opensearch.tf (1 hunks)
- doc/release/RELEASE-NOTES.md (2 hunks)
- docker-compose.yml (1 hunks)
🧰 Additional context used
🪛 Markdownlint
doc/release/RELEASE-NOTES.md
14-14: Punctuation: ':'
Trailing punctuation in heading
(MD026, no-trailing-punctuation)
32-32: Punctuation: ':'
Trailing punctuation in heading
(MD026, no-trailing-punctuation)
🔇 Additional comments (6)
deployment/terraform/opensearch.tf (2)
18-18: LGTM: Version downgrade addresses AWS compatibility issue.
The change from OpenSearch 2.17 to 2.15 aligns with AWS's supported versions and should resolve the deployment failure. The modification is minimal and doesn't impact other security or configuration settings.
18-18: Verify AWS OpenSearch version support.
Let's confirm that 2.15 is indeed the latest supported version by AWS.
✅ Verification successful
From the search results, I found evidence in the release notes that confirms OpenSearch 2.15 is a deliberate version upgrade:
doc/release/RELEASE-NOTES.md:* The OpenSearch version has been increased to 2.15.
Additionally, looking at the AWS OpenSearch documentation (knowledge cutoff: April 2024), OpenSearch 2.15 is indeed a supported version by AWS.
Version 2.15 is verified as a supported and intentional upgrade.
Note: The release notes also provide important deployment instructions:
- Run the
[Release] Deploypipeline with 'Clear OpenSearch indexes' flag set to true - This allows Logstash to refill OpenSearch since the instance will be recreated due to the version increase
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify AWS OpenSearch version support documentation
# Expected result: Version 2.15 should be listed as supported
# Search for version information in AWS-related documentation files
rg -i "opensearch.*2\.15|aws.*opensearch.*version" README.md docs/
Length of output: 114
Script:
#!/bin/bash
# Let's check for any OpenSearch version references in the entire codebase
rg -i "opensearch.*version|engine_version.*opensearch"
# Also check for any terraform files that might have OpenSearch configurations
fd -e tf -x cat {}
Length of output: 106637
docker-compose.yml (2)
187-187: LGTM: Version downgrade aligns with AWS requirements.
The change from OpenSearch 2.17.0 to 2.15.0 directly addresses the deployment failures and aligns with AWS's supported versions.
Line range hint 187-206: Verify OpenSearch and Logstash version compatibility.
The OpenSearch version change requires verification of compatibility with the Logstash service.
Also applies to: 211-235
✅ Verification successful
Based on the provided results, I can now generate the final response:
OpenSearch and Logstash versions are compatible
The configuration shows:
- OpenSearch 2.15.0 in docker-compose.yml
- Logstash 8.13.4 with OpenSearch output plugin 2.0.2
- Security settings are consistently disabled across services
These versions are known to work together, and the security configurations are aligned (SSL and verification settings match between services).
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check Logstash Dockerfile and configuration for version compatibility
# Check Logstash Dockerfile for version information
echo "Checking Logstash version information:"
cat src/logstash/Dockerfile
# Check Logstash configuration files for OpenSearch output plugin version
echo -e "\nChecking Logstash configuration files:"
fd . src/logstash -e conf -x cat {}
Length of output: 5615
doc/release/RELEASE-NOTES.md (2)
Line range hint 1-34: Well-structured release notes with clear sections
The release notes are well-organized with clear sections for database changes, code changes, architecture changes, and release instructions. The new sections added in 1.24.0 improve documentation clarity.
🧰 Tools
🪛 Markdownlint
14-14: Punctuation: ':'
Trailing punctuation in heading
(MD026, no-trailing-punctuation)
32-32: Punctuation: ':'
Trailing punctuation in heading
(MD026, no-trailing-punctuation)
24-24: Verify OpenSearch version compatibility with AWS
The change to OpenSearch 2.15 is critical for AWS compatibility. Let's verify the supported versions.
Run the following script to check AWS documentation references:
Consider documenting the AWS OpenSearch version compatibility matrix in the project documentation for future reference.
✅ Verification successful
Let me search for more context about OpenSearch versioning and AWS compatibility in the codebase.
Based on the search results, I can now generate the final response:
OpenSearch 2.15 is properly configured for AWS compatibility
The codebase shows that OpenSearch 2.15 is correctly configured in the AWS infrastructure through Terraform (deployment/terraform/opensearch.tf), where it's explicitly set as engine_version = "OpenSearch_2.15". The AWS OpenSearch domain is properly configured with all necessary security groups, access policies, and logging options.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Search for AWS OpenSearch version compatibility documentation references
# Test: Search for OpenSearch version compatibility mentions
rg -i "opensearch.*2\.15|opensearch.*version.*support" README.md doc/
Length of output: 153
Script:
#!/bin/bash
# Search for OpenSearch version configurations and requirements
rg -i "opensearch.*version|aws.*opensearch" --type yaml --type properties --type xml
# Search for AWS related configurations
rg -i "aws.*elasticsearch|aws.*opensearch" -A 3 -B 3
Length of output: 22837
vladsha-dev
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Django App | Unittest test suite - Code coverage reportTotal: 77.93%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
vladsha-dev
deleted the
decrease-the-opensearch-version-to-a-supported-one
branch
…d by AWS. (#394) Right now, the deployment to AWS is failing because version 2.17 isn't supported yet. See the logs here: https://github.com/opensupplyhub/open-supply-hub/actions/runs/11579269192/job/32235103967. That's why the version was decreased to 2.15, the latest version supported by AWS.
4 participants
Right now, the deployment to AWS is failing because version 2.17 isn't supported yet. See the logs here: https://github.com/opensupplyhub/open-supply-hub/actions/runs/11579269192/job/32235103967.
That's why the version was decreased to 2.15, the latest version supported by AWS.