Skip to content

Increased memory for the Dedupe Hub#419

Merged
roman-stolar merged 2 commits intomainfrom
dedupe-hub-memory-increase
Nov 20, 2024
Merged

Increased memory for the Dedupe Hub#419
roman-stolar merged 2 commits intomainfrom
dedupe-hub-memory-increase

Conversation

@roman-stolar
Copy link
Contributor

  • Increased memory for the Dedupe Hub instance from 8GB to 12GB in production & pre-prod environments.

@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 08:42 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 08:42 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 08:42 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 08:42 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 08:42 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 08:42 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 08:42 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 08:42 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 08:42 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 08:42 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 08:42 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 08:42 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 08:42 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 08:42 — with GitHub Actions Inactive
@roman-stolar roman-stolar self-assigned this Nov 20, 2024
@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 08:44 — with GitHub Actions Inactive
@barecheck
Copy link

barecheck bot commented Nov 20, 2024

React App | Jest test suite - Code coverage report

Total: 26.93%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@coderabbitai
Copy link

coderabbitai bot commented Nov 20, 2024

Walkthrough

The pull request includes updates to the memory allocation settings for the OpenSupplyHub project in both pre-production and production environments. Specifically, the app_dd_fargate_memory variable has been increased from 8192 to 12288 in the terraform-preprod.tfvars and terraform-production.tfvars configuration files. Additionally, the release notes have been updated to document these changes, along with enhancements to the API related to moderation events and a database migration affecting the api_moderationevent table.

Changes

File Path Change Summary
deployment/environments/terraform-preprod.tfvars Updated app_dd_fargate_memory from 8192 to 12288.
deployment/environments/terraform-production.tfvars Updated app_dd_fargate_memory from 8192 to 12288.
doc/release/RELEASE-NOTES.md Updated release notes for version 1.25.0, including new API endpoints and memory allocation changes. Added migration for api_moderationevent table status.

Suggested reviewers

  • killev
  • VadimKovalenkoSNF
  • mazursasha1990
  • vladsha-dev

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d8c5bbd and 1684b9b.

📒 Files selected for processing (1)
  • doc/release/RELEASE-NOTES.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • doc/release/RELEASE-NOTES.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)
deployment/environments/terraform-production.tfvars (1)

54-54: Consider implementing monitoring and cost optimization strategies

Since this memory increase will impact AWS costs, consider:

  1. Setting up CloudWatch alarms to monitor memory utilization
  2. Analyzing usage patterns to optimize the configuration if the full 12GB isn't consistently utilized
  3. Evaluating if auto-scaling policies could help manage costs during low-traffic periods
deployment/environments/terraform-preprod.tfvars (1)

55-55: Consider implementing cost monitoring and auto-scaling policies.

With the 50% increase in memory allocation, it's important to track resource utilization and costs.

Recommendations:

  1. Set up AWS Cost Explorer tags to track Dedupe Hub expenses
  2. Consider implementing auto-scaling policies if the workload is variable
  3. Document the expected cost increase in the infrastructure documentation
doc/release/RELEASE-NOTES.md (1)

Line range hint 1-1: Add deployment and monitoring instructions.

Consider adding release instructions that cover:

  1. Deployment steps for memory increase
  2. Rollback procedure if issues occur
  3. Monitoring guidance for memory usage
  4. Verification steps post-deployment
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 39278f7 and d8c5bbd.

📒 Files selected for processing (3)
  • deployment/environments/terraform-preprod.tfvars (1 hunks)
  • deployment/environments/terraform-production.tfvars (1 hunks)
  • doc/release/RELEASE-NOTES.md (1 hunks)
🔇 Additional comments (4)
deployment/environments/terraform-production.tfvars (1)

54-54: LGTM! Memory increase is within AWS Fargate constraints

The increase from 8GB to 12GB (12288 MB) for the Dedupe Hub is valid for the allocated 4 vCPU (4096 CPU units) configuration, as it falls within Fargate's supported memory range of 8GB-30GB for 4 vCPU tasks.

deployment/environments/terraform-preprod.tfvars (1)

55-55: Memory increase looks appropriate, please verify monitoring.

The increase from 8GB to 12GB for the Dedupe Hub instance aligns with the PR objectives and maintains a healthy 3:1 memory-to-CPU ratio with the existing 4 vCPU allocation.

Please ensure:

  1. Memory utilization metrics are being monitored
  2. Alert thresholds are adjusted accordingly
  3. The application can properly utilize the additional memory
doc/release/RELEASE-NOTES.md (2)

27-27: LGTM! Please verify the memory increase impact.

The memory increase for Dedupe Hub from 8GB to 12GB is well documented. However, please ensure:

  1. The new memory allocation has been load tested
  2. Memory usage metrics are monitored after deployment
  3. Cost implications of the 50% memory increase have been considered

Line range hint 1-1: LGTM! Well-structured release notes.

The release notes follow best practices with:

  • Clear semantic versioning
  • Consistent sections
  • Detailed categorization of changes

@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 08:49 — with GitHub Actions Inactive
@barecheck
Copy link

barecheck bot commented Nov 20, 2024

Dedupe Hub App | Unittest test suite - Code coverage report

Total: 56.14%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 08:50 — with GitHub Actions Inactive
@barecheck
Copy link

barecheck bot commented Nov 20, 2024

Countries App | Unittest test suite - Code coverage report

Total: 100%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 08:51 — with GitHub Actions Inactive
@barecheck
Copy link

barecheck bot commented Nov 20, 2024

Contricleaner App | Unittest test suite - Code coverage report

Total: 98.91%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@sonarqubecloud
Copy link

Copy link
Contributor

@vladsha-dev vladsha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mazursasha1990 mazursasha1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roman-stolar roman-stolar temporarily deployed to Quality Environment November 20, 2024 09:39 — with GitHub Actions Inactive
@roman-stolar roman-stolar merged commit fa78782 into main Nov 20, 2024
@roman-stolar roman-stolar deleted the dedupe-hub-memory-increase branch November 20, 2024 10:01
protsack-stephan pushed a commit that referenced this pull request Apr 12, 2025
- Increased memory for the Dedupe Hub instance from 8GB to 12GB in
`production` & `pre-prod` environments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants