-
Notifications
You must be signed in to change notification settings - Fork 2k
Add ROSA HCP testing for File Integrity Operator #53502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROSA HCP testing for File Integrity Operator #53502
Conversation
5c2229f to
509094e
Compare
...rator/config/openshift/file-integrity-operator/openshift-file-integrity-operator-master.yaml
Outdated
Show resolved
Hide resolved
|
/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa |
|
@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa |
|
@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa |
|
@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/hold for test |
|
This will need to go hand-in-hand with openshift/file-integrity-operator#539 |
|
/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa Should be good to exercise this now that we landed openshift/file-integrity-operator#539 |
|
@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Still hitting some issues - we'll have to recreate locally: |
509094e to
d556198
Compare
|
/pj-rehearse |
|
@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
d556198 to
0149d71
Compare
|
/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa |
|
@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa |
1 similar comment
|
/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa |
|
@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@rhmdnd, |
0149d71 to
b93f981
Compare
|
/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa |
|
@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
yuumasato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The e2e test is running and the fail comes from an actual test, not an infrastructure fail..
|
@xiaojiey should be ready for another round of reviews. |
This commit adds a test config for running FIO on ROSA HCP.
73f613f to
b9fe423
Compare
|
Adding in the optional label so this e2e test doesn't block us from merging patches while we smooth out the ROSA support. |
|
/pj-rehearse ack |
|
@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa |
|
@Vincent056: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
cluster set up was successful, let's fix the failing test in other pr |
|
/lgtm BTW, I was able to install FIO successfully with a nodeSelector config in the subscription. |
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, Vincent056, xiaojiey, yuumasato The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@rhmdnd: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
We recently added support for running tests on ROSA HCP, which doesn't support some objects like Machine Configs: openshift/release#53502 Because of this, the TestFileIntegrityAcceptsExpectedChange test is failing because it expects to create a Machine Config as a dependency for the test. This commit updates the test to check if we're running on ROSA HCP, and if so, skip the test.
This commit adds a test config for running FIO on ROSA HCP.