Skip to content

Conversation

@rhmdnd
Copy link
Contributor

@rhmdnd rhmdnd commented Jun 20, 2024

This commit adds a test config for running FIO on ROSA HCP.

@openshift-ci openshift-ci bot requested review from Vincent056 and mkumku June 20, 2024 19:29
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2024
@rhmdnd rhmdnd force-pushed the add-rosa-hcp-tesing-for-fio branch from 5c2229f to 509094e Compare June 20, 2024 19:32
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jun 27, 2024

/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jun 27, 2024

/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jun 27, 2024

/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@xiaojiey
Copy link
Contributor

xiaojiey commented Jul 1, 2024

/hold for test

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2024
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jul 8, 2024

This will need to go hand-in-hand with openshift/file-integrity-operator#539

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jul 12, 2024

/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa

Should be good to exercise this now that we landed openshift/file-integrity-operator#539

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jul 13, 2024

Still hitting some issues - we'll have to recreate locally:

 === RUN   TestFileIntegrityLogAndReinitDatabase
    helpers.go:430: TEST SETUP: failed to add custom resource scheme to framework: failed to build the dynamic client: timed out waiting for the condition
--- FAIL: TestFileIntegrityLogAndReinitDatabase (10.25s) 

@rhmdnd rhmdnd force-pushed the add-rosa-hcp-tesing-for-fio branch from 509094e to d556198 Compare July 17, 2024 18:47
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jul 17, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rhmdnd rhmdnd force-pushed the add-rosa-hcp-tesing-for-fio branch from d556198 to 0149d71 Compare July 17, 2024 20:48
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jul 17, 2024

/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jul 18, 2024

/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa

1 similar comment
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jul 18, 2024

/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@rhmdnd, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't rebase candidate onto master: %!w(<nil>)

@rhmdnd rhmdnd force-pushed the add-rosa-hcp-tesing-for-fio branch from 0149d71 to b93f981 Compare July 18, 2024 13:21
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jul 18, 2024

/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

The e2e test is running and the fail comes from an actual test, not an infrastructure fail..

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2024
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jul 30, 2024

@xiaojiey should be ready for another round of reviews.

This commit adds a test config for running FIO on ROSA HCP.
@rhmdnd rhmdnd force-pushed the add-rosa-hcp-tesing-for-fio branch from 73f613f to b9fe423 Compare August 6, 2024 14:04
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2024
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Aug 6, 2024

Adding in the optional label so this e2e test doesn't block us from merging patches while we smooth out the ROSA support.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Aug 6, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 6, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@rhmdnd: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-file-integrity-operator-master-e2e-rosa openshift/file-integrity-operator presubmit Presubmit changed
pull-ci-openshift-file-integrity-operator-master-ci-index-file-integrity-operator-bundle openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-e2e-aws openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-e2e-bundle-aws openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-e2e-bundle-aws-upgrade openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-go-build openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-images openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-unit openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-verify openshift/file-integrity-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Vincent056
Copy link
Contributor

/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa

@openshift-ci-robot
Copy link
Contributor

@Vincent056: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Vincent056
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2024
@Vincent056
Copy link
Contributor

Vincent056 commented Aug 6, 2024

cluster set up was successful, let's fix the failing test in other pr

@xiaojiey
Copy link
Contributor

xiaojiey commented Aug 7, 2024

/lgtm
The e2e failure was caused by
Cannot create a test MC: no kind is registered for the type v1.MachineConfig in scheme "github.com/openshift/file-integrity-operator/tests/framework/framework.go:141"

BTW, I was able to install FIO successfully with a nodeSelector config in the subscription.

% cat ~/func/co_install_rosa_hcp.yaml 
---
apiVersion: v1
kind: Namespace
metadata:
  labels:
    openshift.io/cluster-monitoring: "true"
    pod-security.kubernetes.io/enforce: privileged 
  name: openshift-compliance
---
apiVersion: operators.coreos.com/v1
kind: OperatorGroup
metadata:
  name: compliance-operator
  namespace: openshift-compliance
spec:
  targetNamespaces:
  - openshift-compliance
---
apiVersion: operators.coreos.com/v1alpha1
kind: Subscription
metadata:
  name: compliance-operator-sub
  namespace: openshift-compliance
spec:
  channel: "stable"
  installPlanApproval: Automatic
  name: compliance-operator
  source: compliance-operator
  sourceNamespace: openshift-marketplace
  config:
    nodeSelector:
      node-role.kubernetes.io/worker: ""
% oc apply -f fio_install_r_rosa_hcp.yaml 
namespace/openshift-file-integrity created
operatorgroup.operators.coreos.com/openshift-file-integrity-qbcd created
subscription.operators.coreos.com/file-integrity-operator created
% oc project openshift-file-integrity
Now using project "openshift-file-integrity" on server "https://api.n9928-8a5vj-949.ak3p.p3.openshiftapps.com:443".
% oc get csv
NAME                             DISPLAY                   VERSION   REPLACES                         PHASE
file-integrity-operator.v1.3.4   File Integrity Operator   1.3.4     file-integrity-operator.v1.3.3   Succeeded
% oc get clusterversion
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.15.23   True        False         3h38m   Cluster version is 4.15.23
% oc get pod
NAME                                       READY   STATUS    RESTARTS      AGE
file-integrity-operator-5ddf87777c-bfmdc   1/1     Running   1 (53s ago)   60s
% oc apply -f ~/func/fileintegrity.yaml 
fileintegrity.fileintegrity.openshift.io/example-fileintegrity created
% oc get fileintegrity example-fileintegrity -o=jsonpath={.status.phase}
Active%                                                                                                                                                                                                             % oc get fileintegritynodestatus   
NAME                                               NODE                         STATUS
example-fileintegrity-ip-10-0-1-238.ec2.internal   ip-10-0-1-238.ec2.internal   Succeeded
example-fileintegrity-ip-10-0-1-88.ec2.internal    ip-10-0-1-88.ec2.internal    Succeeded

@xiaojiey
Copy link
Contributor

xiaojiey commented Aug 7, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056, xiaojiey, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Aug 7, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 7, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

@rhmdnd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/file-integrity-operator/master/e2e-rosa b9fe423 link unknown /pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-rosa

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b517569 into openshift:master Aug 7, 2024
rhmdnd added a commit to rhmdnd/file-integrity-operator that referenced this pull request Aug 9, 2024
We recently added support for running tests on ROSA HCP, which doesn't
support some objects like Machine Configs:

  openshift/release#53502

Because of this, the TestFileIntegrityAcceptsExpectedChange test is
failing because it expects to create a Machine Config as a dependency
for the test.

This commit updates the test to check if we're running on ROSA HCP, and
if so, skip the test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants