Skip to content

Conversation

@rhmdnd
Copy link
Contributor

@rhmdnd rhmdnd commented Jul 8, 2024

  • Only set node selectors for OpenShift deployments
  • CMP-2624: Implement support for running e2e tests on ROSA

@openshift-ci openshift-ci bot requested review from BhargaviGudi and xiaojiey July 8, 2024 21:39
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
@rhmdnd rhmdnd requested review from Vincent056 and yuumasato July 8, 2024 21:41
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jul 9, 2024

I pulled the nodeSelector change into it's own PR:

#540

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jul 10, 2024

Debugging the e2e failures in #541

rhmdnd added 2 commits July 12, 2024 09:28
By default, the File Integrity Operator would set node selectors and
taints that would only allow it to schedule on `master` nodes. While
this is fine for OpenShift environments, some additional environments we
test on, like Red Hat OpenShift on AWS (ROSA), don't provide `master`
nodes at all.

To accomodate this in our testing and tooling, this commit removes the
node selector and taint from the default bundle, and moves it into an
OpenShift-specific bundle where it will still get used for OpenShift
deploy paths and bundles.

This will be more useful in a future patch that implements support for
running File Integrity Operator end-to-end testing on ROSA HCP, which
only provides `worker` nodes and not `master` nodes.
This commit adds some test plumbing so that the e2e framework knows when
it's running on ROSA. This is necessary so that the framework bypasses
certain features that aren't supported on that platform, like Machine
Configs and Machine Config Pools.

By implementing this, we're able to integrate ROSA CI into the gating
process to ensure the operator works on managed OpenShift offerings.
@rhmdnd rhmdnd force-pushed the implement-rosa-hcp-e2e-testing branch from 9d5a934 to 1a98280 Compare July 12, 2024 14:28
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2024

@rhmdnd: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jul 12, 2024

@Vincent056 should be ready for another look now that the e2e is passing.

Copy link
Contributor

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cbcb063 into openshift:master Jul 12, 2024
Vincent056 pushed a commit that referenced this pull request Nov 20, 2025
Vincent056 pushed a commit that referenced this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants