-
Notifications
You must be signed in to change notification settings - Fork 29
implement rosa hcp e2e testing #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement rosa hcp e2e testing #539
Conversation
|
I pulled the |
|
Debugging the e2e failures in #541 |
By default, the File Integrity Operator would set node selectors and taints that would only allow it to schedule on `master` nodes. While this is fine for OpenShift environments, some additional environments we test on, like Red Hat OpenShift on AWS (ROSA), don't provide `master` nodes at all. To accomodate this in our testing and tooling, this commit removes the node selector and taint from the default bundle, and moves it into an OpenShift-specific bundle where it will still get used for OpenShift deploy paths and bundles. This will be more useful in a future patch that implements support for running File Integrity Operator end-to-end testing on ROSA HCP, which only provides `worker` nodes and not `master` nodes.
This commit adds some test plumbing so that the e2e framework knows when it's running on ROSA. This is necessary so that the framework bypasses certain features that aren't supported on that platform, like Machine Configs and Machine Config Pools. By implementing this, we're able to integrate ROSA CI into the gating process to ensure the operator works on managed OpenShift offerings.
9d5a934 to
1a98280
Compare
|
@rhmdnd: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@Vincent056 should be ready for another look now that the e2e is passing. |
Vincent056
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
implement rosa hcp e2e testing
implement rosa hcp e2e testing
Uh oh!
There was an error while loading. Please reload this page.