baremetal: Add validation for provisioning network IPs #2320
Conversation
openshift-ci-robot
added
the
size/L
|
/label platform/baremetal |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1125/ |
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1174/ |
|
/test e2e-aws-upgrade |
|
/assign @wking |
|
|
Ack - until I fix #2091 we probably don't want to encourage customization of these values, so if you don't mind can I provide docs as a follow-up and/or as part of the PR to address that issue? |
|
Follow-up PR for |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1182/ |
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1184/ |
|
/lgtm Pull the hold if you don't want to address the currently explicit zero values; I'm fine either way. |
openshift-ci-robot
added
do-not-merge/hold
Adds initial test for existing validation code Related: openshift#2210
As mentioned in openshift#2079 we should validate these IPs as they must be on a different subnet than the machine CIDR, these IPs are used to configure a dedicated network for provisioning machines via pxe. Closes: openshift#2210
|
/lgtm |
openshift-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hardys, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1187/ |
5 participants
As mentioned in #2079 we should validate these IPs as they must
be on a different subnet than the machine CIDR, these IPs are used
to configure a dedicated network for provisioning machines via pxe.
This also adds some tests for the existing validation as a pre-requisite to adding tests for the new validation.
Closes: #2210