Skip to content

pkg/types/aws/validation/platform: Include eu-north-1 #2308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Oct 10, 2019
Merged

pkg/types/aws/validation/platform: Include eu-north-1 #2308

openshift-merge-robot merged 2 commits into from
Oct 10, 2019

Conversation

@wking
Copy link
Member

@wking wking commented Sep 3, 2019

RHCOS grew support for this in 905db73 (#1941), and until something like #1528 lands we need to bump this list to keep up.

Fixes #1814.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 3, 2019
@wking wking force-pushed the eu-north-1-validation branch from adb4dfe to 721cfbb Compare September 3, 2019 18:39
@wking wking mentioned this pull request Sep 3, 2019
Closed
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Sep 3, 2019

what's the result of the platformtests ??

@wking
Copy link
Member Author

wking commented Sep 3, 2019

what's the result of the platformtests ??

Passes once I add bf0369dfe to account for the new-but-not-yet-getting-RHCOS-AMIs Bahrain (me-south-1).

wking added 2 commits September 3, 2019 14:47
@wking
pkg/types/aws/validation/platform: Include eu-north-1
c907d53 
RHCOS grew support for this in 905db73 (data/data/rhcos.json:
update the bootimage to 420.8.20190708.2 for CRI-O 1.14, 2019-07-03, openshift#1941).
And until we get something like [1], we need this not-very-DRY bump to
keep up.

[1]: openshift#1528
@wking
platformtests/aws/default_instance_class_test: Add Bahrain (me-south-1)
612143d 
The region was added on 2019-07-29 [1] and the canonical ID is
me-south-1 [2].  This fixes:

  $ cd platformtests/aws
  $ AWS_PROFILE=openshift-dev go test .
  --- FAIL: TestGetDefaultInstanceClass (71.40s)
      --- FAIL: TestGetDefaultInstanceClass/Middle_East_(Bahrain) (0.00s)
      		default_instance_class_test.go:99: not a recognized region
  FAIL
  FAIL		github.com/openshift/installer/platformtests/aws				71.420s

And as a new region without m4 support, we need to set its default to
m5 to avoid:

  $ AWS_PROFILE=openshift-dev go test .
  --- FAIL: TestGetDefaultInstanceClass (75.95s)
      --- FAIL: TestGetDefaultInstanceClass/Middle_East_(Bahrain) (1.96s)
      default_instance_class_test.go:107: no direct access to region, assuming full support: AuthFailure: AWS was not able to validate the provided access credentials
        status code: 401, request id: f05f9e76-2a63-40d1-8748-a67f6d637ba1
      default_instance_class_test.go:121: map[m5:{} m5d:{} t3:{}]
      default_instance_class_test.go:122:
        Error Trace:default_instance_class_test.go:122
        Error:      Not equal:
                    expected: "m4"
                    actual  : "m5"

                    Diff:
                    --- Expected
                    +++ Actual
                    @@ -1 +1 @@
                    -m4
                    +m5
        Test:       TestGetDefaultInstanceClass/Middle_East_(Bahrain)
  FAIL
  FAIL  github.com/openshift/installer/platformtests/aws75.965s

[1]: https://aws.amazon.com/about-aws/whats-new/2019/07/announcing-the-new-aws-middle-east--bahrain--region-/
[2]: aws/aws-sdk-go@384f453#diff-fe3b36d57dc4378fa7b13c85492f4119R49
@wking wking force-pushed the eu-north-1-validation branch from bf0369d to 612143d Compare September 3, 2019 21:48
@wking
Copy link
Member Author

wking commented Sep 3, 2019

Pushed bf0369dfe -> 612143d to fix the unit failure.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Sep 3, 2019

/hold

candidate for 4.3 when master opens.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2019
@wking
Copy link
Member Author

wking commented Oct 1, 2019

/hold cancel

Master is open for 4.3 fixes :). Still needs a /lgtm to merge.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 4, 2019

@wking: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 612143d link /test e2e-libvirt
ci/prow/e2e-aws-scaleup-rhel7 612143d link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-aws-disruptive 612143d link /test e2e-aws-disruptive

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking wking mentioned this pull request Oct 9, 2019
Merged
@wking
Copy link
Member Author

wking commented Oct 9, 2019

/assign @abhinavdahiya

Green enough to merge, and we want to land this before the 4.3 window closes ;)

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 9, 2019

/refresh

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 9, 2019

/skip

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 9, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4a07ba6 into openshift:master Oct 10, 2019
@wking wking deleted the eu-north-1-validation branch October 10, 2019 01:01
@sdodson
Copy link
Member

sdodson commented Oct 24, 2019

/cherrypick release-4.2

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 24, 2019
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 24, 2019

@sdodson: new pull request created: #2568

In response to this:

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@jstuever jstuever Awaiting requested review from jstuever

Assignees

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

please support region eu-north

6 participants

@wking @abhinavdahiya @openshift-ci-robot @sdodson @openshift-cherrypick-robot @openshift-merge-robot