Skip to content

install/update docs review #17153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kalexand-rh merged 1 commit into from
Oct 15, 2019
Merged

install/update docs review #17153

kalexand-rh merged 1 commit into from
Oct 15, 2019

Conversation

@kalexand-rh
Copy link
Contributor

@kalexand-rh kalexand-rh commented Oct 9, 2019

No description provided.

@kalexand-rh kalexand-rh added this to the Future Release milestone Oct 9, 2019
@kalexand-rh kalexand-rh requested a review from wking October 9, 2019 19:55
@kalexand-rh kalexand-rh self-assigned this Oct 9, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 9, 2019
kalexand-rh
kalexand-rh commented Oct 9, 2019
View reviewed changes
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Oct 9, 2019

The preview will be available shortly at:

wking
wking reviewed Oct 9, 2019
View reviewed changes
wking
wking reviewed Oct 9, 2019
View reviewed changes
wking
wking reviewed Oct 9, 2019
View reviewed changes
wking
wking reviewed Oct 9, 2019
View reviewed changes
wking
wking reviewed Oct 9, 2019
View reviewed changes
wking
wking reviewed Oct 9, 2019
View reviewed changes
wking
wking reviewed Oct 9, 2019
View reviewed changes
wking
wking reviewed Oct 9, 2019
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this :). Left a few nits inline.

@kalexand-rh
Copy link
Contributor Author

kalexand-rh commented Oct 10, 2019

Thank you for the review! I think I've fixed all your requests. Please let me know if you see anything else.

@kalexand-rh
Copy link
Contributor Author

kalexand-rh commented Oct 10, 2019

@jianlinliu, will you please take a look at these changes?

wking
wking reviewed Oct 10, 2019
View reviewed changes
jianlinliu
jianlinliu reviewed Oct 11, 2019
View reviewed changes
@jianlinliu
Copy link

jianlinliu commented Oct 15, 2019

LGTM.

@kalexand-rh kalexand-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 15, 2019
@kalexand-rh
Copy link
Contributor Author

kalexand-rh commented Oct 15, 2019

@openshift/team-documentation PTAL

@bergerhoffer bergerhoffer self-requested a review October 15, 2019 13:08
bergerhoffer
bergerhoffer reviewed Oct 15, 2019
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things!

@bergerhoffer bergerhoffer removed the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 15, 2019
@bergerhoffer bergerhoffer added the peer-review-done Signifies that the peer review team has reviewed this PR label Oct 15, 2019
@kalexand-rh kalexand-rh merged commit a331ce7 into openshift:master Oct 15, 2019
@kalexand-rh
Copy link
Contributor Author

kalexand-rh commented Oct 15, 2019

/cherrypick enterprise-4.2

@kalexand-rh kalexand-rh deleted the trevor branch October 15, 2019 13:57
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 15, 2019

@kalexand-rh: #17153 failed to apply on top of branch "enterprise-4.2":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	modules/architecture-platform-benefits.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/architecture-platform-benefits.adoc
CONFLICT (content): Merge conflict in modules/architecture-platform-benefits.adoc
Patch failed at 0001 install/update docs review
Details

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh kalexand-rh mentioned this pull request Oct 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

+2 more reviewers

@wking wking wking left review comments

@jianlinliu jianlinliu jianlinliu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kalexand-rh kalexand-rh

Labels

branch/enterprise-4.2 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.2 GA

Development

Successfully merging this pull request may close these issues.

8 participants

@kalexand-rh @openshift-docs-preview-bot @jianlinliu @openshift-cherrypick-robot @wking @bergerhoffer @vikram-redhat @openshift-ci-robot