-
Notifications
You must be signed in to change notification settings - Fork 423
CNTRLPLANE-1262: build(tools): upgrade golangci-lint to v2.6.2 #7268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cblecker
wants to merge
14
commits into
openshift:main
Choose a base branch
from
cblecker:build/upgrade-golangci-lint-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+200,257
−54,625
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3be7dde
build(tools): upgrade golangci-lint to v2.6.2
cblecker a7f3adf
build(tools): update vendored dependencies for golangci-lint v2
cblecker 53350a1
build(lint): update golangci-lint v2 exclusion rules
cblecker fa134be
refactor(lint): remove duplicate import exceptions
cblecker e444a69
build(lint): add QF1008 exception
cblecker e83c995
perf: use fmt.Fprintf instead of Write+Sprintf
cblecker c41851c
build(lint): add QF1007 and QF1001 exceptions
cblecker c4e6543
refactor(lint): use tagged switch statements
cblecker 350e82e
fix(lint): resolve remaining linting errors
cblecker 305bb39
refactor(lint): remove duplicate client import in etcd-recovery
cblecker de2c3f5
build(api): update golangci-lint exception rules for api/
cblecker 29be93c
build(api): remove obsolete golangci-lint exceptions
cblecker c203e87
build(lint): add kubeapilinter exceptions to config
cblecker b81bb6d
fix(api): restore CRD generation with gengo v2
cblecker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,64 +1,93 @@ | ||
| version: "2" | ||
| run: | ||
| timeout: 10m | ||
| allow-parallel-runners: true | ||
| output: | ||
| sort-results: true | ||
| severity: | ||
| default-severity: error | ||
| issues: | ||
| exclude-rules: | ||
| - linters: | ||
| - staticcheck | ||
| text: "SA1019: src.Spec.NodeCount is deprecated: Use Replicas instead. NodeCount will be dropped in the next api release" | ||
| - linters: | ||
| - staticcheck | ||
| text: "SA1019: in.Spec.NodeCount is deprecated: Use Replicas instead. NodeCount will be dropped in the next api release." | ||
| - linters: | ||
| - staticcheck | ||
| text: "SA1019: hcp.Status.Version is deprecated: Use versionStatus.desired.version instead." | ||
| - linters: | ||
| - staticcheck | ||
| text: "SA1019: hcp.Status.ReleaseImage is deprecated: Use versionStatus.desired.image instead." | ||
| - linters: | ||
| - staticcheck | ||
| text: "SA1019: hcp.Status.LastReleaseImageTransitionTime is deprecated" | ||
| - linters: | ||
| - staticcheck | ||
| text: "SA1019: in.Status.DNSName is deprecated" | ||
| - linters: | ||
| - staticcheck | ||
| text: "SA1019: infra.Status.Platform is deprecated: Use platformStatus.type instead" | ||
| - linters: | ||
| - unused | ||
| text: "const `tuningConfigKey` is unused" | ||
| linters: | ||
| enable: | ||
| - errcheck | ||
| - gci | ||
| - gosimple | ||
| - govet | ||
| - ineffassign | ||
| - misspell | ||
| - staticcheck | ||
| - unused | ||
| linters-settings: | ||
| gci: | ||
| sections: | ||
| - standard | ||
| - dot | ||
| - prefix(github.com/openshift/hypershift) | ||
| - prefix(github.com/openshift) | ||
| - prefix(github.com/aws) | ||
| - prefix(github.com/Azure) | ||
| - prefix(k8s.io) | ||
| - prefix(sigs.k8s.io) | ||
| - default | ||
| custom-order: true | ||
| misspell: | ||
| # The use of US spelling over other English spellings, like UK, is inline with the OpenShift conventions: | ||
| # https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#terminology-grammar-and-spelling | ||
| locale: US | ||
| # Typos to ignore. | ||
| # Should be in lower case. | ||
| ignore-words: | ||
| - nto | ||
| settings: | ||
| misspell: | ||
| # The use of US spelling over other English spellings, like UK, is inline with the OpenShift conventions: | ||
| # https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#terminology-grammar-and-spelling | ||
| locale: US | ||
| # Typos to ignore. | ||
| # Should be in lower case. | ||
| ignore-rules: | ||
| - nto | ||
| exclusions: | ||
| warn-unused: true | ||
| generated: lax | ||
| presets: | ||
| - comments | ||
| - common-false-positives | ||
| - legacy | ||
| - std-error-handling | ||
| rules: | ||
| - linters: | ||
| - staticcheck | ||
| text: 'SA1019: hcp.Status.Version is deprecated: Use versionStatus.desired.version instead.' | ||
| - linters: | ||
| - staticcheck | ||
| text: 'SA1019: hcp.Status.ReleaseImage is deprecated: Use versionStatus.desired.image instead.' | ||
| - linters: | ||
| - staticcheck | ||
| text: 'SA1019: hcp.Status.LastReleaseImageTransitionTime is deprecated' | ||
| - linters: | ||
| - staticcheck | ||
| text: 'SA1019: infra.Status.Platform is deprecated: Use platformStatus.type instead' | ||
| - linters: | ||
| - unused | ||
| text: const tuningConfigKey is unused | ||
| - linters: | ||
| - staticcheck | ||
| text: 'ST1001: should not use dot imports' | ||
| source: 'github.com/onsi/gomega' | ||
| - linters: | ||
| - staticcheck | ||
| text: 'ST1005: error strings should not be capitalized' | ||
| source: 'Konnectivity' | ||
| - linters: | ||
| - staticcheck | ||
| text: 'ST1019' | ||
| path: 'test/e2e/util/(util|kubevirt)\.go$' | ||
| - linters: | ||
| - staticcheck | ||
| text: 'ST1019' | ||
| path: 'support/util/util_test\.go$' | ||
| - linters: | ||
| - staticcheck | ||
| text: 'QF1008' | ||
| - linters: | ||
| - staticcheck | ||
| text: 'QF1007' | ||
| - linters: | ||
| - staticcheck | ||
| text: 'QF1001' | ||
| paths: | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ | ||
| severity: | ||
| default: error | ||
| formatters: | ||
| enable: | ||
| - gci | ||
| settings: | ||
| gci: | ||
| sections: | ||
| - standard | ||
| - dot | ||
| - prefix(github.com/openshift/hypershift) | ||
| - prefix(github.com/openshift) | ||
| - prefix(github.com/aws) | ||
| - prefix(github.com/Azure) | ||
| - prefix(k8s.io) | ||
| - prefix(sigs.k8s.io) | ||
| - default | ||
| custom-order: true | ||
| exclusions: | ||
| warn-unused: true | ||
| generated: lax | ||
| paths: | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.