CNTRLPLANE-1262: build(tools): upgrade golangci-lint to v2.6.2 #7268
+200,257
−54,625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughDeleted a custom golangci-kube-api-linter config, migrated golangci-lint to v2 with a reorganized config, updated tooling imports and go.mod pins, adjusted Makefile lint/plugin and generation flow, refactored a network reconcile branch to a switch, updated two etcd-recovery log calls to use Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to ⛔ Files ignored due to path filters (290)
📒 Files selected for processing (9)
💤 Files with no reviewable changes (2)
🚧 Files skipped from review as they are similar to previous changes (3)
🧰 Additional context used📓 Path-based instructions (1)**⚙️ CodeRabbit configuration file
Files:
🪛 golangci-lint (2.5.0)hack/tools/go.mod[error] 228-228: : # github.com/openshift/hypershift/sync-global-pullsecret [github.com/openshift/hypershift/sync-global-pullsecret.test] (typecheck) 🔇 Additional comments (6)
Comment |
openshift-ci
bot
added
area/api
cblecker
force-pushed
the
build/upgrade-golangci-lint-v2
branch
from
ffcc731 to
f067bce
Compare
cblecker
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@cblecker: This pull request references CNTRLPLANE-1262 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@cblecker: This pull request references CNTRLPLANE-1262 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
cblecker
force-pushed
the
build/upgrade-golangci-lint-v2
branch
from
086b10c to
21bd059
Compare
openshift-ci
bot
added
the
area/testing
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
control-plane-operator/controllers/hostedcontrolplane/hostedcontrolplane_controller.go (1)
1259-1262: Confirm staticcheck is still suppressed correctly for ST1005The new
//nolint:staticcheck // ST1005: Konnectivity is a proper namedirective will be honored by golangci-lint, but the standalonestaticcheckbinary invoked viamake staticchecklooks for//lint:ignore///lint:file-ignoreinstead. If ST1005 is still enabled there, this line may continue to be reported.Consider either:
- Keeping a
//lint:ignore ST1005for the standalone staticcheck run, or- Disabling ST1005 in staticcheck’s own configuration if you no longer want per-site directives.
Makefile (1)
69-86: golangci-lint v2 and kube-api-linter plugin wiring looks correctBuilding golangci-lint from the
hack/toolsmodule and compiling the kube-api-linter Go plugin intotools/bin/kube-api-linter.so, then makinglint/lint-fixdepend on both, is a clean way to keep CI’s lint setup reproducible.If you want to decouple from the vendor layout a bit further, consider building the plugin via its module path (
sigs.k8s.io/kube-api-linter/pkg/plugin) instead of./vendor/...; withGOFLAGS=-mod=vendoryou’ll still use vendored deps without hard-coding the directory path.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
⛔ Files ignored due to path filters (232)
hack/tools/go.sumis excluded by!**/*.sumhack/tools/vendor/cel.dev/expr/.bazelversionis excluded by!**/vendor/**hack/tools/vendor/cel.dev/expr/MODULE.bazelis excluded by!**/vendor/**hack/tools/vendor/cel.dev/expr/README.mdis excluded by!**/vendor/**hack/tools/vendor/cel.dev/expr/cloudbuild.yamlis excluded by!**/vendor/**hack/tools/vendor/cel.dev/expr/eval.pb.gois excluded by!**/*.pb.go,!**/vendor/**hack/tools/vendor/codeberg.org/chavacava/garif/.gitignoreis excluded by!**/vendor/**hack/tools/vendor/codeberg.org/chavacava/garif/LICENSEis excluded by!**/vendor/**hack/tools/vendor/codeberg.org/chavacava/garif/README.mdis excluded by!**/vendor/**hack/tools/vendor/codeberg.org/chavacava/garif/constructors.gois excluded by!**/vendor/**hack/tools/vendor/codeberg.org/chavacava/garif/decorators.gois excluded by!**/vendor/**hack/tools/vendor/codeberg.org/chavacava/garif/doc.gois excluded by!**/vendor/**hack/tools/vendor/codeberg.org/chavacava/garif/enums.gois excluded by!**/vendor/**hack/tools/vendor/codeberg.org/chavacava/garif/io.gois excluded by!**/vendor/**hack/tools/vendor/codeberg.org/chavacava/garif/models.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/exhaustruct/v4/LICENSEis excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/exhaustruct/v4/analyzer/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/exhaustruct/v4/analyzer/config.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/exhaustruct/v4/internal/comment/cache.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/exhaustruct/v4/internal/comment/directive.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/exhaustruct/v4/internal/pattern/list.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/exhaustruct/v4/internal/structure/fields-cache.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/exhaustruct/v4/internal/structure/fields.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/golib/LICENSEis excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/golib/e/doc.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/golib/e/err.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/golib/e/log.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/golib/fields/dict.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/golib/fields/doc.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/golib/fields/field.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/golib/fields/list.gois excluded by!**/vendor/**hack/tools/vendor/github.com/4meepo/tagalign/tagalign.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Abirdcfly/dupword/README.mdis excluded by!**/vendor/**hack/tools/vendor/github.com/Abirdcfly/dupword/dupword.gois excluded by!**/vendor/**hack/tools/vendor/github.com/AdminBenni/iota-mixing/LICENSEis excluded by!**/vendor/**hack/tools/vendor/github.com/AdminBenni/iota-mixing/pkg/analyzer/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/AdminBenni/iota-mixing/pkg/analyzer/flags/flags.gois excluded by!**/vendor/**hack/tools/vendor/github.com/AlwxSin/noinlineerr/.gitignoreis excluded by!**/vendor/**hack/tools/vendor/github.com/AlwxSin/noinlineerr/.golangci.ymlis excluded by!**/vendor/**hack/tools/vendor/github.com/AlwxSin/noinlineerr/.goreleaser.ymlis excluded by!**/vendor/**hack/tools/vendor/github.com/AlwxSin/noinlineerr/LICENSEis excluded by!**/vendor/**hack/tools/vendor/github.com/AlwxSin/noinlineerr/README.mdis excluded by!**/vendor/**hack/tools/vendor/github.com/AlwxSin/noinlineerr/noinlineerr.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/errname/pkg/analyzer/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/nilnil/pkg/analyzer/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/analyzer/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/analyzer/checkers_factory.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/bool_compare.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/call_meta.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/checker.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/checkers_registry.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/empty.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/equal_values.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/error_is_as.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/error_nil.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/expected_actual.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/formatter.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/go_require.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_basic_type.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_bool.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_comparison.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_context.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_diagnostic.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_http.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_len.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/len.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/negative_positive.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/require_error.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/suite_method_signature.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/suite_thelper.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/useless_assert.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/config/config.gois excluded by!**/vendor/**hack/tools/vendor/github.com/BurntSushi/toml/README.mdis excluded by!**/vendor/**hack/tools/vendor/github.com/BurntSushi/toml/decode.gois excluded by!**/vendor/**hack/tools/vendor/github.com/BurntSushi/toml/encode.gois excluded by!**/vendor/**hack/tools/vendor/github.com/BurntSushi/toml/error.gois excluded by!**/vendor/**hack/tools/vendor/github.com/BurntSushi/toml/lex.gois excluded by!**/vendor/**hack/tools/vendor/github.com/BurntSushi/toml/meta.gois excluded by!**/vendor/**hack/tools/vendor/github.com/BurntSushi/toml/parse.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Crocmagnon/fatcontext/pkg/analyzer/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Djarvur/go-err113/.travis.ymlis excluded by!**/vendor/**hack/tools/vendor/github.com/Djarvur/go-err113/comparison.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Djarvur/go-err113/err113.gois excluded by!**/vendor/**hack/tools/vendor/github.com/GaijinEntertainment/go-exhaustruct/v3/analyzer/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/GaijinEntertainment/go-exhaustruct/v3/internal/pattern/list.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/.custom-gcl.ymlis excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/.gitignoreis excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/.golangci.yamlis excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/Makefileis excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/README.mdis excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/cmd/kal/main.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/commentstart/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/commentstart/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/commentstart/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/conditions/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/conditions/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/conditions/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/helpers/extractjsontags/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/helpers/extractjsontags/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/helpers/inspector/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/helpers/inspector/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/helpers/inspector/inspector.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/helpers/markers/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/helpers/markers/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/helpers/markers/registry.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/integers/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/integers/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/integers/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/jsontags/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/jsontags/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/jsontags/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/maxlength/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/maxlength/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/maxlength/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/nobools/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/nobools/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/nobools/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/nofloats/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/nofloats/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/nofloats/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/nophase/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/nophase/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/nophase/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/optionalorrequired/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/optionalorrequired/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/optionalorrequired/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/registry.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/requiredfields/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/requiredfields/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/requiredfields/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/statussubresource/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/statussubresource/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/statussubresource/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/utils/type_check.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/config/config.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/config/linters.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/config/linters_config.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/validation/config.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/validation/linters.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/validation/linters_config.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/plugin.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Masterminds/semver/v3/CHANGELOG.mdis excluded by!**/vendor/**hack/tools/vendor/github.com/Masterminds/semver/v3/README.mdis excluded by!**/vendor/**hack/tools/vendor/github.com/Masterminds/semver/v3/constraints.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Masterminds/semver/v3/version.gois excluded by!**/vendor/**hack/tools/vendor/github.com/MirrexOne/unqueryvet/.gitignoreis excluded by!**/vendor/**hack/tools/vendor/github.com/MirrexOne/unqueryvet/LICENSEis excluded by!**/vendor/**hack/tools/vendor/github.com/MirrexOne/unqueryvet/Makefileis excluded by!**/vendor/**hack/tools/vendor/github.com/MirrexOne/unqueryvet/README.mdis excluded by!**/vendor/**hack/tools/vendor/github.com/MirrexOne/unqueryvet/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/MirrexOne/unqueryvet/config.gois excluded by!**/vendor/**hack/tools/vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/MirrexOne/unqueryvet/pkg/config/config.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/.editorconfigis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/.gitignoreis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/.golangci.ymlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/.goreleaser.ymlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/Bitfileis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/COPYINGis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/Dockerfileis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/Makefileis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/README.mdis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/biome.jsonis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/chroma.jpgis excluded by!**/*.jpg,!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/coalesce.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/colour.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/delegate.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/emitters.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/formatter.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/formatters/api.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/formatters/html/html.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/formatters/json.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/formatters/svg/font_liberation_mono.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/formatters/svg/svg.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/formatters/tokens.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/formatters/tty_indexed.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/formatters/tty_truecolour.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/iterator.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/README.mdis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/caddyfile.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/cl.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/dns.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/emacs.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/abap.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/abnf.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/actionscript.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/actionscript_3.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/ada.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/agda.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/al.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/alloy.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/angular2.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/antlr.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/apacheconf.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/apl.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/applescript.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/arangodb_aql.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/arduino.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/armasm.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/atl.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/autohotkey.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/autoit.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/awk.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/ballerina.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bash.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bash_session.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/batchfile.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/beef.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bibtex.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bicep.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/blitzbasic.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bnf.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bqn.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/brainfuck.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/c#.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/c++.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/c.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cap_n_proto.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cassandra_cql.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/ceylon.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cfengine3.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cfstatement.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/chaiscript.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/chapel.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cheetah.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/clojure.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cmake.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cobol.xmlis excluded by!**/vendor/**
📒 Files selected for processing (67)
.custom-gcl.yml(0 hunks).golangci.yml(1 hunks)Makefile(3 hunks)api/hypershift/v1beta1/doc.go(1 hunks)api/hypershift/v1beta1/groupversion_info.go(0 hunks)cmd/install/assets/cluster-api-provider-agent/capi-provider.agent-install.openshift.io_agentclusters.yaml(1 hunks)cmd/install/assets/cluster-api-provider-agent/capi-provider.agent-install.openshift.io_agentmachines.yaml(1 hunks)cmd/install/assets/cluster-api-provider-agent/capi-provider.agent-install.openshift.io_agentmachinetemplates.yaml(1 hunks)cmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsclustercontrolleridentities.yaml(1 hunks)cmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsclusterroleidentities.yaml(1 hunks)cmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsclusters.yaml(1 hunks)cmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsclusterstaticidentities.yaml(1 hunks)cmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsclustertemplates.yaml(1 hunks)cmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsmachinepools.yaml(1 hunks)cmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsmachines.yaml(1 hunks)cmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsmachinetemplates.yaml(1 hunks)cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureasomanagedclusters.yaml(1 hunks)cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureasomanagedclustertemplates.yaml(1 hunks)cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureasomanagedcontrolplanes.yaml(1 hunks)cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureasomanagedcontrolplanetemplates.yaml(1 hunks)cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureasomanagedmachinepools.yaml(1 hunks)cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureasomanagedmachinepooltemplates.yaml(1 hunks)cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureclusteridentities.yaml(1 hunks)cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureclusters.yaml(1 hunks)cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureclustertemplates.yaml(1 hunks)cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azuremachines.yaml(1 hunks)cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azuremachinetemplates.yaml(1 hunks)cmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmpowervsclusters.yaml(1 hunks)cmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmpowervsclustertemplates.yaml(1 hunks)cmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmpowervsimages.yaml(1 hunks)cmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmpowervsmachines.yaml(1 hunks)cmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmpowervsmachinetemplates.yaml(1 hunks)cmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmvpcclusters.yaml(1 hunks)cmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmvpcclustertemplates.yaml(1 hunks)cmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmvpcmachines.yaml(1 hunks)cmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmvpcmachinetemplates.yaml(1 hunks)cmd/install/assets/cluster-api-provider-kubevirt/infrastructure.cluster.x-k8s.io_kubevirtclusters.yaml(1 hunks)cmd/install/assets/cluster-api-provider-kubevirt/infrastructure.cluster.x-k8s.io_kubevirtclustertemplates.yaml(1 hunks)cmd/install/assets/cluster-api-provider-kubevirt/infrastructure.cluster.x-k8s.io_kubevirtmachines.yaml(1 hunks)cmd/install/assets/cluster-api-provider-kubevirt/infrastructure.cluster.x-k8s.io_kubevirtmachinetemplates.yaml(1 hunks)cmd/install/assets/cluster-api-provider-openstack/infrastructure.cluster.x-k8s.io_openstackclusters.yaml(1 hunks)cmd/install/assets/cluster-api-provider-openstack/infrastructure.cluster.x-k8s.io_openstackclustertemplates.yaml(1 hunks)cmd/install/assets/cluster-api-provider-openstack/infrastructure.cluster.x-k8s.io_openstackfloatingippools.yaml(1 hunks)cmd/install/assets/cluster-api-provider-openstack/infrastructure.cluster.x-k8s.io_openstackmachines.yaml(1 hunks)cmd/install/assets/cluster-api-provider-openstack/infrastructure.cluster.x-k8s.io_openstackmachinetemplates.yaml(1 hunks)cmd/install/assets/cluster-api-provider-openstack/infrastructure.cluster.x-k8s.io_openstackservers.yaml(1 hunks)cmd/install/assets/cluster-api-provider-openstack/openstack.k-orc.cloud_images.yaml(1 hunks)cmd/install/assets/cluster-api/addons.cluster.x-k8s.io_clusterresourcesetbindings.yaml(1 hunks)cmd/install/assets/cluster-api/addons.cluster.x-k8s.io_clusterresourcesets.yaml(1 hunks)cmd/install/assets/cluster-api/cluster.x-k8s.io_clusterclasses.yaml(1 hunks)cmd/install/assets/cluster-api/cluster.x-k8s.io_clusters.yaml(1 hunks)cmd/install/assets/cluster-api/cluster.x-k8s.io_machinedeployments.yaml(1 hunks)cmd/install/assets/cluster-api/cluster.x-k8s.io_machinedrainrules.yaml(1 hunks)cmd/install/assets/cluster-api/cluster.x-k8s.io_machinehealthchecks.yaml(1 hunks)cmd/install/assets/cluster-api/cluster.x-k8s.io_machinepools.yaml(1 hunks)cmd/install/assets/cluster-api/cluster.x-k8s.io_machines.yaml(1 hunks)cmd/install/assets/cluster-api/cluster.x-k8s.io_machinesets.yaml(1 hunks)cmd/install/assets/cluster-api/ipam.cluster.x-k8s.io_ipaddressclaims.yaml(1 hunks)cmd/install/assets/cluster-api/ipam.cluster.x-k8s.io_ipaddresses.yaml(1 hunks)cmd/install/assets/hypershift-operator/certificates.hypershift.openshift.io_certificaterevocationrequests.yaml(1 hunks)cmd/install/assets/hypershift-operator/certificates.hypershift.openshift.io_certificatesigningrequestapprovals.yaml(1 hunks)cmd/install/assets/hypershift-operator/scheduling.hypershift.openshift.io_clustersizingconfigurations.yaml(1 hunks)control-plane-operator/controllers/hostedcontrolplane/hostedcontrolplane_controller.go(1 hunks)control-plane-operator/hostedclusterconfigoperator/controllers/resources/network/reconcile.go(1 hunks)etcd-recovery/etcdrecovery.go(1 hunks)hack/tools/go.mod(5 hunks)hack/tools/tools.go(1 hunks)
💤 Files with no reviewable changes (2)
- .custom-gcl.yml
- api/hypershift/v1beta1/groupversion_info.go
✅ Files skipped from review due to trivial changes (2)
- cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureasomanagedmachinepools.yaml
- cmd/install/assets/cluster-api/cluster.x-k8s.io_clusters.yaml
🚧 Files skipped from review as they are similar to previous changes (41)
- cmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmvpcmachines.yaml
- cmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmpowervsimages.yaml
- cmd/install/assets/hypershift-operator/scheduling.hypershift.openshift.io_clustersizingconfigurations.yaml
- cmd/install/assets/cluster-api-provider-kubevirt/infrastructure.cluster.x-k8s.io_kubevirtmachines.yaml
- cmd/install/assets/cluster-api-provider-kubevirt/infrastructure.cluster.x-k8s.io_kubevirtmachinetemplates.yaml
- cmd/install/assets/cluster-api/cluster.x-k8s.io_machinehealthchecks.yaml
- cmd/install/assets/cluster-api/cluster.x-k8s.io_machinepools.yaml
- cmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmvpcclustertemplates.yaml
- cmd/install/assets/cluster-api-provider-agent/capi-provider.agent-install.openshift.io_agentmachinetemplates.yaml
- .golangci.yml
- cmd/install/assets/cluster-api-provider-openstack/infrastructure.cluster.x-k8s.io_openstackmachinetemplates.yaml
- cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureclusters.yaml
- cmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmpowervsclusters.yaml
- cmd/install/assets/cluster-api/cluster.x-k8s.io_clusterclasses.yaml
- cmd/install/assets/cluster-api-provider-kubevirt/infrastructure.cluster.x-k8s.io_kubevirtclustertemplates.yaml
- cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureasomanagedcontrolplanetemplates.yaml
- cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureasomanagedmachinepooltemplates.yaml
- cmd/install/assets/cluster-api-provider-agent/capi-provider.agent-install.openshift.io_agentmachines.yaml
- cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureclusteridentities.yaml
- api/hypershift/v1beta1/doc.go
- cmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmpowervsmachinetemplates.yaml
- cmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsclusterstaticidentities.yaml
- etcd-recovery/etcdrecovery.go
- cmd/install/assets/cluster-api/cluster.x-k8s.io_machinedrainrules.yaml
- control-plane-operator/hostedclusterconfigoperator/controllers/resources/network/reconcile.go
- cmd/install/assets/cluster-api/ipam.cluster.x-k8s.io_ipaddresses.yaml
- cmd/install/assets/cluster-api-provider-openstack/infrastructure.cluster.x-k8s.io_openstackclusters.yaml
- cmd/install/assets/cluster-api-provider-agent/capi-provider.agent-install.openshift.io_agentclusters.yaml
- cmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsclusterroleidentities.yaml
- cmd/install/assets/cluster-api/cluster.x-k8s.io_machines.yaml
- cmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmpowervsclustertemplates.yaml
- cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azuremachines.yaml
- cmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsclustercontrolleridentities.yaml
- cmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsclustertemplates.yaml
- cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azuremachinetemplates.yaml
- cmd/install/assets/hypershift-operator/certificates.hypershift.openshift.io_certificaterevocationrequests.yaml
- cmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmvpcclusters.yaml
- cmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsmachines.yaml
- cmd/install/assets/cluster-api-provider-openstack/openstack.k-orc.cloud_images.yaml
- cmd/install/assets/cluster-api/addons.cluster.x-k8s.io_clusterresourcesetbindings.yaml
- cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureasomanagedclusters.yaml
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.
Files:
cmd/install/assets/cluster-api-provider-kubevirt/infrastructure.cluster.x-k8s.io_kubevirtclusters.yamlcmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsmachinepools.yamlcmd/install/assets/cluster-api-provider-openstack/infrastructure.cluster.x-k8s.io_openstackclustertemplates.yamlhack/tools/go.modcmd/install/assets/cluster-api/ipam.cluster.x-k8s.io_ipaddressclaims.yamlcmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureclustertemplates.yamlcmd/install/assets/cluster-api-provider-openstack/infrastructure.cluster.x-k8s.io_openstackservers.yamlcmd/install/assets/cluster-api/cluster.x-k8s.io_machinesets.yamlcmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsclusters.yamlcmd/install/assets/cluster-api/addons.cluster.x-k8s.io_clusterresourcesets.yamlcmd/install/assets/cluster-api-provider-openstack/infrastructure.cluster.x-k8s.io_openstackfloatingippools.yamlcmd/install/assets/hypershift-operator/certificates.hypershift.openshift.io_certificatesigningrequestapprovals.yamlcmd/install/assets/cluster-api-provider-openstack/infrastructure.cluster.x-k8s.io_openstackmachines.yamlhack/tools/tools.gocmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureasomanagedcontrolplanes.yamlMakefilecmd/install/assets/cluster-api/cluster.x-k8s.io_machinedeployments.yamlcmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmpowervsmachines.yamlcmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsmachinetemplates.yamlcontrol-plane-operator/controllers/hostedcontrolplane/hostedcontrolplane_controller.gocmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureasomanagedclustertemplates.yamlcmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmvpcmachinetemplates.yaml
🪛 golangci-lint (2.5.0)
hack/tools/go.mod
[error] 228-228: : # github.com/openshift/hypershift/sync-global-pullsecret [github.com/openshift/hypershift/sync-global-pullsecret.test]
sync-global-pullsecret/sync-global-pullsecret_test.go:228:23: undefined: MockdbusConn
sync-global-pullsecret/sync-global-pullsecret_test.go:234:26: undefined: MockdbusConn
sync-global-pullsecret/sync-global-pullsecret_test.go:247:26: undefined: MockdbusConn
sync-global-pullsecret/sync-global-pullsecret_test.go:257:26: undefined: MockdbusConn
sync-global-pullsecret/sync-global-pullsecret_test.go:270:26: undefined: MockdbusConn
sync-global-pullsecret/sync-global-pullsecret_test.go:283:26: undefined: MockdbusConn
sync-global-pullsecret/sync-global-pullsecret_test.go:296:26: undefined: MockdbusConn
sync-global-pullsecret/sync-global-pullsecret_test.go:309:26: undefined: MockdbusConn
sync-global-pullsecret/sync-global-pullsecret_test.go:327:12: undefined: NewMockdbusConn
(typecheck)
🔇 Additional comments (20)
cmd/install/assets/cluster-api-provider-openstack/infrastructure.cluster.x-k8s.io_openstackclustertemplates.yaml (1)
6-6: LGTM!The controller-gen annotation version update from v0.15.0 to v0.18.0 is a straightforward metadata change with no impact on CRD schema, validation rules, or API behavior. This aligns with the PR's tooling version updates.
cmd/install/assets/cluster-api/addons.cluster.x-k8s.io_clusterresourcesets.yaml (1)
6-6: Annotation version bump is appropriate.The controller-gen version update from v0.15.0 to v0.18.0 is consistent with the PR objectives and aligns with the broader tooling upgrade across multiple CRD manifests. The change is a generated artifact update with no impact on the resource definition structure or behavior.
cmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmpowervsmachines.yaml (1)
6-6: Metadata annotation update approved.The
controller-gen.kubebuilder.io/versionannotation correctly reflects the tooling upgrade from v0.15.0 to v0.18.0 as part of the broader golangci-lint v2 migration. This is a metadata-only change; the CRD spec, schema, and behavior remain unchanged.cmd/install/assets/cluster-api/ipam.cluster.x-k8s.io_ipaddressclaims.yaml (1)
6-6: Metadata annotation update is appropriate.The controller-gen version annotation has been updated to v0.18.0, which is consistent with the broader tooling upgrades reflected in this PR and documented in the AI summary as part of coordinated CRD generation updates across multiple manifests. The change is metadata-only and does not affect the CRD schema or functionality.
cmd/install/assets/cluster-api-provider-ibmcloud/infrastructure.cluster.x-k8s.io_ibmvpcmachinetemplates.yaml (1)
6-6: Annotation update is correct and aligns with tool upgrade.This metadata annotation change appropriately reflects the controller-gen v0.18.0 upgrade. The CRD structure and behavior remain unchanged.
cmd/install/assets/cluster-api-provider-openstack/infrastructure.cluster.x-k8s.io_openstackmachines.yaml (1)
6-6: LGTM!The annotation update to reflect controller-gen v0.18.0 is straightforward and aligns with the PR's coordinated tool version upgrades. No functional changes to the CRD schema.
cmd/install/assets/hypershift-operator/certificates.hypershift.openshift.io_certificatesigningrequestapprovals.yaml (1)
6-6: Annotation update to reflect controller-gen v0.18.0.The controller-gen annotation has been updated from v0.15.0 to v0.18.0, reflecting the version of the tool used to generate this CRD. This is a metadata-only change with no functional impact on the resource definition. Assuming this annotation update is consistent across all affected CRDs in the PR (as indicated in the AI summary), this change aligns with the PR's stated updates.
To confirm consistency, please verify that this annotation update has been applied to all affected CRD manifests in the PR and that the controller-gen version bump is aligned with the project's dependency management.
cmd/install/assets/cluster-api-provider-kubevirt/infrastructure.cluster.x-k8s.io_kubevirtclusters.yaml (1)
6-6: Controller-gen version annotation updated correctly.The annotation reflects the tooling version upgrade from v0.15.0 to v0.18.0 as part of the PR objectives. The CRD schema and API behavior remain unchanged and unaffected by this metadata-only update.
cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureclustertemplates.yaml (1)
6-6: Approved: Metadata annotation update.The change correctly updates the
controller-gen.kubebuilder.io/versionannotation to reflect the new tooling version (v0.18.0) used to generate/validate this CRD. No structural or behavioral changes to the CRD specification itself.cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureasomanagedclustertemplates.yaml (1)
6-6: Approved: Metadata annotation update.Consistent with the tooling upgrade, the
controller-gen.kubebuilder.io/versionannotation is updated to v0.18.0. The CRD schema and validation rules remain unchanged.cmd/install/assets/cluster-api-provider-azure/infrastructure.cluster.x-k8s.io_azureasomanagedcontrolplanes.yaml (1)
6-6: Approved: Metadata annotation update.The
controller-gen.kubebuilder.io/versionannotation correctly reflects the upgraded tool version (v0.18.0). No changes to CRD structure, schema, or runtime behavior.cmd/install/assets/cluster-api-provider-openstack/infrastructure.cluster.x-k8s.io_openstackfloatingippools.yaml (1)
6-6: Metadata annotation version bump is correct.The update from
v0.15.0tov0.18.0reflects the controller-gen version upgrade and aligns with the PR objectives. This is a routine and safe metadata-only update to auto-generated CRD manifests, with no impact on schema, validation, or runtime behavior.cmd/install/assets/cluster-api/cluster.x-k8s.io_machinesets.yaml (1)
6-6: Verify regeneration with controller-gen v0.18.0.The controller-gen annotation was updated from v0.15.0 to v0.18.0, which is consistent with the golangci-lint upgrade. Since these are auto-generated manifests, please confirm that:
- The CRD was regenerated using controller-gen v0.18.0 (not manually edited)
- The schema structure, validations, and field definitions remain semantically equivalent
- All similar CRD files across the repository were regenerated consistently
The visible changes are minimal and appropriate for a toolchain upgrade.
cmd/install/assets/cluster-api/cluster.x-k8s.io_machinedeployments.yaml (1)
6-6: Verify regeneration consistency across CRD files.The controller-gen annotation update to v0.18.0 mirrors the change in the preceding MachineSet CRD. Since both files show identical patterns (annotation-only changes with all schema structure preserved), ensure that the regeneration was applied uniformly across all CRD manifests in this PR to maintain consistency.
cmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsmachinetemplates.yaml (1)
6-6: Consistent with the PR intent; safe metadata update.Verification confirms all controller-gen versions across the AWS provider assets are consistently v0.18.0, with no drift detected. Recommend syncing these assets with upstream CAPA at the same generator level to avoid future drift.
cmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsmachinepools.yaml (1)
6-6: Specific file is correct; repository version consistency concern requires clarification.Verification confirms the target file correctly uses
v0.18.0. However, the codebase contains multiple controller-gen versions:v0.18.0(mostcmd/install/assets/manifests),v0.17.2(karpenter assets), andv0.13.0(test integration assets). Confirm whether this version divergence is intentional or requires reconciliation.cmd/install/assets/cluster-api-provider-openstack/infrastructure.cluster.x-k8s.io_openstackservers.yaml (1)
5-7: Controller-gen version annotation bump looks fineOnly the
controller-gen.kubebuilder.io/versionannotation changed tov0.18.0; schema and CRD behavior are untouched. No further action needed here.hack/tools/tools.go (1)
9-12: golangci-lint v2 import path wiring is consistentImporting
github.com/golangci/golangci-lint/v2/cmd/golangci-lintaligns with the v2 module and the version pinned inhack/tools/go.mod. No issues from a tooling/maintainability perspective.Makefile (2)
175-190: Running hypershift API codegen from ./api module is a good adjustmentSwitching the three
$(CODE_GEN)invocations to:(cd ./api && $(CODE_GEN) empty-partial-schemas) (cd ./api && $(CODE_GEN) schemapatch) (cd ./api && $(CODE_GEN) crd-manifest-merge --manifest-merge:payload-manifest-path ./hypershift/v1beta1/featuregates)matches the dedicated
apimodule layout and keeps the payload path relative to that module. The subsequent move ofzz_generated.crd-manifestsintocmd/install/assets/hypershift-operator/is unchanged and still correct.
409-425: Codespell and gitlint bootstrap tweaks are safe
- For
codespell, usingpip install --target=... --upgradeinto a local tools dir and then moving the wrapper binary keeps the requested version pinned and isolated from system Python.- For
gitlint, copying the installed script togitlint-binand explicitlychmod +xensures the wrapper is executable in all environments.These changes improve robustness of the local tooling setup without impacting the main build.
cmd/install/assets/cluster-api-provider-aws/infrastructure.cluster.x-k8s.io_awsclusters.yaml
Outdated
Show resolved
Hide resolved
cblecker
force-pushed
the
build/upgrade-golangci-lint-v2
branch
from
21bd059 to
cb11dd2
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
client/clientset/clientset/fake/clientset_generated.go (1)
31-31: Watch reactors correctly propagateListOptions; consider minor cleanupsThe new logic that extracts
metav1.ListOptionsfrom the watch action and passes it intoo.Watch(gvr, ns, opts)looks correct and should make fake watches honor selectors/other options set by callers (e.g., viaListOptions). No functional issues stand out here.Two small, optional improvements:
Fix the local name typo for readability
In both reactors (Line 60 and Line 113),
watchActcionis misspelled. Renaming improves clarity and avoids future confusion.
if watchActcion, ok := action.(testing.WatchActionImpl); ok {opts = watchActcion.ListOptions
if watchAction, ok := action.(testing.WatchActionImpl); ok {opts = watchAction.ListOptions }Apply this in both `NewSimpleClientset` and `NewClientset` watch reactors.
(Optional) Prefer the interface type over the concrete impl
If your vendored
k8s.io/client-go/testingexposes aWatchActioninterface (as in upstream client-go), you might consider asserting against that interface instead ofWatchActionImplto reduce coupling to the concrete implementation:if wa, ok := action.(testing.WatchAction); ok { // adapt based on how your client-go version exposes options/restrictions }This is only worth doing if it aligns cleanly with your current client-go version; otherwise the current approach is acceptable.
Please double‑check your exact
k8s.io/client-go/testingversion to confirm whether switching to the interface is practical in this repo.Also applies to: 59-66, 112-119
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (17)
Makefile(3 hunks)api/hypershift/v1beta1/doc.go(1 hunks)api/hypershift/v1beta1/groupversion_info.go(0 hunks)client/clientset/clientset/fake/clientset_generated.go(3 hunks)client/clientset/clientset/typed/certificates/v1alpha1/certificates_client.go(3 hunks)client/clientset/clientset/typed/hypershift/v1beta1/hypershift_client.go(3 hunks)client/clientset/clientset/typed/karpenter/v1beta1/karpenter_client.go(3 hunks)client/clientset/clientset/typed/scheduling/v1alpha1/scheduling_client.go(3 hunks)client/informers/externalversions/certificates/v1alpha1/certificaterevocationrequest.go(1 hunks)client/informers/externalversions/certificates/v1alpha1/certificatesigningrequestapproval.go(1 hunks)client/informers/externalversions/hypershift/v1beta1/certificatesigningrequestapproval.go(1 hunks)client/informers/externalversions/hypershift/v1beta1/gcpprivateserviceconnect.go(1 hunks)client/informers/externalversions/hypershift/v1beta1/hostedcluster.go(1 hunks)client/informers/externalversions/hypershift/v1beta1/hostedcontrolplane.go(1 hunks)client/informers/externalversions/hypershift/v1beta1/nodepool.go(1 hunks)client/informers/externalversions/karpenter/v1beta1/openshiftec2nodeclass.go(1 hunks)client/informers/externalversions/scheduling/v1alpha1/clustersizingconfiguration.go(1 hunks)
💤 Files with no reviewable changes (1)
- api/hypershift/v1beta1/groupversion_info.go
🚧 Files skipped from review as they are similar to previous changes (2)
- api/hypershift/v1beta1/doc.go
- Makefile
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.
Files:
client/clientset/clientset/typed/certificates/v1alpha1/certificates_client.goclient/clientset/clientset/typed/karpenter/v1beta1/karpenter_client.goclient/informers/externalversions/scheduling/v1alpha1/clustersizingconfiguration.goclient/clientset/clientset/typed/hypershift/v1beta1/hypershift_client.goclient/informers/externalversions/hypershift/v1beta1/certificatesigningrequestapproval.goclient/informers/externalversions/karpenter/v1beta1/openshiftec2nodeclass.goclient/informers/externalversions/hypershift/v1beta1/gcpprivateserviceconnect.goclient/informers/externalversions/hypershift/v1beta1/hostedcluster.goclient/informers/externalversions/hypershift/v1beta1/hostedcontrolplane.goclient/clientset/clientset/typed/scheduling/v1alpha1/scheduling_client.goclient/informers/externalversions/hypershift/v1beta1/nodepool.goclient/informers/externalversions/certificates/v1alpha1/certificatesigningrequestapproval.goclient/clientset/clientset/fake/clientset_generated.goclient/informers/externalversions/certificates/v1alpha1/certificaterevocationrequest.go
🔇 Additional comments (14)
client/informers/externalversions/hypershift/v1beta1/hostedcluster.go (1)
60-83: Context-aware List/Watch wiring looks correct
ListFunc/WatchFuncnow usecontext.Background(), and the newListWithContextFunc/WatchFuncWithContextcorrectly mirror the same behavior while honoring the passed-inctxandtweakListOptions. This is a clean, straightforward change with no apparent correctness or maintainability issues.client/clientset/clientset/typed/scheduling/v1alpha1/scheduling_client.go (1)
47-47: LGTM: Safe simplification of generated code.The removal of error handling from
setConfigDefaultsis appropriate since the function only performs simple field assignments that cannot fail. The constructors still properly handle errors fromrest.HTTPClientForandrest.RESTClientForConfigAndClient.Also applies to: 59-59, 82-91
client/informers/externalversions/hypershift/v1beta1/nodepool.go (1)
64-83: LGTM! Context handling improvements are well-implemented.The changes enhance context propagation in the informer:
- Switching from
context.TODO()tocontext.Background()in the original functions is appropriate for root-level contexts.- The new
ListWithContextFuncandWatchFuncWithContextenable callers to pass explicit contexts for better cancellation and deadline handling.- Backward compatibility is maintained by preserving the original
ListFuncandWatchFunc.Note: Since this is generated code (line 16), these improvements reflect updates to the
informer-gentool itself, and the pattern is consistently applied across multiple informer files per the PR summary.client/informers/externalversions/hypershift/v1beta1/gcpprivateserviceconnect.go (1)
64-83: LGTM! Context handling improvements are well-implemented.The changes correctly replace
context.TODO()withcontext.Background()for background informer operations and add context-aware variants (ListWithContextFunc,WatchFuncWithContext) that enable proper context propagation. The implementation correctly preserves thetweakListOptionsbehavior in all variants and maintains backward compatibility.client/informers/externalversions/karpenter/v1beta1/openshiftec2nodeclass.go (1)
64-83: LGTM! Context-aware ListWatch hooks properly implemented.This generated code correctly adds context-aware variants (
ListWithContextFunc,WatchFuncWithContext) while preserving the existing non-context-specific functions for backward compatibility. Both sets of hooks properly applytweakListOptions, and the new functions enable explicit context propagation to the underlying client calls.client/clientset/clientset/typed/hypershift/v1beta1/hypershift_client.go (1)
67-67: LGTM! Correct removal of unnecessary error handling.The removal of error returns from
setConfigDefaultsis appropriate. The function body only performs simple struct field assignments that cannot fail, making the error return unnecessary. This simplifies the code and aligns with Go best practices.Also applies to: 79-79, 102-111
client/clientset/clientset/typed/karpenter/v1beta1/karpenter_client.go (1)
47-47: LGTM! Correct removal of unnecessary error handling.The removal of error returns from
setConfigDefaultsis appropriate. The function body only performs simple struct field assignments that cannot fail, making the error return unnecessary. This simplifies the code and aligns with Go best practices.Also applies to: 59-59, 82-91
client/informers/externalversions/hypershift/v1beta1/certificatesigningrequestapproval.go (1)
64-83: LGTM! Context-aware informer hooks properly implemented.The generated code correctly:
- Replaces
context.TODO()withcontext.Background()for the legacy ListFunc/WatchFunc- Adds new context-aware variants (
ListWithContextFunc,WatchFuncWithContext) that accept and propagate context- Maintains backward compatibility while enabling proper context propagation
client/informers/externalversions/certificates/v1alpha1/certificaterevocationrequest.go (1)
64-83: LGTM! Context propagation correctly implemented.The generated informer follows the same correct pattern as other informers in this PR, properly adding context-aware variants while maintaining backward compatibility.
client/informers/externalversions/certificates/v1alpha1/certificatesigningrequestapproval.go (1)
64-83: LGTM! Consistent context-aware implementation.The changes are consistent with the other informers in this PR and correctly implement context propagation.
client/informers/externalversions/scheduling/v1alpha1/clustersizingconfiguration.go (2)
63-69: LGTM: Appropriate context usage for non-context-aware variants.The switch from
context.TODO()tocontext.Background()is appropriate now that context-aware variants (ListWithContextFuncandWatchFuncWithContext) have been added. Usingcontext.Background()signals these are the intended default root contexts rather than placeholders.
71-82: LGTM: Context-aware hooks properly implemented.The addition of
ListWithContextFuncandWatchFuncWithContextfollows Kubernetes best practices for context propagation. Both hooks correctly:
- Accept and propagate the context to client methods
- Preserve the
tweakListOptionsbehavior- Mirror the logic of their non-context-aware counterparts
This enables callers to provide custom contexts for cancellation, deadlines, and context values while maintaining backward compatibility through the existing non-context-aware hooks.
client/informers/externalversions/hypershift/v1beta1/hostedcontrolplane.go (1)
60-83: LGTM! Context handling follows Kubernetes client-go patterns.The changes correctly:
- Use
context.Background()for default contexts inListFuncandWatchFunc- Add context-aware variants (
ListWithContextFuncandWatchFuncWithContext) that allow callers to propagate their own context for cancellation, deadlines, and tracing- Preserve
tweakListOptionsbehavior across all variantsSince this is generated code (informer-gen), these changes reflect the updated code generator patterns from the tooling upgrade.
client/clientset/clientset/typed/certificates/v1alpha1/certificates_client.go (1)
52-52: LGTM: Appropriate removal of unnecessary error handling.The removal of error handling from
setConfigDefaultsis correct. The function only sets configuration defaults (GroupVersion, APIPath, NegotiatedSerializer, UserAgent) and performs no operations that can fail. This simplification likely resulted from golangci-lint v2's stricter analysis detecting the unreachable error path.Since this is generated code, the change reflects an update to the code generator templates, ensuring consistency across all generated clientsets.
Also applies to: 64-64, 87-87
cblecker
force-pushed
the
build/upgrade-golangci-lint-v2
branch
2 times, most recently
from
5209d0c to
f79b236
Compare
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
openshift-merge-robot
added
the
needs-rebase
cblecker
force-pushed
the
build/upgrade-golangci-lint-v2
branch
from
f79b236 to
0ba4726
Compare
openshift-merge-robot
removed
the
needs-rebase
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
hack/tools/go.mod (1)
1-3: Critical blocker: TypeCheck failures remain unresolved—MockdbusConn mock is not defined or generated.The test file
sync-global-pullsecret/sync-global-pullsecret_test.goreferencesMockdbusConnextensively (9 instances), but the mock type is undefined. Nogo:generatedirective exists to generate it, and no mock file exists in the directory. Althoughgo.uber.org/mock v0.5.1is available inhack/tools/go.mod, the test lacks the configuration to generate or provide this mock.This prevents the typecheck phase from passing with golangci-lint v2, blocking
go test ./....Add a
go:generatedirective to the test file usinggo.uber.org/mockor provide a concrete mock implementation to resolve this.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
⛔ Files ignored due to path filters (272)
hack/tools/go.sumis excluded by!**/*.sumhack/tools/vendor/cel.dev/expr/.bazelversionis excluded by!**/vendor/**hack/tools/vendor/cel.dev/expr/MODULE.bazelis excluded by!**/vendor/**hack/tools/vendor/cel.dev/expr/README.mdis excluded by!**/vendor/**hack/tools/vendor/cel.dev/expr/cloudbuild.yamlis excluded by!**/vendor/**hack/tools/vendor/cel.dev/expr/eval.pb.gois excluded by!**/*.pb.go,!**/vendor/**hack/tools/vendor/codeberg.org/chavacava/garif/.gitignoreis excluded by!**/vendor/**hack/tools/vendor/codeberg.org/chavacava/garif/LICENSEis excluded by!**/vendor/**hack/tools/vendor/codeberg.org/chavacava/garif/README.mdis excluded by!**/vendor/**hack/tools/vendor/codeberg.org/chavacava/garif/constructors.gois excluded by!**/vendor/**hack/tools/vendor/codeberg.org/chavacava/garif/decorators.gois excluded by!**/vendor/**hack/tools/vendor/codeberg.org/chavacava/garif/doc.gois excluded by!**/vendor/**hack/tools/vendor/codeberg.org/chavacava/garif/enums.gois excluded by!**/vendor/**hack/tools/vendor/codeberg.org/chavacava/garif/io.gois excluded by!**/vendor/**hack/tools/vendor/codeberg.org/chavacava/garif/models.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/exhaustruct/v4/LICENSEis excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/exhaustruct/v4/analyzer/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/exhaustruct/v4/analyzer/config.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/exhaustruct/v4/internal/comment/cache.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/exhaustruct/v4/internal/comment/directive.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/exhaustruct/v4/internal/pattern/list.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/exhaustruct/v4/internal/structure/fields-cache.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/exhaustruct/v4/internal/structure/fields.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/golib/LICENSEis excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/golib/e/doc.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/golib/e/err.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/golib/e/log.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/golib/fields/dict.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/golib/fields/doc.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/golib/fields/field.gois excluded by!**/vendor/**hack/tools/vendor/dev.gaijin.team/go/golib/fields/list.gois excluded by!**/vendor/**hack/tools/vendor/github.com/4meepo/tagalign/tagalign.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Abirdcfly/dupword/README.mdis excluded by!**/vendor/**hack/tools/vendor/github.com/Abirdcfly/dupword/dupword.gois excluded by!**/vendor/**hack/tools/vendor/github.com/AdminBenni/iota-mixing/LICENSEis excluded by!**/vendor/**hack/tools/vendor/github.com/AdminBenni/iota-mixing/pkg/analyzer/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/AdminBenni/iota-mixing/pkg/analyzer/flags/flags.gois excluded by!**/vendor/**hack/tools/vendor/github.com/AlwxSin/noinlineerr/.gitignoreis excluded by!**/vendor/**hack/tools/vendor/github.com/AlwxSin/noinlineerr/.golangci.ymlis excluded by!**/vendor/**hack/tools/vendor/github.com/AlwxSin/noinlineerr/.goreleaser.ymlis excluded by!**/vendor/**hack/tools/vendor/github.com/AlwxSin/noinlineerr/LICENSEis excluded by!**/vendor/**hack/tools/vendor/github.com/AlwxSin/noinlineerr/README.mdis excluded by!**/vendor/**hack/tools/vendor/github.com/AlwxSin/noinlineerr/noinlineerr.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/errname/pkg/analyzer/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/nilnil/pkg/analyzer/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/analyzer/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/analyzer/checkers_factory.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/bool_compare.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/call_meta.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/checker.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/checkers_registry.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/empty.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/equal_values.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/error_is_as.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/error_nil.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/expected_actual.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/formatter.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/go_require.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_basic_type.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_bool.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_comparison.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_context.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_diagnostic.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_http.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_len.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/len.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/negative_positive.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/require_error.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/suite_method_signature.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/suite_thelper.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/checkers/useless_assert.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Antonboom/testifylint/internal/config/config.gois excluded by!**/vendor/**hack/tools/vendor/github.com/BurntSushi/toml/README.mdis excluded by!**/vendor/**hack/tools/vendor/github.com/BurntSushi/toml/decode.gois excluded by!**/vendor/**hack/tools/vendor/github.com/BurntSushi/toml/encode.gois excluded by!**/vendor/**hack/tools/vendor/github.com/BurntSushi/toml/error.gois excluded by!**/vendor/**hack/tools/vendor/github.com/BurntSushi/toml/lex.gois excluded by!**/vendor/**hack/tools/vendor/github.com/BurntSushi/toml/meta.gois excluded by!**/vendor/**hack/tools/vendor/github.com/BurntSushi/toml/parse.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Crocmagnon/fatcontext/pkg/analyzer/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Djarvur/go-err113/.travis.ymlis excluded by!**/vendor/**hack/tools/vendor/github.com/Djarvur/go-err113/comparison.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Djarvur/go-err113/err113.gois excluded by!**/vendor/**hack/tools/vendor/github.com/GaijinEntertainment/go-exhaustruct/v3/analyzer/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/GaijinEntertainment/go-exhaustruct/v3/internal/pattern/list.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/.custom-gcl.ymlis excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/.gitignoreis excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/.golangci.yamlis excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/Makefileis excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/README.mdis excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/cmd/kal/main.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/commentstart/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/commentstart/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/commentstart/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/conditions/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/conditions/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/conditions/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/helpers/extractjsontags/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/helpers/extractjsontags/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/helpers/inspector/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/helpers/inspector/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/helpers/inspector/inspector.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/helpers/markers/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/helpers/markers/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/helpers/markers/registry.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/integers/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/integers/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/integers/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/jsontags/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/jsontags/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/jsontags/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/maxlength/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/maxlength/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/maxlength/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/nobools/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/nobools/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/nobools/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/nofloats/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/nofloats/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/nofloats/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/nophase/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/nophase/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/nophase/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/optionalorrequired/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/optionalorrequired/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/optionalorrequired/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/registry.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/requiredfields/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/requiredfields/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/requiredfields/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/statussubresource/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/statussubresource/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/statussubresource/initializer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/analysis/utils/type_check.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/config/config.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/config/linters.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/config/linters_config.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/validation/config.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/validation/linters.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/pkg/validation/linters_config.gois excluded by!**/vendor/**hack/tools/vendor/github.com/JoelSpeed/kal/plugin.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Masterminds/semver/v3/CHANGELOG.mdis excluded by!**/vendor/**hack/tools/vendor/github.com/Masterminds/semver/v3/README.mdis excluded by!**/vendor/**hack/tools/vendor/github.com/Masterminds/semver/v3/constraints.gois excluded by!**/vendor/**hack/tools/vendor/github.com/Masterminds/semver/v3/version.gois excluded by!**/vendor/**hack/tools/vendor/github.com/MirrexOne/unqueryvet/.gitignoreis excluded by!**/vendor/**hack/tools/vendor/github.com/MirrexOne/unqueryvet/LICENSEis excluded by!**/vendor/**hack/tools/vendor/github.com/MirrexOne/unqueryvet/Makefileis excluded by!**/vendor/**hack/tools/vendor/github.com/MirrexOne/unqueryvet/README.mdis excluded by!**/vendor/**hack/tools/vendor/github.com/MirrexOne/unqueryvet/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/MirrexOne/unqueryvet/config.gois excluded by!**/vendor/**hack/tools/vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/analyzer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/MirrexOne/unqueryvet/pkg/config/config.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/.editorconfigis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/.gitignoreis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/.golangci.ymlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/.goreleaser.ymlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/Bitfileis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/COPYINGis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/Dockerfileis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/Makefileis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/README.mdis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/biome.jsonis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/chroma.jpgis excluded by!**/*.jpg,!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/coalesce.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/colour.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/delegate.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/doc.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/emitters.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/formatter.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/formatters/api.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/formatters/html/html.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/formatters/json.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/formatters/svg/font_liberation_mono.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/formatters/svg/svg.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/formatters/tokens.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/formatters/tty_indexed.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/formatters/tty_truecolour.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/iterator.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexer.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/README.mdis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/caddyfile.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/cl.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/dns.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/emacs.gois excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/abap.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/abnf.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/actionscript.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/actionscript_3.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/ada.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/agda.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/al.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/alloy.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/angular2.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/antlr.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/apacheconf.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/apl.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/applescript.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/arangodb_aql.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/arduino.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/armasm.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/atl.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/autohotkey.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/autoit.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/awk.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/ballerina.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bash.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bash_session.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/batchfile.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/beef.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bibtex.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bicep.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/blitzbasic.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bnf.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bqn.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/brainfuck.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/c#.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/c++.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/c.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cap_n_proto.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cassandra_cql.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/ceylon.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cfengine3.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cfstatement.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/chaiscript.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/chapel.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cheetah.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/clojure.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cmake.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cobol.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/coffeescript.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/common_lisp.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/coq.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/core.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/crystal.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/css.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/csv.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cue.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cython.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/d.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/dart.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/dax.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/desktop_entry.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/diff.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/django_jinja.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/dns.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/docker.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/dtd.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/dylan.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/ebnf.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/elixir.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/elm.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/emacslisp.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/erlang.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/factor.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/fennel.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/fish.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/forth.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/fortran.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/fortranfixed.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/fsharp.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/gas.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/gdscript.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/gdscript3.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/gherkin.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/gleam.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/glsl.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/gnuplot.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/go_template.xmlis excluded by!**/vendor/**hack/tools/vendor/github.com/alecthomas/chroma/v2/lexers/embedded/graphql.xmlis excluded by!**/vendor/**
📒 Files selected for processing (9)
.custom-gcl.yml(0 hunks).golangci.yml(1 hunks)Makefile(3 hunks)api/hypershift/v1beta1/doc.go(1 hunks)api/hypershift/v1beta1/groupversion_info.go(0 hunks)control-plane-operator/hostedclusterconfigoperator/controllers/resources/network/reconcile.go(1 hunks)etcd-recovery/etcdrecovery.go(1 hunks)hack/tools/go.mod(5 hunks)hack/tools/tools.go(1 hunks)
💤 Files with no reviewable changes (2)
- api/hypershift/v1beta1/groupversion_info.go
- .custom-gcl.yml
🚧 Files skipped from review as they are similar to previous changes (4)
- api/hypershift/v1beta1/doc.go
- etcd-recovery/etcdrecovery.go
- hack/tools/tools.go
- control-plane-operator/hostedclusterconfigoperator/controllers/resources/network/reconcile.go
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.
Files:
hack/tools/go.modMakefile
🪛 golangci-lint (2.5.0)
hack/tools/go.mod
[error] 228-228: : # github.com/openshift/hypershift/sync-global-pullsecret [github.com/openshift/hypershift/sync-global-pullsecret.test]
sync-global-pullsecret/sync-global-pullsecret_test.go:228:23: undefined: MockdbusConn
sync-global-pullsecret/sync-global-pullsecret_test.go:234:26: undefined: MockdbusConn
sync-global-pullsecret/sync-global-pullsecret_test.go:247:26: undefined: MockdbusConn
sync-global-pullsecret/sync-global-pullsecret_test.go:257:26: undefined: MockdbusConn
sync-global-pullsecret/sync-global-pullsecret_test.go:270:26: undefined: MockdbusConn
sync-global-pullsecret/sync-global-pullsecret_test.go:283:26: undefined: MockdbusConn
sync-global-pullsecret/sync-global-pullsecret_test.go:296:26: undefined: MockdbusConn
sync-global-pullsecret/sync-global-pullsecret_test.go:309:26: undefined: MockdbusConn
sync-global-pullsecret/sync-global-pullsecret_test.go:327:12: undefined: NewMockdbusConn
(typecheck)
🔇 Additional comments (4)
hack/tools/go.mod (2)
5-15: Tooling module structure looks coherent for v2 upgrade.Direct dependencies (golangci-lint/v2, openshift/api/tools, k8s tooling, kube-api-linter) are correctly pinned for the v2 ecosystem. The extensive indirect dependency graph is expected given golangci-lint v2's inclusion of 100+ linters and their transitive dependencies.
325-337: No issues found — version pinning is correct and intentional.Verification confirms the replace block correctly aligns hack/tools dependencies with the main module: k8s modules are pinned to v0.32.3 (matching the main module), despite hack/tools' direct dependency on k8s.io/code-generator v0.33.2 pulling newer transitive versions. The same applies to google/cel-go (pinned to v0.22.1 matching main module). This strategy prevents version drift between linting/code-generation tooling and the main module, which is the intended design.
.golangci.yml (1)
1-91: V2 configuration migration is comprehensive and correctly structured.The config properly migrates from v1 to v2 format: version field set to "2", new misspell.ignore-rules (replacing old ignore-words), comprehensive exclusions block using v2 presets (comments, common-false-positives, legacy, std-error-handling), explicit SA/ST/QF rules for known false-positives, path-based exclusions, and formatters block with gci configuration. Locale set to US aligns with OpenShift conventions.
Makefile (1)
184-186: API code generation context switch is correct.The CODE_GEN invocations are intentionally wrapped with
(cd ./api && ...)to execute from the api/ subdirectory context. This aligns with the api/ submodule structure and ensures relative paths resolve correctly for manifest generation and schema patching.
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
Member
Author
|
/retest |
bryan-cox
reviewed
Nov 26, 2025
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, cblecker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Member
Author
|
/verified by ci @cblecker |
openshift-ci-robot
added
the
verified
|
@cblecker: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-robot
added
the
needs-rebase
cblecker
force-pushed
the
build/upgrade-golangci-lint-v2
branch
from
3095442 to
d9cff6f
Compare
openshift-ci-robot
removed
the
verified
openshift-merge-robot
removed
the
needs-rebase
Upgrade golangci-lint from v1.64.8 to v2.6.2, a major version upgrade requiring module path changes and configuration format updates. Changes: - Updated hack/tools/go.mod with golangci-lint v2.6.2 and new module path - Updated hack/tools/tools.go to use v2 import path - Updated Makefile to build kube-api-linter as Go plugin (.so) - Migrated .golangci.yml configs to v2 format (version field, formatters section) - Fixed kube-api-linter plugin config location for v2 (moved to linters.settings) - Updated kube-api-linter to commit d94382a24f06 - Updated dependencies: github.com/openshift/api/tools, k8s.io packages to v0.34.1 Signed-off-by: Christoph Blecker <[email protected]> Assisted-by: Claude Sonnet 4.5 (via Claude Code)
Update hack/tools/vendor directory to sync with golangci-lint v2.6.2 and updated dependencies from the previous commit. This includes vendor updates for: - golangci-lint v2 module path changes - kube-api-linter plugin dependencies - Updated transitive dependencies from github.com/openshift/api/tools Signed-off-by: Christoph Blecker <[email protected]> Assisted-by: Claude Sonnet 4.5 (via Claude Code)
Remove obsolete deprecation exclusions that no longer match any issues. Fix tuningConfigKey exclusion to match v2's error format (removed backticks). Add exclusions for intentional test patterns: ST1001 for gomega dot imports and ST1019 for dual import usage. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Consolidate duplicate imports to use only aliased forms (hyperutil, crclient) and remove corresponding ST1019 linting exceptions. The duplicate imports were unnecessary convenience shortcuts that violated code consistency. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
QF1008 suggests removing embedded field names from selectors. While this is idiomatic Go, there are 40+ instances throughout the codebase. Adding an exception for now to unblock the golangci-lint v2 upgrade. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Replace inefficient WriteString(fmt.Sprintf(...)) and Write([]byte(fmt.Sprintf(...))) patterns with fmt.Fprintf(...). This eliminates intermediate string/byte slice allocations and reduces GC pressure. Fixes QF1012 staticcheck warnings. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
QF1007 (merge conditional assignment) and QF1001 (De Morgan's law) suggest mathematically equivalent but less readable code patterns. Exception-based logic like \!(A || B) is clearer than \!A && \!B for human readers. Explicit false-then-true pattern makes boolean flag intent more obvious. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Converts if-else chains to tagged switch statements per QF1002/QF1003 linting suggestions. Switch statements are more idiomatic when branching on a single variable, making the code easier to read and extend. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Fixes ST1005 (error string capitalization) and ST1019 (duplicate imports) errors. Removes duplicate IBM Cloud import, and corrects error message formatting. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Removes duplicate import of controller-runtime/pkg/client and consolidates to use crclient alias consistently. Changes all client.ObjectKeyFromObject references to crclient.ObjectKeyFromObject. Similar to earlier consolidation in commit 8bbcf27. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Remove obsolete staticcheck and unused linter exceptions in api/. Update Subnet/VPC exception text to match current linter output. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Remove 4 linter exceptions that are no longer needed: - Provisioner field (hostedcluster_types.go) - RootVolume field (kubevirt.go) - Conditions field (nodepool_types.go) - History field (hostedcluster_types.go) These exceptions were skipping 0 issues, indicating the underlying problems were already fixed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Add 486 linting exceptions grouped by 14 error types to allow the kubeapilinter to pass after upgrading golangci-lint to v2. These exceptions are marked with TODO comments for future review and resolution. Each exception matches the first sentence of the linter error message to avoid matching on variable examples. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The upgrade of github.com/openshift/api/tools introduced gengo v2, which requires running from the correct Go module context. The api/ directory has its own go.mod, but the codegen tools were being invoked from the parent module context, causing package discovery to fail. Changes: - Run codegen commands from api/ directory using subshells in Makefile - Add +openshift:featuregated-schema-gen=true marker to enable OpenShift CRD generation - Remove duplicate package markers from groupversion_info.go This restores API generation functionality that was broken by the tools upgrade. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
cblecker
force-pushed
the
build/upgrade-golangci-lint-v2
branch
from
d9cff6f to
b81bb6d
Compare
Member
Author
|
/retest |
Contributor
|
@cblecker: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Member
|
/test e2e-aks-4-20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades golangci-lint from v1 to v2.6.2, bringing improved linting capabilities and updated rule sets. This upgrade required updates to configuration files, vendored dependencies, and code changes to address new linting rules.
Changes
Commit Structure
This PR contains 15 smaller commits to aid review. Each commit addresses a specific aspect of the upgrade, making it easier to understand the progression and verify individual changes.
Testing