OCPBUGS-24049: Add option to enable/disable tailing to Pod log viewer mobile screen issues #13394

cajieh · 2023-12-01T13:39:01Z

Follow on changes for PR

Before:

After:

openshift-ci-robot · 2023-12-01T17:36:22Z

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-24049, which is invalid:

expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cajieh · 2023-12-01T17:37:43Z

/jira refresh

cajieh · 2023-12-03T19:12:10Z

/retest

cajieh · 2023-12-05T20:13:19Z

/retest

cajieh · 2023-12-06T01:31:26Z

/retest

cajieh · 2023-12-06T20:29:33Z

/retest

cajieh · 2023-12-07T13:41:02Z

/jira refresh

openshift-ci-robot · 2023-12-07T13:41:05Z

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-24049, which is invalid:

expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cajieh · 2023-12-07T13:46:39Z

/jira refresh

openshift-ci-robot · 2023-12-07T13:46:46Z

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-24049, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto · 2023-12-07T20:20:07Z

I didn't review the code yet as I noticed a few concerns with the functionality:

There is an issue with links in the mobile dropdown where clicking the menu item instead of the link results in nothing happening. Likely need to convert the links to actions rather than just putting them inside a menu item.

Screen.Recording.2023-12-07.at.3.14.26.PM.mov

Seems like the layout could be better here. Since the right items are collapsing to a kebab, there is still plenty of room for the other items. @sg00dwin, do you have time to help @cyril-ui-developer with optimizing the layout?

cajieh · 2023-12-07T21:24:37Z

I didn't review the code yet as I noticed a few concerns with the functionality:

There is an issue with links in the mobile dropdown where clicking the menu item instead of the link results in nothing happening. Likely need to convert the links to actions rather than just putting them inside a menu item.

Screen.Recording.2023-12-07.at.3.14.26.PM.mov
Seems like the layout could be better here. Since the right items are collapsing to a kebab, there is still plenty of room for the other items. @sg00dwin, do you have time to help @cyril-ui-developer with optimizing the layout?

@rhamilto I would have to add a click event to handle that for Download, Raw and Expand. If click event is added for full length of dropdown item, then removing the underline would be idea for Download and Raw. WDYT?

rhamilto · 2023-12-07T21:31:57Z

@rhamilto I would have to add a click event to handle that for Download, Raw and Expand. If click event is added for full length of dropdown item, then removing the underline would be idea for Download and Raw. WDYT?

My assumption is the links would get removed entirely, which would remove the blue and the underline from the text. Is that what you mean?

cajieh · 2023-12-08T11:25:04Z

I didn't review the code yet as I noticed a few concerns with the functionality:

There is an issue with links in the mobile dropdown where clicking the menu item instead of the link results in nothing happening. Likely need to convert the links to actions rather than just putting them inside a menu item.

Screen.Recording.2023-12-07.at.3.14.26.PM.mov
Seems like the layout could be better here. Since the right items are collapsing to a kebab, there is still plenty of room for the other items. @sg00dwin, do you have time to help @cyril-ui-developer with optimizing the layout?

@rhamilto The UX design layout mobile screen in that order. Please double check the story

openshift-ci-robot · 2023-12-15T19:52:31Z

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-24049, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto · 2023-12-18T12:27:40Z

frontend/public/components/utils/resource-log.tsx

Suggested change

<DropdownItem to={currentLogURL} isExternalLink>

<DropdownItem to={currentLogURL} download={`${resource.metadata.name}-${containerName}.log`>

Plus a forthcoming version of @patternfly/react-core that includes patternfly/patternfly-react#9892

cajieh · 2024-03-19T02:32:25Z

/retest

cajieh · 2024-03-19T11:31:50Z

/retest

cajieh · 2024-03-19T16:40:39Z

/retest

cajieh · 2024-03-19T23:47:29Z

/retest

cajieh · 2024-03-20T12:54:13Z

/assign @rhamilto

rhamilto

/lgtm

openshift-ci · 2024-03-20T14:01:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cajieh · 2024-03-20T14:02:14Z

/label acknowledge-critical-fixes-only

cajieh · 2024-03-20T14:58:50Z

/retest

cajieh · 2024-03-20T19:00:07Z

/retest

openshift-ci · 2024-03-20T23:23:00Z

@cyril-ui-developer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-03-20T23:25:33Z

@cyril-ui-developer: Jira Issue OCPBUGS-24049: All pull requests linked via external trackers have merged:

openshift/console#13394

Jira Issue OCPBUGS-24049 has been moved to the MODIFIED state.

In response to this:

Follow on changes for PR

Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-03-21T06:56:21Z

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.16.0-202403210141.p0.g16a13e5.assembly.stream.el8 for distgit openshift-enterprise-console.
All builds following this will include this PR.

openshift-merge-robot · 2024-03-21T20:45:44Z

Fix included in accepted release 4.16.0-0.nightly-2024-03-21-152650

openshift-ci bot requested review from spadgett and zherman0 December 1, 2023 13:39

openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Dec 1, 2023

cajieh changed the title ~~Add show fulllog chkbx to log viewer mobile screen~~ OCPBUGS-24049: Add option to enable/disable tailing to Pod log viewer mobile screen issues Dec 1, 2023

cajieh force-pushed the add-show-full-log-chkbx-log-viewers-mobile-screen branch 3 times, most recently from ea2f5dd to 74b5581 Compare December 5, 2023 15:47

cajieh force-pushed the add-show-full-log-chkbx-log-viewers-mobile-screen branch from 74b5581 to e7dc5ab Compare December 6, 2023 16:59

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 7, 2023

openshift-ci bot requested a review from yapei December 7, 2023 13:46

cajieh force-pushed the add-show-full-log-chkbx-log-viewers-mobile-screen branch from e7dc5ab to cd9d08d Compare December 8, 2023 12:22

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 15, 2023

rhamilto reviewed Dec 18, 2023

View reviewed changes

cajieh force-pushed the add-show-full-log-chkbx-log-viewers-mobile-screen branch from 9f1e0f3 to bf4499b Compare December 22, 2023 16:11

cajieh force-pushed the add-show-full-log-chkbx-log-viewers-mobile-screen branch from bf4499b to cc20bd3 Compare January 12, 2024 19:54

cajieh force-pushed the add-show-full-log-chkbx-log-viewers-mobile-screen branch 4 times, most recently from 9d59e98 to b5d17da Compare March 18, 2024 21:41

add show fulllog chkbx to log viewer mobile screen

ed49fb4

cajieh force-pushed the add-show-full-log-chkbx-log-viewers-mobile-screen branch from b5d17da to ed49fb4 Compare March 20, 2024 12:45

openshift-ci bot assigned rhamilto Mar 20, 2024

rhamilto approved these changes Mar 20, 2024

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2024

openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 20, 2024

openshift-merge-bot bot merged commit 16a13e5 into openshift:master Mar 20, 2024

	<DropdownItem to={currentLogURL} isExternalLink>
	<DropdownItem to={currentLogURL} download={`${resource.metadata.name}-${containerName}.log`>

OCPBUGS-24049: Add option to enable/disable tailing to Pod log viewer mobile screen issues #13394

OCPBUGS-24049: Add option to enable/disable tailing to Pod log viewer mobile screen issues #13394

Uh oh!

Conversation

cajieh commented Dec 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before:

After:

Uh oh!

openshift-ci-robot commented Dec 1, 2023

Uh oh!

cajieh commented Dec 1, 2023

Uh oh!

cajieh commented Dec 3, 2023

Uh oh!

cajieh commented Dec 5, 2023

Uh oh!

cajieh commented Dec 6, 2023

Uh oh!

cajieh commented Dec 6, 2023

Uh oh!

cajieh commented Dec 7, 2023

Uh oh!

openshift-ci-robot commented Dec 7, 2023

Uh oh!

cajieh commented Dec 7, 2023

Uh oh!

openshift-ci-robot commented Dec 7, 2023

Uh oh!

rhamilto commented Dec 7, 2023

Uh oh!

cajieh commented Dec 7, 2023

Uh oh!

rhamilto commented Dec 7, 2023

Uh oh!

cajieh commented Dec 8, 2023

Uh oh!

openshift-ci-robot commented Dec 15, 2023

Uh oh!

rhamilto Dec 18, 2023

Choose a reason for hiding this comment

Uh oh!

cajieh commented Mar 19, 2024

Uh oh!

cajieh commented Mar 19, 2024

Uh oh!

cajieh commented Mar 19, 2024

Uh oh!

cajieh commented Mar 19, 2024

Uh oh!

cajieh commented Mar 20, 2024

Uh oh!

rhamilto left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Mar 20, 2024

Uh oh!

cajieh commented Mar 20, 2024

Uh oh!

cajieh commented Mar 20, 2024

Uh oh!

cajieh commented Mar 20, 2024

Uh oh!

openshift-ci bot commented Mar 20, 2024

Uh oh!

openshift-ci-robot commented Mar 20, 2024

Before:

After:

Uh oh!

openshift-bot commented Mar 21, 2024

Uh oh!

openshift-merge-robot commented Mar 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

cajieh commented Dec 1, 2023 •

edited

Loading