CONSOLE-3732: Add option to enable/disable tailing to Pod log viewer #13298

cajieh · 2023-10-31T20:57:13Z

Before:

After:

openshift-ci-robot · 2023-10-31T20:57:16Z

@cyril-ui-developer: This pull request references CONSOLE-3732 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cajieh · 2023-10-31T21:01:32Z

frontend/public/components/utils/resource-log.tsx

TODO: Remove multicluster changes

openshift-ci-robot · 2023-11-03T19:38:09Z

@cyril-ui-developer: This pull request references CONSOLE-3732 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-11-03T19:38:52Z

@cyril-ui-developer: This pull request references CONSOLE-3732 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-11-03T19:39:49Z

@cyril-ui-developer: This pull request references CONSOLE-3732 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-11-03T21:39:49Z

@cyril-ui-developer: This pull request references CONSOLE-3732 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Before:

After:

Cypress screenshot:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-11-08T21:37:51Z

@cyril-ui-developer: This pull request references CONSOLE-3732 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Before:

After:

Mobile view:

Cypress screenshot:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-11-08T21:38:49Z

@cyril-ui-developer: This pull request references CONSOLE-3732 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Before:

After:

Mobile view:

Cypress screenshot:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cajieh · 2023-11-10T19:57:24Z

/retest

frontend/public/components/utils/resource-log.tsx

rhamilto · 2023-11-29T20:30:43Z

frontend/packages/integration-tests-cypress/tests/app/resource-log.cy.ts

I'd add a cy.wait(5000); above here because the log doesn't load instantaneously.

frontend/packages/integration-tests-cypress/tests/app/resource-log.cy.ts

rhamilto

/lgtm

openshift-ci · 2023-11-29T20:42:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cajieh · 2023-11-29T20:52:35Z

@yapei @yanpzhan This feature is ready for verification.

jcaianirh · 2023-11-29T21:28:15Z

/hold cancel

openshift-ci-robot · 2023-11-30T00:23:23Z

@cyril-ui-developer: This pull request references CONSOLE-3732 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Before:

After:

Cypress screenshot:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-11-30T00:23:56Z

@cyril-ui-developer: This pull request references CONSOLE-3732 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto · 2023-11-30T00:26:37Z

@yapei @yanpzhan This feature is ready for verification.

Note the decision was made to defer the mobile view implementation as there were a number of bugs with the mobile view that could not be resolved in a timely manner. We intend to add the mobile view as a follow on.

openshift-ci · 2023-11-30T00:41:14Z

@cyril-ui-developer: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

yanpzhan · 2023-11-30T10:25:00Z

Tested on cluster launched against the pr. The feature works as expected.
/label qe-approved
@cyril-ui-developer I see the new added strings are marked for i18n, do you think when its translations for different languages(eg, Chinese/Japanese/Korean) will be added?

openshift-ci-robot · 2023-11-30T10:25:10Z

@cyril-ui-developer: This pull request references CONSOLE-3732 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cajieh · 2023-11-30T11:43:44Z

Tested on cluster launched against the pr. The feature works as expected. /label qe-approved @cyril-ui-developer I see the new added strings are marked for i18n, do you think when its translations for different languages(eg, Chinese/Japanese/Korean) will be added?

We can only upload the translations after merging this changes. So they would available soon after then.

jhadvig · 2023-11-30T11:46:54Z

Docs Approver:
/assign @opayne1
PX Approver:
/assign @RickJWagner

opayne1 · 2023-11-30T12:04:07Z

/label docs-approved

RickJWagner · 2023-11-30T13:18:44Z

/label px-approved

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 31, 2023

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2023

openshift-ci bot requested review from andrewballantyne and zherman0 October 31, 2023 20:58

openshift-ci bot added component/core Related to console core functionality component/pipelines Related to pipelines-plugin component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Oct 31, 2023

cajieh commented Oct 31, 2023

View reviewed changes

frontend/public/components/utils/resource-log.tsx Outdated

Copy link

Contributor Author

cajieh Oct 31, 2023 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Remove multicluster changes

cajieh force-pushed the add-show-full-log-chkbx-log-viewers branch 6 times, most recently from 7b3cd5a to 4583de5 Compare November 2, 2023 23:36

cajieh changed the title ~~[WIP]CONSOLE-3732: Add option to enable/disable tailing to log viewer~~ [WIP]CONSOLE-3732: Add option to enable/disable tailing to Pod log viewer Nov 3, 2023

cajieh force-pushed the add-show-full-log-chkbx-log-viewers branch from 4583de5 to c73d46d Compare November 3, 2023 21:45

openshift-ci bot added the kind/cypress Related to Cypress e2e integration testing label Nov 3, 2023

cajieh force-pushed the add-show-full-log-chkbx-log-viewers branch from c73d46d to 2b4907d Compare November 8, 2023 21:35

cajieh changed the title ~~[WIP]CONSOLE-3732: Add option to enable/disable tailing to Pod log viewer~~ CONSOLE-3732: Add option to enable/disable tailing to Pod log viewer Nov 8, 2023

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2023

cajieh force-pushed the add-show-full-log-chkbx-log-viewers branch from 2b4907d to 8252085 Compare November 8, 2023 23:58

cajieh force-pushed the add-show-full-log-chkbx-log-viewers branch from 86758b1 to 9e539e2 Compare November 29, 2023 19:47

rhamilto reviewed Nov 29, 2023

View reviewed changes

frontend/public/components/utils/resource-log.tsx Outdated Show resolved Hide resolved

cajieh force-pushed the add-show-full-log-chkbx-log-viewers branch 2 times, most recently from 2d85301 to 9646672 Compare November 29, 2023 20:27

rhamilto reviewed Nov 29, 2023

View reviewed changes

cajieh force-pushed the add-show-full-log-chkbx-log-viewers branch from 9646672 to ae0e12c Compare November 29, 2023 20:34

rhamilto reviewed Nov 29, 2023

View reviewed changes

frontend/packages/integration-tests-cypress/tests/app/resource-log.cy.ts Outdated Show resolved Hide resolved

Add option to enable/disable tailing to log viewer

98ae227

cajieh force-pushed the add-show-full-log-chkbx-log-viewers branch from ae0e12c to 98ae227 Compare November 29, 2023 20:38

rhamilto approved these changes Nov 29, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2023

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 30, 2023

openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Nov 30, 2023

openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Nov 30, 2023

openshift-merge-bot bot merged commit 50a36dc into openshift:master Nov 30, 2023

cajieh mentioned this pull request Dec 7, 2023

OCPBUGS-24049: Add option to enable/disable tailing to Pod log viewer mobile screen issues #13394

Merged

CONSOLE-3732: Add option to enable/disable tailing to Pod log viewer #13298

CONSOLE-3732: Add option to enable/disable tailing to Pod log viewer #13298

Uh oh!

Conversation

cajieh commented Oct 31, 2023 • edited by rhamilto Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before:

After:

Uh oh!

openshift-ci-robot commented Oct 31, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cajieh Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Nov 3, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before:

After:

Uh oh!

openshift-ci-robot commented Nov 3, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before:

After:

Uh oh!

openshift-ci-robot commented Nov 3, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before:

After:

Uh oh!

openshift-ci-robot commented Nov 3, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before:

After:

Cypress screenshot:

Uh oh!

openshift-ci-robot commented Nov 8, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before:

After:

Mobile view:

Cypress screenshot:

Uh oh!

openshift-ci-robot commented Nov 8, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before:

After:

Mobile view:

Cypress screenshot:

Uh oh!

cajieh commented Nov 10, 2023

Uh oh!

Uh oh!

rhamilto Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rhamilto left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 29, 2023

Uh oh!

cajieh commented Nov 29, 2023

Uh oh!

jcaianirh commented Nov 29, 2023

Uh oh!

openshift-ci-robot commented Nov 30, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before:

After:

Cypress screenshot:

Uh oh!

openshift-ci-robot commented Nov 30, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before:

After:

Uh oh!

rhamilto commented Nov 30, 2023

cajieh commented Oct 31, 2023 •

edited by rhamilto

Loading

openshift-ci-robot commented Oct 31, 2023 •

edited by openshift-ci bot

Loading

cajieh Oct 31, 2023 •

edited

Loading

openshift-ci-robot commented Nov 3, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 3, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 3, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 3, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 8, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 8, 2023 •

edited by openshift-ci bot

Loading

rhamilto Nov 29, 2023 •

edited

Loading

openshift-ci-robot commented Nov 30, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 30, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 30, 2023 •

edited by openshift-ci bot

Loading