-
Notifications
You must be signed in to change notification settings - Fork 211
OCPBUGS-63001: Add ClusterVersionOperator manifests to TechPreviewNoUpgrade clusters in 4.20 #1247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(cherry picked from commit 854cf2c)
This is needed as the CRDs of the ClusterVersionOperator objects are being imported from the github.com/openshift/api module. To bring a new TechPreview CRD of the ClusterVersionOperator object, the module must be upgraded. Steps: ```console $ go get github.com/openshift/api $ go mod tidy $ go mod vendor ``` (cherry picked from commit 9a82fb3)
(cherry picked from commit 12d7960)
|
/jira cherrypick OCPBUGS-61872 |
|
@DavidHurta: Jira Issue OCPBUGS-61872 has been cloned as Jira Issue OCPBUGS-63001. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@DavidHurta: This pull request references Jira Issue OCPBUGS-63001, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
I am cherry-picking the commits from No other changes regarding the imported modules were done between the branch cut-off and the cherry-picked commits. Compare release-4.20...main. |
|
The lint job is being addressed in openshift/release#70229. |
|
@DavidHurta: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label qe-approved |
|
/jira refresh |
|
@DavidHurta: This pull request references Jira Issue OCPBUGS-63001, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
wking
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This doesn't need to land in 4.20 for GA, so I'll leave backport-risk-assessed off for now.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DavidHurta, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by @JianLi-RH Verification signaled in this comment, although an older label was used. Evidence of the verification is located in a respective Jira card. |
|
@DavidHurta: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@wking, the 4.20 has GAed and the staff-eng-approved label is no longer required. Are we ready? 👀 |
|
4.20 is GA. /label backport-risk-assessed |
77782f1
into
openshift:release-4.20
|
@DavidHurta: Jira Issue Verification Checks: Jira Issue OCPBUGS-63001 Jira Issue OCPBUGS-63001 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in accepted release 4.20.0-0.nightly-2025-10-25-003142 |
Manual cherry-picking of commits to bring the #1232 into 4.20.
I am cherry-picking the commits from
main.No other changes regarding imported modules were done between the branch cut-off and the cherry-picked commits.
Compare release-4.20...main.
Compare main...release-4.20.
This will make the go.mod and go.sum files in 4.20 to be identical with 4.21 files for the moment.
The 4.21 PR was included in the 4.21.0-0.nightly-2025-10-12-115019 release. Blocking jobs are passing. Relevant informing jobs look good.