Skip to content

Conversation

@DavidHurta
Copy link
Contributor

@DavidHurta DavidHurta commented Sep 19, 2025

Start applying the ClusterVersionOperator manifests in TechPreview.


deps: Bump github.com/openshift/api module
This is needed as the CRDs of the ClusterVersionOperator objects are being imported
from the github.com/openshift/api module. To bring a new TechPreview CRD of the
ClusterVersionOperator object, the module must be upgraded.


install: Add TechPreview ClusterVersionOperator CR manifest

This is needed as the CRDs of the ClusterVersionOperator objects are being imported
from the github.com/openshift/api module. To bring a new TechPreview CRD of the
ClusterVersionOperator object, the module must be upgraded.

Steps:

```console
$ go get github.com/openshift/api
$ go mod tidy
$ go mod vendor
```
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2025
@DavidHurta DavidHurta changed the title WIP: Add ClusterVersionOperator manifests to TechPreviewNoUpgrade clusters OCPBUGS-61872: Add ClusterVersionOperator manifests to TechPreviewNoUpgrade clusters Sep 19, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 19, 2025
@openshift-ci-robot
Copy link
Contributor

@DavidHurta: This pull request references Jira Issue OCPBUGS-61872, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 19, 2025
@DavidHurta
Copy link
Contributor Author

/hold

I need to examine the CI logs.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2025
@DavidHurta
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 19, 2025
@openshift-ci-robot
Copy link
Contributor

@DavidHurta: This pull request references Jira Issue OCPBUGS-61872, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jiajliu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from jiajliu September 19, 2025 13:40
@jiajliu
Copy link

jiajliu commented Sep 22, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jiajliu: This pull request references Jira Issue OCPBUGS-61872, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2025
@DavidHurta
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2025
@DavidHurta
Copy link
Contributor Author

/uncc jiajliu
/cc JianLi-RH

Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

/lgtm

Also Cluster Bot testing with launch 4.21,openshift/cluster-version-operator#1232 aws,techpreview (logs), there's the default cluster resource setting operatorLogLevel: Normal:

$ oc get -o yaml clusterversionoperators.operator.openshift.io cluster
apiVersion: operator.openshift.io/v1alpha1
kind: ClusterVersionOperator
metadata:
  annotations:
    include.release.openshift.io/ibm-cloud-managed: "true"
    include.release.openshift.io/self-managed-high-availability: "true"
    release.openshift.io/create-only: "true"
    release.openshift.io/feature-set: TechPreviewNoUpgrade
  creationTimestamp: "2025-10-05T04:56:00Z"
  generation: 1
  name: cluster
  ownerReferences:
  - apiVersion: config.openshift.io/v1
    kind: ClusterVersion
    name: version
    uid: 04bec884-4d38-4459-918d-b3eb3fecdddf
  resourceVersion: "3275"
  uid: d2bd9f8f-e739-4263-981c-b830e3b3f861
spec:
  operatorLogLevel: Normal
status:
  observedGeneration: 1

And patching to Trace gets logs about the transition and also detailed networking stuff that we don't usually get:

$ oc patch clusterversionoperators.operator.openshift.io cluster --type json -p '[{"op": "add", "path": "/spec/operatorLogLevel", "value": "Trace"}]'
clusterversionoperator.operator.openshift.io/cluster patched
$ oc -n openshift-cluster-version logs -l k8s-app=cluster-version-operator --tail -1 | grep 'configuration.go.*updated'
I1005 05:31:01.460216       1 configuration.go:170] Successfully updated the log level from 'Normal' to 'Trace'
$ oc -n openshift-cluster-version logs -l k8s-app=cluster-version-operator --tail 20
I1005 05:31:15.167757       1 streamwatcher.go:123] "Unable to decode an event from the watch stream" err="read tcp 10.0.13.69:56342->10.0.7.1:6443: read: connection reset by peer"
I1005 05:31:15.167794       1 reflector.go:879] github.com/openshift/client-go/config/informers/externalversions/factory.go:125: Watch close - *v1.FeatureGate total 3 items received
I1005 05:31:15.168062       1 streamwatcher.go:123] "Unable to decode an event from the watch stream" err="read tcp 10.0.13.69:56342->10.0.7.1:6443: read: connection reset by peer"
I1005 05:31:15.168458       1 reflector.go:879] k8s.io/client-go/informers/factory.go:160: Watch close - *v1.ConfigMap total 3 items received
I1005 05:31:15.168069       1 streamwatcher.go:123] "Unable to decode an event from the watch stream" err="read tcp 10.0.13.69:56342->10.0.7.1:6443: read: connection reset by peer"
I1005 05:31:15.168749       1 reflector.go:879] github.com/openshift/client-go/config/informers/externalversions/factory.go:125: Watch close - *v1.ClusterVersion total 4 items received
I1005 05:31:15.168172       1 streamwatcher.go:123] "Unable to decode an event from the watch stream" err="read tcp 10.0.13.69:56342->10.0.7.1:6443: read: connection reset by peer"
I1005 05:31:15.168937       1 reflector.go:879] k8s.io/client-go/informers/factory.go:160: Watch close - *v1.ConfigMap total 3 items received
...

/verified by @wking

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2f5d502 and 2 for PR HEAD 12d7960 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 95685e0 and 1 for PR HEAD 12d7960 in total

@DavidHurta
Copy link
Contributor Author

/retest-required

@JianLi-RH
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 9, 2025
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 9, 2025
@openshift-ci-robot
Copy link
Contributor

@DavidHurta: This pull request references Jira Issue OCPBUGS-61872, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Start applying the ClusterVersionOperator manifests in TechPreview.


deps: Bump github.com/openshift/api module
This is needed as the CRDs of the ClusterVersionOperator objects are being imported
from the github.com/openshift/api module. To bring a new TechPreview CRD of the
ClusterVersionOperator object, the module must be upgraded.


install: Add TechPreview ClusterVersionOperator CR manifest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DavidHurta
Copy link
Contributor Author

/hold let other CVO PRs go first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2025
@DavidHurta
Copy link
Contributor Author

/unhold

The main branch HyperShift PR has merged. Let's merge as well.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2025
@DavidHurta
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 9, 2025
@openshift-ci-robot
Copy link
Contributor

@DavidHurta: This pull request references Jira Issue OCPBUGS-61872, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4b8d15e and 0 for PR HEAD 12d7960 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 12d7960 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2025
@wking
Copy link
Member

wking commented Oct 10, 2025

The HAProxy router should be able to connect to a service that is idled because a GET on the route will unidle it failures are unrelated to this change, and that's the only thing that went wrong in that run.

/hold cancel
/override ci/prow/e2e-aws-ovn-techpreview

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2025

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-aws-ovn-techpreview

In response to this:

The HAProxy router should be able to connect to a service that is idled because a GET on the route will unidle it failures are unrelated to this change, and that's the only thing that went wrong in that run.

/hold cancel
/override ci/prow/e2e-aws-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2025

@DavidHurta: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 75c15b5 into openshift:main Oct 10, 2025
17 checks passed
@openshift-ci-robot
Copy link
Contributor

@DavidHurta: Jira Issue Verification Checks: Jira Issue OCPBUGS-61872
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-61872 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

Start applying the ClusterVersionOperator manifests in TechPreview.


deps: Bump github.com/openshift/api module
This is needed as the CRDs of the ClusterVersionOperator objects are being imported
from the github.com/openshift/api module. To bring a new TechPreview CRD of the
ClusterVersionOperator object, the module must be upgraded.


install: Add TechPreview ClusterVersionOperator CR manifest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.21.0-0.nightly-2025-10-12-115019

@DavidHurta
Copy link
Contributor Author

/cherrypick release-4.20

@openshift-cherrypick-robot

@DavidHurta: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked.

Error messagestatus code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of files (300). Consider using 'List pull requests files' API or locally cloning the repository instead.","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#list-pull-requests-files","status":"406"}

In response to this:

/cherrypick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants