-
Notifications
You must be signed in to change notification settings - Fork 211
OCPBUGS-61872: Add ClusterVersionOperator manifests to TechPreviewNoUpgrade clusters #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-61872: Add ClusterVersionOperator manifests to TechPreviewNoUpgrade clusters #1232
Conversation
This is needed as the CRDs of the ClusterVersionOperator objects are being imported from the github.com/openshift/api module. To bring a new TechPreview CRD of the ClusterVersionOperator object, the module must be upgraded. Steps: ```console $ go get github.com/openshift/api $ go mod tidy $ go mod vendor ```
|
@DavidHurta: This pull request references Jira Issue OCPBUGS-61872, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold I need to examine the CI logs. |
|
/jira refresh |
|
@DavidHurta: This pull request references Jira Issue OCPBUGS-61872, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@jiajliu: This pull request references Jira Issue OCPBUGS-61872, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/unhold |
|
/uncc jiajliu |
wking
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
/lgtm
Also Cluster Bot testing with launch 4.21,openshift/cluster-version-operator#1232 aws,techpreview (logs), there's the default cluster resource setting operatorLogLevel: Normal:
$ oc get -o yaml clusterversionoperators.operator.openshift.io cluster
apiVersion: operator.openshift.io/v1alpha1
kind: ClusterVersionOperator
metadata:
annotations:
include.release.openshift.io/ibm-cloud-managed: "true"
include.release.openshift.io/self-managed-high-availability: "true"
release.openshift.io/create-only: "true"
release.openshift.io/feature-set: TechPreviewNoUpgrade
creationTimestamp: "2025-10-05T04:56:00Z"
generation: 1
name: cluster
ownerReferences:
- apiVersion: config.openshift.io/v1
kind: ClusterVersion
name: version
uid: 04bec884-4d38-4459-918d-b3eb3fecdddf
resourceVersion: "3275"
uid: d2bd9f8f-e739-4263-981c-b830e3b3f861
spec:
operatorLogLevel: Normal
status:
observedGeneration: 1And patching to Trace gets logs about the transition and also detailed networking stuff that we don't usually get:
$ oc patch clusterversionoperators.operator.openshift.io cluster --type json -p '[{"op": "add", "path": "/spec/operatorLogLevel", "value": "Trace"}]'
clusterversionoperator.operator.openshift.io/cluster patched
$ oc -n openshift-cluster-version logs -l k8s-app=cluster-version-operator --tail -1 | grep 'configuration.go.*updated'
I1005 05:31:01.460216 1 configuration.go:170] Successfully updated the log level from 'Normal' to 'Trace'
$ oc -n openshift-cluster-version logs -l k8s-app=cluster-version-operator --tail 20
I1005 05:31:15.167757 1 streamwatcher.go:123] "Unable to decode an event from the watch stream" err="read tcp 10.0.13.69:56342->10.0.7.1:6443: read: connection reset by peer"
I1005 05:31:15.167794 1 reflector.go:879] github.com/openshift/client-go/config/informers/externalversions/factory.go:125: Watch close - *v1.FeatureGate total 3 items received
I1005 05:31:15.168062 1 streamwatcher.go:123] "Unable to decode an event from the watch stream" err="read tcp 10.0.13.69:56342->10.0.7.1:6443: read: connection reset by peer"
I1005 05:31:15.168458 1 reflector.go:879] k8s.io/client-go/informers/factory.go:160: Watch close - *v1.ConfigMap total 3 items received
I1005 05:31:15.168069 1 streamwatcher.go:123] "Unable to decode an event from the watch stream" err="read tcp 10.0.13.69:56342->10.0.7.1:6443: read: connection reset by peer"
I1005 05:31:15.168749 1 reflector.go:879] github.com/openshift/client-go/config/informers/externalversions/factory.go:125: Watch close - *v1.ClusterVersion total 4 items received
I1005 05:31:15.168172 1 streamwatcher.go:123] "Unable to decode an event from the watch stream" err="read tcp 10.0.13.69:56342->10.0.7.1:6443: read: connection reset by peer"
I1005 05:31:15.168937 1 reflector.go:879] k8s.io/client-go/informers/factory.go:160: Watch close - *v1.ConfigMap total 3 items received
.../verified by @wking
|
/retest-required |
|
/label qe-approved |
|
@DavidHurta: This pull request references Jira Issue OCPBUGS-61872, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold let other CVO PRs go first |
|
/unhold The |
|
/jira refresh |
|
@DavidHurta: This pull request references Jira Issue OCPBUGS-61872, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold Revision 12d7960 was retested 3 times: holding |
|
/hold cancel |
|
@wking: Overrode contexts on behalf of wking: ci/prow/e2e-aws-ovn-techpreview In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@DavidHurta: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@DavidHurta: Jira Issue Verification Checks: Jira Issue OCPBUGS-61872 Jira Issue OCPBUGS-61872 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in accepted release 4.21.0-0.nightly-2025-10-12-115019 |
|
/cherrypick release-4.20 |
|
@DavidHurta: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked. Error messagestatus code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of files (300). Consider using 'List pull requests files' API or locally cloning the repository instead.","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#list-pull-requests-files","status":"406"}In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Start applying the
ClusterVersionOperatormanifests in TechPreview.deps: Bump github.com/openshift/api module
This is needed as the CRDs of the ClusterVersionOperator objects are being imported
from the
github.com/openshift/apimodule. To bring a new TechPreview CRD of theClusterVersionOperator object, the module must be upgraded.
install: Add TechPreview ClusterVersionOperator CR manifest