Skip to content

AC-770 Migrating ContactUS package to Kotlin#752

Merged
f4ww4z merged 1 commit intoopenmrs:masterfrom
rishabh-997:AC-770-ContactKotlin
Jun 6, 2020
Merged

AC-770 Migrating ContactUS package to Kotlin#752
f4ww4z merged 1 commit intoopenmrs:masterfrom
rishabh-997:AC-770-ContactKotlin

Conversation

@rishabh-997
Copy link
Collaborator

Description of what I changed

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-770

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@rishabh-997
Copy link
Collaborator Author

This will need one more commit after Contact Screen UI pull request is merged

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2020

Codecov Report

Merging #752 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #752   +/-   ##
=======================================
  Coverage   11.80%   11.80%           
=======================================
  Files         238      238           
  Lines       10650    10645    -5     
  Branches     1028     1028           
=======================================
  Hits         1257     1257           
+ Misses       9311     9306    -5     
  Partials       82       82           
Impacted Files Coverage Δ
.../activities/community/contact/ContactUsActivity.kt 0.00% <0.00%> (ø)
.../activities/community/contact/ContactUsContract.kt 0.00% <0.00%> (ø)
...activities/community/contact/ContactUsPresenter.kt 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80c4367...4237566. Read the comment docs.

@rishabh-997 rishabh-997 force-pushed the AC-770-ContactKotlin branch from 6def741 to e56d91a Compare June 1, 2020 04:40
@rishabh-997 rishabh-997 force-pushed the AC-770-ContactKotlin branch from 1b29e01 to 4237566 Compare June 2, 2020 06:17
Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @rishabh-997

@f4ww4z f4ww4z merged commit 4fa9995 into openmrs:master Jun 6, 2020
@rishabh-997 rishabh-997 deleted the AC-770-ContactKotlin branch June 6, 2020 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants