AC-764 Updated Contact Screen UI#746
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
=======================================
Coverage 11.80% 11.80%
=======================================
Files 238 238
Lines 10647 10647
Branches 1028 1028
=======================================
Hits 1257 1257
Misses 9308 9308
Partials 82 82
Continue to review full report at Codecov.
|
| <string name="open">Open</string> | ||
| <string name="go_to_forum">Forum</string> | ||
| <string name="go_to_irc">IRC</string> | ||
| <string name="open">Go To</string> |
There was a problem hiding this comment.
I feel it should be renamed to "go_to" not "open"
| <string name="go_to_forum">Go To Forum</string> | ||
| <string name="go_to_irc">Go To IRC</string> | ||
| <string name="open">Open</string> | ||
| <string name="go_to_forum">Forum</string> |
There was a problem hiding this comment.
change "go_to_forum" to "forum"
same with irc
|
@rishabh-997 please attach the screenshot for hind translation screen as well. I feel in hindi the text meaning will something different then needed. Also i feel the text message at the bottom is quite long. How about changing it. Like something simple like "We will be happy to help you". What are your views @f4ww4z sir on it. |
@VibhorChinda I agree with this, the more concise the better. Change to "Our team will try our best to help you. Please reach out to us by using the services above."
|
|
done with the changes.... |
|
LGTM 👍 |
rishabh-997
force-pushed
the
AC-764-contactUsUI
branch
from
868e6b5 to
10c9aa7
Compare
|
@rishabh-997 Just need to fix the merge conflict caused by the code formatting of #723 |
rishabh-997
force-pushed
the
AC-764-contactUsUI
branch
from
10c9aa7 to
10c4c02
Compare
f4ww4z
left a comment
f4ww4z
left a comment
There was a problem hiding this comment.
Just took care of a slight merge conflict. LGTM @rishabh-997
4 participants
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-764
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)