AC-700 Refined custom dialog box in add patient activity#731
Merged
f4ww4z merged 3 commits intoopenmrs:masterfrom May 11, 2020
Merged
AC-700 Refined custom dialog box in add patient activity#731f4ww4z merged 3 commits intoopenmrs:masterfrom
f4ww4z merged 3 commits intoopenmrs:masterfrom
Conversation
f4ww4z
requested changes
May 10, 2020
Collaborator
f4ww4z
left a comment
f4ww4z
left a comment
There was a problem hiding this comment.
Thanks @rishabh-997 , see my comments below.
| public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) { | ||
| View view = inflater.inflate(R.layout.dialog_my_custom, container, false); | ||
| RecyclerView recyclerView = view.findViewById(R.id.recyclerView_dialog); | ||
| list.add(new CustomDialogModel("Take a photo", R.drawable.ic_photo_camera)); |
Collaborator
There was a problem hiding this comment.
Put "Take a photo" in a string resource.
| View view = inflater.inflate(R.layout.dialog_my_custom, container, false); | ||
| RecyclerView recyclerView = view.findViewById(R.id.recyclerView_dialog); | ||
| list.add(new CustomDialogModel("Take a photo", R.drawable.ic_photo_camera)); | ||
| list.add(new CustomDialogModel("Choose photo", R.drawable.ic_photo_library)); |
Collaborator
There was a problem hiding this comment.
Put "Choose photo" in a string resource.
| RecyclerView recyclerView = view.findViewById(R.id.recyclerView_dialog); | ||
| list.add(new CustomDialogModel("Take a photo", R.drawable.ic_photo_camera)); | ||
| list.add(new CustomDialogModel("Choose photo", R.drawable.ic_photo_library)); | ||
| if (showRemoveButton) |
Collaborator
There was a problem hiding this comment.
See the OpenMRS Java conventions, if statements should always have curly braces.
| list.add(new CustomDialogModel("Take a photo", R.drawable.ic_photo_camera)); | ||
| list.add(new CustomDialogModel("Choose photo", R.drawable.ic_photo_library)); | ||
| if (showRemoveButton) | ||
| list.add(new CustomDialogModel("Remove photo", R.drawable.ic_photo_delete)); |
Collaborator
There was a problem hiding this comment.
Place "Remove photo" in a string resource.
| android:layout_marginEnd="50dp" | ||
| android:layout_marginRight="50dp" | ||
| android:paddingEnd="15dp" | ||
| android:paddingRight="15dp" |
Collaborator
There was a problem hiding this comment.
Should be even sized, e.g. 16dp
Collaborator
Author
|
Done with the changes @f4ww4z sir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-700
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)