requested changes resolved

Author: rishabh-997

openmrs-client/src/main/java/org/openmrs/mobile/activities/dialog/CameraOrGalleryPickerDialog.java

@@ -49,11 +49,11 @@ public CameraOrGalleryPickerDialog(Boolean showRemoveButton) {
     public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
         View view = inflater.inflate(R.layout.dialog_my_custom, container, false);
         RecyclerView recyclerView = view.findViewById(R.id.recyclerView_dialog);
-        list.add(new CustomDialogModel("Take a photo", R.drawable.ic_photo_camera));
-        list.add(new CustomDialogModel("Choose photo", R.drawable.ic_photo_library));
-        if (showRemoveButton)
-            list.add(new CustomDialogModel("Remove photo", R.drawable.ic_photo_delete));
-
+        list.add(new CustomDialogModel(getString(R.string.dialog_take_photo), R.drawable.ic_photo_camera));
+        list.add(new CustomDialogModel(getString(R.string.dialog_choose_photo), R.drawable.ic_photo_library));
+        if (showRemoveButton) {
+            list.add(new CustomDialogModel(getString(R.string.dialog_remove_photo), R.drawable.ic_photo_delete));
+        }
         CustomDialogAdapter adapter = new CustomDialogAdapter(getActivity(), list);
 
         recyclerView.setLayoutManager(new LinearLayoutManager(getActivity()));
@@ -104,12 +104,7 @@ public void onBindViewHolder(@NonNull CustomDialogAdapter.ViewHolder holder, int
             CustomDialogModel customDialogModel = modelList.get(position);
             holder.textView.setText(customDialogModel.getName());
             holder.imageView.setImageResource(customDialogModel.getId());
-            holder.linearLayout.setOnClickListener(new View.OnClickListener() {
-                @Override
-                public void onClick(View v) {
-                    CameraOrGalleryPickerDialog.this.performActivity(position);
-                }
-            });
+            holder.linearLayout.setOnClickListener(v -> CameraOrGalleryPickerDialog.this.performActivity(position));
         }
 
         @Override

openmrs-client/src/main/res/layout/list_gallery_or_camera_item.xml

@@ -25,8 +25,8 @@
         android:id="@+id/imageView"
         android:layout_width="50dp"
         android:layout_height="50dp"
-        android:paddingLeft="15dp"
-        android:paddingRight="15dp"
+        android:paddingLeft="16dp"
+        android:paddingRight="16dp"
         tools:src="@drawable/ic_photo_camera" />
 
     <TextView
@@ -35,8 +35,8 @@
         android:layout_height="wrap_content"
         android:layout_marginEnd="50dp"
         android:layout_marginRight="50dp"
-        android:paddingEnd="15dp"
-        android:paddingRight="15dp"
+        android:paddingEnd="16dp"
+        android:paddingRight="16dp"
         android:textSize="16sp"
         tools:text="@string/take_a_photo" />
 

openmrs-client/src/main/res/values-hi/strings.xml

@@ -379,4 +379,7 @@
 	<string name="showcase_register_patient">नया मरीज पंजीकृत करने के लिए यहां क्लिक करें</string>
 	<string name="showcase_form_entry">एक मरीज के वाइटल कलेक्ट करने के लिए यहां क्लिक करें</string>
 	<string name="showcase_manage_providers">एक मरीज के लिए पोषणकर्ता का प्रबंधन करने के लिए यहां क्लिक करें</string>
+	<string name="dialog_take_photo">एक तस्वीर लें</string>
+	<string name="dialog_choose_photo">फोटो चुनो</string>
+	<string name="dialog_remove_photo">फोटो निकालें</string>
 </resources>

openmrs-client/src/main/res/values/strings.xml

@@ -388,4 +388,7 @@
 	<string name="showcase_register_patient">Click here to register a new patient</string>
 	<string name="showcase_form_entry">Click here to capture vitals for a patient on a visit</string>
 	<string name="showcase_manage_providers">Click here to manage providers for a patient on a visit</string>
+	<string name="dialog_take_photo">Take a photo</string>
+	<string name="dialog_choose_photo">Choose photo</string>
+	<string name="dialog_remove_photo">Remove photo</string>
 </resources>