AC-638 Adding inputType for capitalising the first letter#643
Merged
f4ww4z merged 1 commit intoopenmrs:masterfrom Dec 27, 2019
Merged
AC-638 Adding inputType for capitalising the first letter#643f4ww4z merged 1 commit intoopenmrs:masterfrom
f4ww4z merged 1 commit intoopenmrs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
======================================
Coverage 14.4% 14.4%
======================================
Files 202 202
Lines 9223 9223
Branches 791 791
======================================
Hits 1329 1329
Misses 7813 7813
Partials 81 81Continue to review full report at Codecov.
|
Contributor
Author
|
@f4ww4z could you please look into this ? :) |
Collaborator
Contributor
Author
My bad,I didn't go through it. I've noted this. Thanks for pointing it out. I've pinged @f4ww4z on the issue page,hopefully he'll assess and make it ready for work. I hope that's okay for once. |
Contributor
Author
rishabh-997
pushed a commit
to rishabh-997/openmrs-contrib-android-client
that referenced
this pull request
Dec 27, 2019
resolved conflicts resolved conflicts with splash screen
rishabh-997
pushed a commit
to rishabh-997/openmrs-contrib-android-client
that referenced
this pull request
Dec 28, 2019
AC-560: Wrap Parent layout to match text size in charts list (openmrs#640) [AC-638] Added inputType for capitalizing the first letter (openmrs#643) added first time intro slides to app completed requested changes added seven intro slides [AC-638] Added inputType for capitalizing the first letter (openmrs#643) resolved conflicts resolved conflicts with splash screen squashing commits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
As some of the important input fields were having just a text input in lowercase, such as 'City','First Name' etc.,an input of capitalising the the first letter needs to be added as these fields are of high priority.
Changed input type from
android:inputType="text"toandroid:inputType="textCapWords"which was missing for some important input fields.Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-638
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)