[AC-636] Add a Splash Screen#638
[AC-636] Add a Splash Screen#638f4ww4z merged 1 commit intoopenmrs:masterfrom ribhavsharma:splash-screen
Conversation
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
==========================================
- Coverage 14.4% 14.37% -0.04%
==========================================
Files 202 203 +1
Lines 9223 9248 +25
Branches 791 791
==========================================
Hits 1329 1329
- Misses 7813 7838 +25
Partials 81 81
Continue to review full report at Codecov.
|
Akayeshmantha
left a comment
Akayeshmantha
left a comment
There was a problem hiding this comment.
LGTM
Please check on the coverage issue as well
| import org.openmrs.mobile.R; | ||
| import org.openmrs.mobile.activities.login.LoginActivity; | ||
|
|
||
|
|
There was a problem hiding this comment.
Remove this line, or better to add class level doc here.
There was a problem hiding this comment.
Did you address this comment?
There was a problem hiding this comment.
Hey @suthagar23. I didn't quite get you. Could you explain it a bit more?
openmrs-client/src/main/java/org/openmrs/mobile/activities/SplashActivity.java
Show resolved
Hide resolved
openmrs-client/src/main/java/org/openmrs/mobile/activities/SplashActivity.java
Outdated
Show resolved
Hide resolved
openmrs-client/src/main/java/org/openmrs/mobile/activities/SplashActivity.java
Outdated
Show resolved
Hide resolved
f4ww4z
left a comment
f4ww4z
left a comment
There was a problem hiding this comment.
See my comments below @ribhavsharma . Make sure to add the OpenMRS copyright as a comment in new files. You can set up Android Studio to do this for you.
openmrs-client/src/main/java/org/openmrs/mobile/activities/SplashActivity.java
Outdated
Show resolved
Hide resolved
openmrs-client/src/main/java/org/openmrs/mobile/activities/SplashActivity.java
Outdated
Show resolved
Hide resolved
| import org.openmrs.mobile.R; | ||
| import org.openmrs.mobile.activities.login.LoginActivity; | ||
|
|
||
|
|
There was a problem hiding this comment.
Did you address this comment?
openmrs-client/src/main/java/org/openmrs/mobile/activities/SplashActivity.java
Outdated
Show resolved
Hide resolved
f4ww4z
left a comment
f4ww4z
left a comment
There was a problem hiding this comment.
See the comments below @ribhavsharma .
build.gradle
Outdated
| } | ||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:3.5.2' | ||
| classpath 'com.android.tools.build:gradle:3.2.0' |
There was a problem hiding this comment.
We don't need to downgrade this.
openmrs-client/src/main/java/org/openmrs/mobile/activities/SplashActivity.java
Outdated
Show resolved
Hide resolved
remove extra lines fix stuff remove xtra line + constant fix
f4ww4z
left a comment
f4ww4z
left a comment
There was a problem hiding this comment.
Looks good to me @ribhavsharma .
AC-560: Wrap Parent layout to match text size in charts list (openmrs#640) [AC-638] Added inputType for capitalizing the first letter (openmrs#643) added first time intro slides to app completed requested changes added seven intro slides [AC-638] Added inputType for capitalizing the first letter (openmrs#643) resolved conflicts resolved conflicts with splash screen squashing commits
5 participants
Description of what I changed
Added a Splash Screen to the app, with an animation.
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-636
GCI Task: https://codein.withgoogle.com/dashboard/task-instances/6153655376412672/
Screenshot
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)