-
Notifications
You must be signed in to change notification settings - Fork 15
Sync vllm with upstream/v0.5.5 to odh/main for 2.13 #134
Sync vllm with upstream/v0.5.5 to odh/main for 2.13 #134
Conversation
) Signed-off-by: Thomas Parnell <[email protected]>
…-project#7129) Co-authored-by: Jacob Schein <[email protected]>
Co-authored-by: Michael Goin <[email protected]>
…els (vllm-project#7153) Co-authored-by: Roger Wang <[email protected]>
Co-authored-by: katarzyna.papis <[email protected]>
Co-authored-by: Tyler Michael Smith <[email protected]>
…ences (towards eventual encoder/decoder model support) (vllm-project#4942) Co-authored-by: Andrew Feldman <[email protected]> Co-authored-by: Nick Hill <[email protected]>
…vllm-project#7238) Co-authored-by: Roger Wang <[email protected]>
…eter` and `weight_loader_v2` (vllm-project#5874)
Signed-off-by: Rafael Vasquez <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Max de Bayser <[email protected]> Co-authored-by: Robert Shaw <[email protected]>
Signed-off-by: kevin <[email protected]>
…and sccache bucket via build args (vllm-project#7705) Signed-off-by: kevin <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Co-authored-by: youkaichao <[email protected]>
Signed-off-by: Max de Bayser <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vaibhavjainwiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
/lgtm |
|
/retest-required |
|
/pj-rehearse |
|
/retest |
|
/test smoke-test |
|
@vaibhavjainwiz: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sync vllm with upstream/v0.5.5 to odh/main for 2.13
* formatting fixes * Upstream CR update * whitespace fix
FILL IN THE PR DESCRIPTION HERE
Jira : https://issues.redhat.com/browse/RHOAIENG-11580
FIX #xxxx (link existing issues this PR will resolve)
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Model]for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]For changes on the vLLM frontend (e.g., OpenAI API server,LLMclass, etc.)[Kernel]for changes affecting CUDA kernels or other compute kernels.[Core]for changes in the core vLLM logic (e.g.,LLMEngine,AsyncLLMEngine,Scheduler, etc.)[Hardware][Vendor]for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.shto format your code.docs/source/if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-requiredand might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-requiredlabel on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!