Skip to content

[Misc] Update marlin to use vLLMParameters #7803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgoin merged 1 commit into from
Aug 23, 2024
Merged

[Misc] Update marlin to use vLLMParameters #7803

mgoin merged 1 commit into from
Aug 23, 2024

Conversation

@dsikka
Copy link
Contributor

@dsikka dsikka commented Aug 23, 2024

Summary

  • Update marlin to use vllmParameters
  • Update weight loading TP test to run marlin channelwise/grouped quant models

@dsikka dsikka changed the title [Misc] Update marlin to use vLLMParameter [Misc] Update marlin to use vLLMParameters Aug 23, 2024
@github-actions
Copy link

github-actions bot commented Aug 23, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@dsikka
Copy link
Contributor Author

dsikka commented Aug 23, 2024

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 23, 2024
mgoin
mgoin approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mgoin mgoin merged commit f1df5db into vllm-project:main Aug 23, 2024
@mgoin mgoin deleted the update_marlin_param branch August 23, 2024 18:30
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@dsikka @Alvant
[Misc] Update marlin to use vLLMParameters (vllm-project#7803)
825c6a2 
Signed-off-by: Alvant <[email protected]>
@AlpinDale AlpinDale mentioned this pull request Dec 18, 2024
Merged
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
@dsikka @LeiWang1999
[Misc] Update marlin to use vLLMParameters (vllm-project#7803)
bba9c39 
Signed-off-by: LeiWang1999 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dsikka @mgoin