[pull] main from kserve:main #98
Conversation
Multi-platform build for `modelmesh-controller` and `modelmesh-controller-develop`; enable minikube deployments on Mac M1 laptops with ARM chip (#162, #231) - Remove `amd64` arch-specific `nodeAffinity` for modelmesh controller (#162, #231) - Build for platforms `linux/amd64`, `linux/arm64`, `linux/ppc64le`, `linux/s390x` - Use `ubi8/go-toolset:1.18` for developer image instead of `ubi8/ubi-minimal:8.7` - Build on `pull_request` as well as on `push` to catch build breaks during PR review - Push developer images to DockerHub on PR merge, use local registry for PR builds - Update deprecated `checkout` action - Fix infinite docker inside docker error when running `make run fmt` inside dev container - Update `build_devimage.sh` script to only pull developer image if not already present - Update `develop.sh` script to use the `.develop_image_name` Resolves #162 Resolves #231 --------- Signed-off-by: ddelange <[email protected]> Signed-off-by: Christian Kadner <[email protected]> Co-authored-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Remove the `--enable-self-signed-ca` option from the quickstart guide and webhook information. The quickstart instructions explicitly install the latest release `v0.10` which does not include the recently added `--enable-self-signed-ca`. Following the document as-is results in an `Unknown option` error. Resolves #370 Signed-off-by: Rafael Vasquez <[email protected]>
Fix "no space left on device" error for FVTs on GitHub action runners by deleting libraries that are not needed for dotnet, Android, PowerShell, Swift which increases available disk space by 25 GB plus an additional reclaimed space of 2.6 GB after pruning docker images. Resolves #367 Signed-off-by: Christian Kadner <[email protected]>
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi @pull[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pull
bot
added
⤵️ pull
merge-conflict
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add `arm64` to list of supported architectures for Node affinity to enable Quickstart deployments on MacBooks with M1 chips. Currently only `amd64` and `arm64` are supported by the ModelMesh runtime adapter. Signed-off-by: Christian Kadner <[email protected]>
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update TritonServer image version from 21.06.1 to 23.04 Closes #358 Signed-off-by: Rafael Vasquez <[email protected]>
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update KServe and dependencies in preparation for v0.11.0 release: - Update go.mod - Update CRDs under config/crd/bases - Remove outdated module replacements - Update Dockerfile.develop: - Use Go 1.19 - Fix broken controller-gen install - Add safe.directory work-around for the git 'dubious ownership' error during the GHA `lint` workflow - Temporarily disable lint deprecation check "SA1019" - Update Copyright header formatting in *.go sources to not be mistaken as package documentation - Update mock client GET function signature in grpc_resolver_test.go Signed-off-by: Rafael Vasquez <[email protected]> Signed-off-by: Christian Kadner <[email protected]> Co-authored-by: Christian Kadner <[email protected]>
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
#### Motivation When using the `storageURI` form of an HTTP (non Azure blob) address to download a model, the `modelPath` needs to be an non-empty string. Before this change, the `storageURI: http://models.r.us/my-model.json` form would be equivalent to the following `storage` spec: ``` storage: type: http path: '' # this being empty is problematic for later processing parameters: url: http://models.r.us/path/to/my-model.json ``` The http storage type is currently the only way to have a valid storage configuration with an empty `path` (mainly because it has a "url" parameter that could include the full path). That said, I'm not sure if we should make a `path` required for the HTTP storage type. In particular, if the `url` is just `http://models.r.us/`, there is no path portion. Related: kserve/modelmesh-runtime-adapter#41 (comment) #### Modifications Set `modelPath` to the URL's Path and set the `url` parameter to not have the URL Path. #### Result With these changes, the `storageURI` example above changes to have a `path` field: ``` storage: type: http path: path/to/my-model.json parameters: url: http://models.r.us/ ``` Signed-off-by: Travis Johnson <[email protected]> Signed-off-by: Christian Kadner <[email protected]> Co-authored-by: Christian Kadner <[email protected]>
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )