Skip to content

chore: Update TritonServer to 23.04 #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ckadner merged 10 commits into from
May 31, 2023
Merged

chore: Update TritonServer to 23.04 #359

ckadner merged 10 commits into from
May 31, 2023

Conversation

@rafvasq
Copy link
Member

@rafvasq rafvasq commented Apr 17, 2023 •
edited
Loading

Motivation

The default Triton serving runtime in ModelMesh hasn't been updated for a while. The latest version is 23.04.

Modifications

  • TritonServer image version in the default serving runtime and FVTs were updated from 21.06.1 to 23.04
  • Error message(s) were updated in FVT

Result

@rafvasq rafvasq requested review from njhill and tjohnson31415 April 17, 2023 20:58
@rafvasq rafvasq added this to the v0.11.0 milestone Apr 27, 2023
@rafvasq rafvasq changed the title chore: Update TritonServer to 23.03 chore: Update TritonServer to 23.04 Apr 28, 2023
@rafvasq rafvasq marked this pull request as ready for review May 2, 2023 19:54
@rafvasq rafvasq requested a review from ckadner May 2, 2023 19:54
njhill
njhill previously approved these changes May 25, 2023
View reviewed changes
@ckadner
Copy link
Member

ckadner commented May 26, 2023

@rafvasq -- could you update this PR to resolve the outstanding conflicts?

rafvasq added 4 commits May 26, 2023 10:51
@rafvasq
chore: Update TritonServer to 23.03
0be309d 
Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq
Updates error message
c13f270 
Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq
Updates error messages
9d596e4 
Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq
Update to 23.04
53de346 
Signed-off-by: Rafael Vasquez <[email protected]>
rafvasq added 2 commits May 26, 2023 16:56
@rafvasq
Extend timeout
2bb9c72 
Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq
Extend timeout to 2m
3cb8854 
Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq
Copy link
Member Author

rafvasq commented May 26, 2023 •
edited
Loading

@ckadner @njhill , I think that the FVTs are failing because mlserver-0.x doesn't come up properly with kserve/modelmesh-runtime-adapter#45 but #355 (update for mlserver-1.x) is not merged/included in this PR.

@rafvasq
Revert to 30s timeout
dfdecda 
Signed-off-by: Rafael Vasquez <[email protected]>
@ckadner
Copy link
Member

ckadner commented May 27, 2023

@ckadner @njhill , I think that the FVTs are failing because mlserver-0.x doesn't come up properly with kserve/modelmesh-runtime-adapter#45 but #355 (update for mlserver-1.x) is not merged/included in this PR.

@rafvasq -- did you try building those images locally and deploy them all together onto your dev cluster? Did the FVTs complete successful there?

@ckadner
Copy link
Member

ckadner commented May 27, 2023

@rafvasq -- #355 (update for mlserver-1.x) is merged now.

Could you update this PR once more?

@rafvasq rafvasq mentioned this pull request May 27, 2023
Merged
@rafvasq rafvasq requested a review from njhill May 30, 2023 16:21
ckadner
ckadner requested changes May 30, 2023
View reviewed changes
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a small nit pick

@rafvasq
Fix space/tab in license
046f1c4 
Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq rafvasq requested a review from ckadner May 30, 2023 19:33
ckadner
ckadner approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kserve-oss-bot
Copy link
Collaborator

kserve-oss-bot commented May 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, njhill, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@kserve-oss-bot
Copy link
Collaborator

kserve-oss-bot commented May 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, njhill, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit bd0e32c into kserve:main May 31, 2023
@rafvasq rafvasq deleted the update-triton branch May 31, 2023 19:29
lgdeloss pushed a commit to lgdeloss/modelmesh-serving that referenced this pull request Jun 5, 2023
@rafvasq @lgdeloss
chore: Update TritonServer to 23.04 (kserve#359)
3e18ecf 
Update TritonServer image version from 21.06.1 to 23.04

Closes kserve#358

Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Luis Delossantos <[email protected]>
lgdeloss pushed a commit to lgdeloss/modelmesh-serving that referenced this pull request Jun 6, 2023
@rafvasq @lgdeloss
chore: Update TritonServer to 23.04 (kserve#359)
679b4af 
Update TritonServer image version from 21.06.1 to 23.04

Closes kserve#358

Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Luis Delossantos <[email protected]>
@rafvasq rafvasq linked an issue Jan 19, 2024 that may be closed by this pull request
Upgrade Tritonserver to 22.07+ #254
Closed
This was referenced Jan 20, 2024
Closed
Closed
spolti referenced this pull request in spolti/modelmesh-serving May 16, 2025
@konflux-internal-p02
Update registry.access.redhat.com/ubi9/ubi-minimal Docker digest to a…
3f53336 
…50731d (opendatahub-io#359)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
hdefazio added a commit to hdefazio/modelmesh-serving that referenced this pull request Jul 17, 2025
@hdefazio
Merge pull request kserve#359 from opendatahub-io/appstudio-modelmesh…
bd76323 
…-serving-konflux-replicator

Update Tekton files to version odh-v2.32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckadner ckadner ckadner approved these changes

@njhill njhill njhill approved these changes

@tjohnson31415 tjohnson31415 Awaiting requested review from tjohnson31415

Assignees

@ckadner ckadner

Labels

approved lgtm

Projects

No open projects
KServe 0.11
Status: Done

Milestone

v0.11.0

Development

Successfully merging this pull request may close these issues.

Update Triton serving runtime image Upgrade Tritonserver to 22.07+

4 participants

@rafvasq @ckadner @kserve-oss-bot @njhill