-
Notifications
You must be signed in to change notification settings - Fork 42
Add pod anti-affinity to odh-model-controller manifests #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Edgar Hernández <[email protected]>
|
@israel-hdez this looks good to me. Could you please create another PR for the release branch? stable related folder must be synced with release branch too. |
This PR is covering both folders :-) |
|
I know but the stable folder will be used for deploying stable images in the stable branch as well so it should be synced with stable branch as well |
Hmmm... I think I understand. |
|
Correct. I will remove the other. |
Jooho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/approve cancel |
|
/retest |
Jooho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, Jooho The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Motivation
See opendatahub-io/odh-model-controller#51
PR checklist
Checklist items below are applicable for development targeted to both fast and stable branches/tags
Checklist items below are applicable for development targeted to both fast and stable branches/tags