Skip to content

Conversation

@israel-hdez
Copy link

@israel-hdez israel-hdez commented Jun 19, 2023

Motivation

See opendatahub-io/odh-model-controller#51

PR checklist

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Unit tests pass locally
  • FVT tests pass locally
  • If the PR adds a new container image or updates the tag of an existing image (not build within cpaas), is the corresponding change made in live-builder and cpaas-midstream to add/update the image tag in the operator CSV? Link the PRs if applicable

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Tested modelmesh serving deployment with odh-manifests and ran odh-manifests-e2e tests locally

@israel-hdez israel-hdez requested a review from Jooho June 19, 2023 21:32
@Jooho
Copy link

Jooho commented Jun 20, 2023

@israel-hdez this looks good to me. Could you please create another PR for the release branch? stable related folder must be synced with release branch too.

@israel-hdez
Copy link
Author

Could you please create another PR for the release branch? stable related folder must be synced with release branch too.

This PR is covering both folders :-)

@Jooho
Copy link

Jooho commented Jun 20, 2023

I know but the stable folder will be used for deploying stable images in the stable branch as well so it should be synced with stable branch as well

@israel-hdez
Copy link
Author

I know but the stable folder will be used for deploying stable images in the stable branch as well so it should be synced with stable branch as well

Hmmm... I think I understand.
I see two branches: release-v0.11.0-alpha and release-v0.11.0-rc0. The alpha one is the correct one, right?

@Jooho
Copy link

Jooho commented Jun 20, 2023

Correct. I will remove the other.

@israel-hdez
Copy link
Author

Could you please create another PR for the release branch? stable related folder must be synced with release branch too.

@Jooho Here is the PR: #120

Jooho
Jooho previously approved these changes Jun 23, 2023
Copy link

@Jooho Jooho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Jooho
Copy link

Jooho commented Jun 23, 2023

/approve cancel

@Jooho Jooho removed the approved label Jun 23, 2023
@Jooho Jooho dismissed their stale review June 23, 2023 02:37

retest

@Jooho Jooho removed the approved label Jun 23, 2023
@Jooho
Copy link

Jooho commented Jun 23, 2023

/retest

Copy link

@Jooho Jooho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, Jooho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jooho Jooho merged commit d6179f0 into opendatahub-io:main Jun 26, 2023
@israel-hdez israel-hdez deleted the add-mc-anti-affinity branch June 26, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants