Cherry-pick improvements from upstream to main
#125
Conversation
Signed-off-by: Luciano Resende <[email protected]>
Signed-off-by: Luciano Resende <[email protected]>
Signed-off-by: Luciano Resende <[email protected]>
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-version: 3.0.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [tornado](https://github.com/tornadoweb/tornado) from 6.4.2 to 6.5.1. - [Changelog](https://github.com/tornadoweb/tornado/blob/master/docs/releases.rst) - [Commits](tornadoweb/tornado@v6.4.2...v6.5.1) --- updated-dependencies: - dependency-name: tornado dependency-version: 6.5.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [requests](https://github.com/psf/requests) from 2.32.3 to 2.32.4. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.3...v2.32.4) --- updated-dependencies: - dependency-name: requests dependency-version: 2.32.4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--- updated-dependencies: - dependency-name: form-data dependency-version: 4.0.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Luciano Resende <[email protected]>
Signed-off-by: Luciano Resende <[email protected]>
WalkthroughThis change set removes the Elyra Code Viewer extension from the project. All related files, configuration entries, documentation references, and build/publish steps for the code viewer extension are deleted or updated. Dependency versions for several Python packages are also bumped, and new release notes are added to the changelog. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~18 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
docs/source/developer_guide/release.md (1)
212-212: Typo: “awerness” → “awareness”Minor spelling nit in the newly edited sentence.
- To raise awerness for new releases + To raise awareness for new releasesdocs/source/getting_started/changelog.md (1)
27-31: Remove the duplicated bullet for the code-viewer switch
- Switch from elyra-code-viewer to jupyterlab-code-viewer - [#3265]appears twice in the same 4.0.0 rc2 section. Keeping both clutters the changelog and needlessly inflates the diff.@@ - Update JupyterLab version compatibility all way to 4.3.x - [#3293](https://github.com/elyra-ai/elyra/pull/3293) - Switch from elyra-code-viewer to jupyterlab-code-viewer - [#3265](https://github.com/elyra-ai/elyra/pull/3265) See the full changelog below: - - Switch from elyra-code-viewer to jupyterlab-code-viewer - [#3265](https://github.com/elyra-ai/elyra/pull/3265) +<!-- duplicate removed -->
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (16)
README.md(0 hunks)create-release.py(1 hunks)docs/source/developer_guide/release.md(1 hunks)docs/source/getting_started/changelog.md(1 hunks)docs/source/getting_started/installation.md(0 hunks)etc/generic/requirements-elyra.txt(1 hunks)labextensions/elyra_code_viewer_extension/__init__.py(0 hunks)packages/code-viewer/install.json(0 hunks)packages/code-viewer/package.json(0 hunks)packages/code-viewer/setup.py(0 hunks)packages/code-viewer/src/CodeViewerWidget.ts(0 hunks)packages/code-viewer/src/index.ts(0 hunks)packages/code-viewer/style/index.css(0 hunks)packages/code-viewer/tsconfig.json(0 hunks)packages/pipeline-editor/src/PipelineEditorWidget.tsx(1 hunks)pyproject.toml(1 hunks)
💤 Files with no reviewable changes (10)
- packages/code-viewer/package.json
- packages/code-viewer/style/index.css
- README.md
- packages/code-viewer/install.json
- packages/code-viewer/src/index.ts
- packages/code-viewer/setup.py
- docs/source/getting_started/installation.md
- packages/code-viewer/tsconfig.json
- labextensions/elyra_code_viewer_extension/init.py
- packages/code-viewer/src/CodeViewerWidget.ts
🔇 Additional comments (3)
etc/generic/requirements-elyra.txt (1)
16-17: Verify downstream compatibility of newrequests2.32.4 /tornado6.5.1 pinsBoth bumps are patch/feature releases that should be safe, but:
tornado6.5.x just introduced breaking TLS changes that bit some JupyterLab 4.2+ installs.requests2.32.4 only fixes a metadata issue but pulls inurllib32.x if un-pinned elsewhere.Please run the integration test matrix (JupyterLab, notebook execution, pipeline submission) before cutting a release to ensure nothing regresses.
packages/pipeline-editor/src/PipelineEditorWidget.tsx (1)
122-123: All code references updated for renamed command
A global search (rg -n "'elyra-code-viewer:open'") found no occurrences of the old command name in the repo.Please manually verify the following remain up-to-date:
- Any user keybindings in the Advanced Settings Editor
- External extension or fixture configurations (e.g., pipeline-services, test fixtures)
create-release.py (1)
607-607: LGTM! Correctly removes code-viewer-extension dependency.The removal of "code-viewer-extension" from the elyra-pipeline-editor-extension packages list aligns with the PR objective to remove the internal Elyra Code Viewer extension and switch to jupyterlab-code-viewer. This change ensures the pipeline editor extension will no longer include the deprecated code viewer component in future releases.
| "jupyterlab~=4.4", # comment out to use local jupyterlab | ||
| "jupyterlab-lsp~=5.1.0", # comment out to use local jupyterlab | ||
| "jupyterlab-git~=0.50.0", # Avoid breaking 1.x changes | ||
| "jupyterlab-git~=0.51.2", # Avoid breaking 1.x changes |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Double-check jupyterlab-git 0.51.2 with JupyterLab 4.4
0.51.2 advertises JL 4.0–4.2 support; JL 4.4 APIs changed slightly (notably the diff widget). If you hit MIME-render or model-DB errors, you may need to wait for ≥0.52 or pin JL to 4.2 in this distribution.
🌐 Web query:
What JupyterLab versions does jupyterlab-git 0.51.2 support? Please check the PyPI metadata or GitHub release notes for jupyterlab-git 0.51.2.
💡 Result:
The jupyterlab-git extension version 0.51.2 is compatible with JupyterLab versions 4.0 and later. For earlier versions of JupyterLab (2.x and 3.x), the extension provides separate branches:
- JupyterLab 3.x: Use the
3.xbranch. - JupyterLab 2.x: Use the
2.xbranch.
These branches ensure compatibility with the respective JupyterLab versions. (github.com)
Citations:
Update jupyterlab-git compatibility note
The jupyterlab-git 0.51.2 release officially targets JupyterLab 4.0 and later (including 4.4), so the warning about only 4.0–4.2 support is out of date. Retain a brief note on upgrading if you hit API breakage:
• File: pyproject.toml (line 32)
• Replace the existing comment on that dependency with something like:
- "jupyterlab-git~=0.51.2", # Avoid breaking 1.x changes
+ "jupyterlab-git~=0.51.2", # Compatible with JupyterLab 4.0+ (incl. 4.4); if you see diff-widget or model/DB errors, upgrade to ≥0.52 or pin JL to 4.2🤖 Prompt for AI Agents
In pyproject.toml at line 32, update the comment on the "jupyterlab-git~=0.51.2"
dependency to reflect that this version supports JupyterLab 4.0 and later,
including 4.4. Replace the outdated note about only supporting 4.0–4.2 with a
brief mention advising users to upgrade if they encounter API breakage.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
- Coverage 80.51% 80.50% -0.02%
==========================================
Files 151 151
Lines 19486 19484 -2
Branches 483 487 +4
==========================================
- Hits 15690 15685 -5
- Misses 3611 3617 +6
+ Partials 185 182 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jesuino
left a comment
jesuino
left a comment
There was a problem hiding this comment.
It looks good to me!
It seems to be mostly versions updates and the removal of the custom code viewer in favor of the one provided by JupyterLab.
4 participants
Summary by CodeRabbit
New Features
Dependency Updates
requests,tornado, andjupyterlab-git.Bug Fixes
Documentation
Chores