-
Notifications
You must be signed in to change notification settings - Fork 360
Switch from elyra-code-viewer to jupyterlab-code-viewer #3265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d575d60 to
0540d26
Compare
|
I want someone other than me to confirm it has been switched properly, and I can handle the other clean-up items with additional commits. |
|
NP! I can build and test it locally too. |
|
We should also
Edit:
Ah, I see, good idea. |
Signed-off-by: Luciano Resende <[email protected]>
0540d26 to
056ffbf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3265 +/- ##
=======================================
Coverage ? 83.80%
=======================================
Files ? 158
Lines ? 19939
Branches ? 503
=======================================
Hits ? 16709
Misses ? 3048
Partials ? 182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
caponetto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@lresende nice work, looks good to me, too. Neat to see this kind of functionality "ability to display a given chunk of code (string) in a transient read-only ‘editor’ without needing to create a file" in Jupyterlab now. |
Signed-off-by: Luciano Resende <[email protected]>
* Update jupyterlab-git to 0.51.2 to fix vulnerability (elyra-ai#3319) Signed-off-by: Luciano Resende <[email protected]> * Switch from elyra-code-viewer to jupyterlab-code-viewer (elyra-ai#3265) Signed-off-by: Luciano Resende <[email protected]> * Update changelog for release 4.0.0rc2 Signed-off-by: Luciano Resende <[email protected]> * Bump braces from 3.0.2 to 3.0.3 (elyra-ai#3309) Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-version: 3.0.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump tornado from 6.4.2 to 6.5.1 in /etc/generic (elyra-ai#3313) Bumps [tornado](https://github.com/tornadoweb/tornado) from 6.4.2 to 6.5.1. - [Changelog](https://github.com/tornadoweb/tornado/blob/master/docs/releases.rst) - [Commits](tornadoweb/tornado@v6.4.2...v6.5.1) --- updated-dependencies: - dependency-name: tornado dependency-version: 6.5.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump requests from 2.32.3 to 2.32.4 in /etc/generic (elyra-ai#3314) Bumps [requests](https://github.com/psf/requests) from 2.32.3 to 2.32.4. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.3...v2.32.4) --- updated-dependencies: - dependency-name: requests dependency-version: 2.32.4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump form-data from 4.0.0 to 4.0.4 (elyra-ai#3317) --- updated-dependencies: - dependency-name: form-data dependency-version: 4.0.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update changelog for release 4.0.0rc4 (elyra-ai#3318) Signed-off-by: Luciano Resende <[email protected]> * Update changelog for release 4.0.0rc5 Signed-off-by: Luciano Resende <[email protected]> --------- Signed-off-by: Luciano Resende <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Luciano Resende <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
What changes were proposed in this pull request?
Switch from elyra-code-viewer to jupyterlab-code-viewer
Fixes #2711
Developer's Certificate of Origin 1.1