AddDevice(): better diagnostic when creating dup #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing diagnostic[1] appeared in a CI job with no possible hope of figuring out the source of the problem. This PR amends the diagnostic to include the name of the requested newly-created device as well as the existing "duplicate". [1] WARNING: The same type, major and minor should not be used for multiple devices. (I am not convinced that this condition merits a warning but will leave that discussion to better minds than mine). Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
better_dup_device_warning
branch
from
2d06aca to
120c67a
Compare
Contributor
Author
|
@q384566678 could you PTAL? Thanks in advance. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing diagnostic[1] appeared in a CI job with no
possible hope of figuring out the source of the problem.
This PR amends the diagnostic to include the name of
the requested newly-created device as well as the
existing "duplicate".
[1] WARNING: The same type, major and minor should not be used for multiple devices.
(I am not convinced that this condition merits a warning
but will leave that discussion to better minds than mine).
Signed-off-by: Ed Santiago [email protected]