more BATS tests

[edsantiago]

• run: --name (includes 'podman container exists' tests)
• run: --pull (always, never, missing)
• build: new test for ADD URL ([CI:DOCS] make docsonly prs #4420)
• exec: new test for issue Docker/podman difference when piping to exec statement #4785 (pipe getting lost)
• diff: new test
• selinux (mostly copied from docker-autotest)

Plus a bug fix: the wait_for_output() helper would continue
checking, eventually timing out, even if the container had
already exited (probably because of an error). Fix: as
part of the loop, run 'podman inspect' and bail out if
container is not running. Include exit code and logs.

Signed-off-by: Ed Santiago [email protected]

[edsantiago]

[Test failure was because podman-remote does not emit "Trying to pull ..." messages; so there's no way to distinguish I-pulled from image-was-already-here. Decided to just skip_if_remote.]

[edsantiago]

$ ./bin/podman run --rm --privileged --userns=host quay.io/libpod/alpine_labels:latest cat -v /proc/self/attr/current
WARNING: The same type, major and minor should not be used for multiple devices.

Any ideas?

[edsantiago]

It's not a flake: rerunning fails the same way. There's something weird about the f30 test image, and I suspect it's a real problem. Unfortunately it will be almost impossible to debug. I've submitted opencontainers/runtime-tools#701 as a long-term future way of getting a slight clue about what's wrong, but even if that's accepted (which is unlikely because its CI is failing and I have no idea why) it would take time to vendor this into podman.

[TomSweeneyRedHat]

Maybe I'm missing something, but I'm not seeing the warning when I run it "by hand" on my F30 vm with upstream Podman. However the output is missing a carriage return, it couldn't be that could it?

$ podman run --rm --privileged --userns=host quay.io/libpod/alpine_labels:latest cat -v /proc/self/attr/current
unconfined_u:system_r:container_runtime_t:s0^@[tom@localhost ~]$

[edsantiago]

No, it works fine (no warning message) on all the f30 systems I've tried. The problem is something specific to the CI one. (And no, it's not the NUL-instead-of-NL terminator. That's just the way /proc/self/attr/current works everywhere). Thanks for checking!

[jwhonce]

LGTM when tests pass

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jwhonce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

sudo podman run --rm --privileged quay.io/libpod/alpine_labels:latest cat -v /proc/self/attr/current
WARNING: The same type, major and minor should not be used for multiple devices.

Something is wacky with --privileged. Looks like a bug.

[rhatdan]

Well the good thing, is this bug exists with older podman.

podman run --privileged alpine echo hello
WARNING: The same type, major and minor should not be used for multiple devices.
hello

rpm -q podman
podman-1.6.2-2.fc31.x86_64

[rhatdan]

Added a little extra ouput

WARNING: The same type, major and minor should not be used for multiple devices. /dev/null

Looks like we have two /dev/null added.

[rhatdan]

Looks like the way my host was configured.

sh-5.0# mknod /dev/foo c 1 3 
sh-5.0# podman run --privileged alpine echo hello
WARNING: The same type, major and minor should not be used for multiple devices.
sh-5.0# rm -f /dev/foo 
sh-5.0# podman run --privileged alpine echo hello
hello

[edsantiago]

opencontainers/runtime-tools#701 is merged, so some day we'll get greater visibility into what the problem is, but that could take years (new runtime-tools release, then a podman revendor). ITM I've simply special-cased the warning and ignored it. The warning will still appear in test logs, in case anyone wants to fix it, but the selinux test will not fail because of it.

[rhatdan]

/lgtm