runtimetest: add linux devices validation #211
Conversation
|
|
||
| linuxValidations := []validation{ | ||
| validateDefaultFS, | ||
| validateDefaultDevices, |
There was a problem hiding this comment.
We want to keep this (as long as the spec requires runtimes to supply those devices).
There was a problem hiding this comment.
On 09/14/2016 01:38 AM, W. Trevor King wrote:
We want to keep this (as long as the spec requires runtimes to supply those devices).
validateDefaultDevices is not removed.
I have just merged it into validateLinuxDevices
There was a problem hiding this comment.
un... I think separate them more reasonable, will update.
Mashimiao
force-pushed
the
runtime-test-linux-devices-validation
branch
from
3141370 to
3d60190
Compare
|
@wking I think adding the caveat and rewriting runtimetest to not carry on instead of dying on errors in a follow-up PR is more reasonable. |
|
On Wed, Sep 14, 2016 at 03:07:57AM -0700, Ma Shimiao wrote:
Sure, although the one-liner I suggest in 1 seems easy enough to add |
cmd/runtimetest/main.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| fStat := fi.Sys().(*syscall.Stat_t) |
There was a problem hiding this comment.
This Stat with its type/major/minor checks (and probably the Stat existence check too) should get pulled out into it's own helper (func validateDevice(path string, device *rspec.Device) error?) so we can use it in validateDefaultDevices as well.
There was a problem hiding this comment.
On 09/14/2016 11:46 PM, W. Trevor King wrote:
This |Stat| with its type/major/minor checks (and probably the |Stat| existence check too) should get pulled out into it's own helper (|func validateDevice(path string, device *rspec.Device) error|?) so we can use it in |validateDefaultDevices| as well.
added |Stat| existence check.
I think helper function is not needed yet, as default device validation does not need so complicated check
Signed-off-by: Ma Shimiao <[email protected]>
Mashimiao
force-pushed
the
runtime-test-linux-devices-validation
branch
from
3d60190 to
f0ae1dc
Compare
|
I still have some changes I'd like to make to this PR [1,2], but I |
|
LGTM |
Signed-off-by: Ma Shimiao <[email protected]> Backported to v1.0.0.rc1 from f0ae1dc opencontainers#211 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <[email protected]>
As I recommended earlier [1], in the context of checking for all
configured devices. An example would be:
{
...
"linux": {
"devices": [
{
"path": "/dev/fuse",
...
}
],
},
"hooks": {
"prestart": [
{
"path": "/bin/rm",
"args": ["rm", "/dev/fuse"]
}
}
}
}
where the resulting container (when created by a conformant runtime)
would not have the /dev/fuse entry runtimetest's linux.devices check
is looking for.
[1]: opencontainers#211 (comment)
Signed-off-by: W. Trevor King <[email protected]>
As I recommended earlier in the context of checking for all configured
devices [1]. An example would be:
{
...
"linux": {
"devices": [
{
"path": "/dev/fuse",
...
}
],
},
"hooks": {
"prestart": [
{
"path": "/bin/rm",
"args": ["rm", "/dev/fuse"]
}
}
}
}
where the resulting container (when created by a conformant runtime)
would not have the /dev/fuse entry runtimetest's linux.devices check
is looking for.
[1]: opencontainers#211 (comment)
Signed-off-by: W. Trevor King <[email protected]>
As I recommended earlier in the context of checking for all configured
devices [1]. An example would be:
{
...
"linux": {
"devices": [
{
"path": "/dev/fuse",
...
}
],
},
"hooks": {
"prestart": [
{
"path": "/bin/rm",
"args": ["rm", "/dev/fuse"]
}
}
}
}
where the resulting container (when created by a conformant runtime)
would not have the /dev/fuse entry runtimetest's linux.devices check
is looking for.
[1]: opencontainers#211 (comment)
Signed-off-by: W. Trevor King <[email protected]>
As I recommended earlier in the context of checking for all configured
devices [1]. An example would be:
{
...
"linux": {
"devices": [
{
"path": "/dev/fuse",
...
}
],
},
"hooks": {
"prestart": [
{
"path": "/bin/rm",
"args": ["rm", "/dev/fuse"]
}
}
}
}
where the resulting container (when created by a conformant runtime)
would not have the /dev/fuse entry runtimetest's linux.devices check
is looking for.
[1]: opencontainers#211 (comment)
Signed-off-by: W. Trevor King <[email protected]>
As I recommended earlier in the context of checking for all configured
devices [1]. An example would be:
{
...
"linux": {
"devices": [
{
"path": "/dev/fuse",
...
}
],
},
"hooks": {
"prestart": [
{
"path": "/bin/rm",
"args": ["rm", "/dev/fuse"]
}
}
}
}
where the resulting container (when created by a conformant runtime)
would not have the /dev/fuse entry runtimetest's linux.devices check
is looking for.
[1]: opencontainers#211 (comment)
Signed-off-by: W. Trevor King <[email protected]>
3 participants
Signed-off-by: Ma Shimiao [email protected]