runtime: support IDMappings validation #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mashimiao
force-pushed
the
runtime-test-id-mappings-validation
branch
from
1a3d905 to
77affb7
Compare
cmd/runtimetest/main.go
Outdated
| case "uid_map": | ||
| mapFile = "/proc/1/uid_map" | ||
| case "gid_map": | ||
| mapFile = "/proc/1/gid_map" |
Contributor
There was a problem hiding this comment.
Can we look at /proc/self/*_map instead? Then we don't have to think about “is it ok to look at PID 1's maps?”. I can't think of a case where looking at PID 1 would be wrong, but I know looking at /proc/self/*_map will be right ;).
Contributor
There was a problem hiding this comment.
And I'd bump this choice up to the caller and have getIDMappings take a path:
func getIDMappings(path string) ([]rspec.IDMapping, error)
e5725bd to
c746333
Compare
Signed-off-by: Ma Shimiao <[email protected]>
Mashimiao
force-pushed
the
runtime-test-id-mappings-validation
branch
from
c746333 to
46fea50
Compare
Author
|
@mrunalp @liangchenye rebased. |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ma Shimiao [email protected]