Skip to content

Conversation

@wking
Copy link
Contributor

@wking wking commented Jul 26, 2016

The commit reference that landed in 2d0dbcf (Update runtime-spec dependency to v1.0.0-rc1, 2016-06-14, #110) was a few commits after the tag, but the v1.0.0.rc1 branch is aiming for compatibility with the tagged release (e.g. no -dev suffix on the generated version).

I am not very familiar with godep, so I stubled around for a bit to make this change and don't have a set of copy/paste steps to share here :p.

@wking wking force-pushed the v1.0.0.rc1-godep branch from 140c568 to 2ff135b Compare July 26, 2016 20:58
@mrunalp
Copy link
Contributor

mrunalp commented Jul 26, 2016

Looks fine but not sure why the git validation is failing.

The commit reference that landed in 2d0dbcf (Update runtime-spec
dependency to v1.0.0-rc1, 2016-06-14, opencontainers#110) was a few commits after
the tag, but the v1.0.0.rc1 branch is aiming for compatibility with
the tagged release (e.g. no -dev suffix on the generated version).

Signed-off-by: W. Trevor King <[email protected]>
@wking wking force-pushed the v1.0.0.rc1-godep branch from 2ff135b to 1862ec6 Compare July 26, 2016 23:47
@wking
Copy link
Contributor Author

wking commented Jul 26, 2016

On Tue, Jul 26, 2016 at 04:44:13PM -0700, Mrunal Patel wrote:

Looks fine but not sure why the git validation is failing.

Looks like I forgot the Signed-off-by 1. Fixed with 2ff135b
1862ec6.

@mrunalp
Copy link
Contributor

mrunalp commented Jul 26, 2016

LGTM

@mrunalp mrunalp merged commit 6acca9e into opencontainers:v1.0.0.rc1 Jul 26, 2016
@wking wking deleted the v1.0.0.rc1-godep branch July 28, 2016 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants