Skip to content

Conversation

@mrunalp
Copy link
Contributor

@mrunalp mrunalp commented Jun 14, 2016

Signed-off-by: Mrunal Patel [email protected]

@wking
Copy link
Contributor

wking commented Jun 14, 2016

On Tue, Jun 14, 2016 at 02:14:49PM -0700, Mrunal Patel wrote:

M Godeps/Godeps.json (6)
M Godeps/_workspace/src/github.com/opencontainers/runtime-spec/specs-go/config.go (76)
M Godeps/_workspace/src/github.com/opencontainers/runtime-spec/specs-go/state.go (4)
M Godeps/_workspace/src/github.com/opencontainers/runtime-spec/specs-go/version.go (6)

This updates the config structures, but it doesn't update test_runtime
to use the newly-split create/start (opencontainers/runtime-spec#384).
Are we going to do that in a follow-up PR? And we'll have to drop
Bash or insert something like 1 now that we need
PR_SET_CHILD_SUBREAPER to collect the container process's exit code
2.

@mrunalp
Copy link
Contributor Author

mrunalp commented Jun 14, 2016

@wking Yes, we can make that change in a follow-on PR.

@liangchenye
Copy link
Member

LGTM

@wking
Copy link
Contributor

wking commented Jun 15, 2016

On Tue, Jun 14, 2016 at 03:42:04PM -0700, Mrunal Patel wrote:

@wking Yes, we can do that change in a follow-on PR.

In that cases there's not much chance of anything going wrong here,
since there were no backwards icompatible runtime-spec/specs-go
changes between 0.5.0 and 1.0.0-rc1.

@mrunalp mrunalp merged commit 683a2aa into opencontainers:master Jun 15, 2016
@wking
Copy link
Contributor

wking commented Jun 17, 2016

On Tue, Jun 14, 2016 at 02:14:49PM -0700, Mrunal Patel wrote:

M Godeps/Godeps.json (6)

This actually bumped to v1.0.0-rc1-15-g6de52a7, 15 commits after the
v1.0.0-rc1 tag. Can we roll it back to the tag? With the current
Godeps I'm still seeing #108:

$ ./test_runtime.sh -r ccon-oci


VALIDATING RUNTIME: ccon-oci



NotImplementedError: unsupported OCI-spec version: 1.0.0-rc1-dev
Runtime ccon-oci failed validation

wking added a commit to wking/ocitools-v2 that referenced this pull request Jul 26, 2016
The commit reference that landed in 2d0dbcf (Update runtime-spec
dependency to v1.0.0-rc1, 2016-06-14, opencontainers#110) was a few commits after
the tag, but the v1.0.0.rc1 branch is aiming for compatibility with
the tagged release (e.g. no -dev suffix on the generated version).
wking added a commit to wking/ocitools-v2 that referenced this pull request Jul 26, 2016
The commit reference that landed in 2d0dbcf (Update runtime-spec
dependency to v1.0.0-rc1, 2016-06-14, opencontainers#110) was a few commits after
the tag, but the v1.0.0.rc1 branch is aiming for compatibility with
the tagged release (e.g. no -dev suffix on the generated version).
wking added a commit to wking/ocitools-v2 that referenced this pull request Jul 26, 2016
The commit reference that landed in 2d0dbcf (Update runtime-spec
dependency to v1.0.0-rc1, 2016-06-14, opencontainers#110) was a few commits after
the tag, but the v1.0.0.rc1 branch is aiming for compatibility with
the tagged release (e.g. no -dev suffix on the generated version).

Signed-off-by: W. Trevor King <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants