Example lists "root' but text mentions "bundlePath" #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@nponeccop Can you sign your commit? Thanks. |
Contributor
Author
|
I remember doing that in the past but now somehow cannot google how to sign-off my existing commit. Can you help or find a reference? |
Member
|
@nponeccop |
Contributor
|
@nponeccop There is instruction in README.md |
Contributor
|
On Sun, Nov 29, 2015 at 03:00:09AM -0800, nponeccop wrote:
Cross-linking #206, so folks reading either PR can find the related |
Closed
Signed-off-by: Andrii Melnykov <[email protected]>
Contributor
|
LGTM |
mrunalp
pushed a commit
that referenced
this pull request
Dec 4, 2015
Example lists "root' but text mentions "bundlePath"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.