Rename State's Root to Bundle #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crosbymichael
force-pushed
the
bundle-state
branch
from
f71ea55 to
1d05ac4
Compare
Contributor
|
LGTM |
config.go
Outdated
Contributor
There was a problem hiding this comment.
nit: How about BundlePath since Bundle can be interpreted as the name of the bundle.
crosbymichael
force-pushed
the
bundle-state
branch
from
1d05ac4 to
8ff2dca
Compare
Member
Author
|
Updated |
runtime.md
Outdated
Member
Author
There was a problem hiding this comment.
what do you mean? i don't see it?
Member
There was a problem hiding this comment.
add backticks around "bundlepath"
Member
|
one last nit, and LGTM |
crosbymichael
force-pushed
the
bundle-state
branch
from
8ff2dca to
a745b1c
Compare
Signed-off-by: Michael Crosby <[email protected]>
crosbymichael
force-pushed
the
bundle-state
branch
from
a745b1c to
34def3a
Compare
Member
Author
|
@vbatts done |
Contributor
|
LGTM. All comments have been addressed. Merging. |
mrunalp
pushed a commit
that referenced
this pull request
Sep 29, 2015
Rename State's Root to Bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Crosby [email protected]