Fix: "INVAILD" typo in enum '_sai_dash_flow_entry_bulk_get_session_filter_key_t'#2224
Merged
prsunny merged 1 commit intoopencomputeproject:masterfrom Nov 13, 2025
Merged
Conversation
…lter_key_t' Signed-off-by: Farhan Tariq <farhantariq1016@gmail.com>
prsunny
approved these changes
Nov 13, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JaiOCP
added a commit
to JaiOCP/SAI
that referenced
this pull request
Dec 19, 2025
Signed-off-by: JaiOCP <jai.kumar@broadcom.com> CSIG Port and Switch Attributes Signed-off-by: JaiOCP <jai.kumar@broadcom.com> CSIG ACL Attributes Signed-off-by: JaiOCP <jai.kumar@broadcom.com> CSIG TAM Attributes Signed-off-by: JaiOCP <jai.kumar@broadcom.com> CSIG Time Interval Unit Signed-off-by: JaiOCP <jai.kumar@broadcom.com> CSIG Document Signed-off-by: JaiOCP <jai.kumar@broadcom.com> CSIG Document Signed-off-by: JaiOCP <jai.kumar@broadcom.com> CSIG Document Signed-off-by: JaiOCP <jai.kumar@broadcom.com> Fix: "INVAILD" typo in enum '_sai_dash_flow_entry_bulk_get_session_filter_key_t' (opencomputeproject#2224) This PR fixes a typo in the enum definition for dash_flow_entry_bulk_get_session_filter_key_t where the member INVAILD is corrected to INVALID. Changes: saitypesextensions.h: Renamed enum member INVAILD → INVALID. Following will be pushed to DASH's repo once these SAI repo changes are merged. dash_headers.p4: Renamed enum member INVAILD → INVALID. Non UEC Member Agreement Form (opencomputeproject#2226) Signed-off-by: JaiOCP <jai.kumar@broadcom.com> Seamless BFD (S-BFD) (opencomputeproject#2220) Signed-off-by: Jason Bos <jbos@cisco.com> Replicate VXLAN UDP sport security to switch level (opencomputeproject#2195) - Add SAI_SWITCH_TUNNEL_ATTR_VXLAN_UDP_SPORT_SECURITY attribute to drop tunnel packets with UDP source port outside allowed range - Add documentation for UDP source port validation on VXLAN packet ingress - Update both saiswitch.h and saitunnel.h with security clarifications Signed-off-by: Marian Pritsak <marianp@mellanox.com> SRv6 SID Marking (opencomputeproject#2222) * SID Marking APIs Signed-off-by: Jason Bos <jbos@cisco.com> [DASH] Add flow bulk get session event data struct (opencomputeproject#2175) * [DASH] Add flow bulk get session event data struct Add flow bulk get event callback and supporting structures to provide ability to query flows in asynchronous manner. Introducing SAI_PORT_ATTR_PORT_PG_PKT_DROP_STATUS (opencomputeproject#2234) In this map, the key is the PG index and the status value (clear-on-read) for each PG is from {0, 1}, where 0 indicates no drops were observed and 1 indicates packet drops. Signed-off-by: Prasun Sinha <prasunsinha@google.com> Add flow entry to the bulk session event data (opencomputeproject#2237) Add the ability to query the flows with the bulk get session event data callback. The commit contains a fix for bad ordering of classes generated by Thrift compiler for the nested structures used in this callback. Signed-off-by: Marian Pritsak <marianp@mellanox.com>
tjchadaga
pushed a commit
that referenced
this pull request
Jan 5, 2026
…lter_key_t' (#2224) This PR fixes a typo in the enum definition for dash_flow_entry_bulk_get_session_filter_key_t where the member INVAILD is corrected to INVALID. Changes: saitypesextensions.h: Renamed enum member INVAILD → INVALID. Following will be pushed to DASH's repo once these SAI repo changes are merged. dash_headers.p4: Renamed enum member INVAILD → INVALID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a typo in the enum definition for dash_flow_entry_bulk_get_session_filter_key_t where the member INVAILD is corrected to INVALID.
Changes:
Following will be pushed to DASH's repo once these SAI repo changes are merged.
Rationale:
The incorrect spelling (INVAILD) exists both in DASH’s P4 headers and in the SAI specification. This mismatch causes header generation to fail when fixing the typo in P4 alone. By correcting the typo in both SAI and DASH, we maintain consistency and enable successful SAI header generation.
Impact: