Skip to content

Replicate VXLAN UDP sport security to switch level#2195

Merged
tjchadaga merged 1 commit intoopencomputeproject:masterfrom
marian-pritsak:tunnel-security
Dec 2, 2025
Merged

Replicate VXLAN UDP sport security to switch level#2195
tjchadaga merged 1 commit intoopencomputeproject:masterfrom
marian-pritsak:tunnel-security

Conversation

@marian-pritsak
Copy link
Copy Markdown
Contributor

@marian-pritsak marian-pritsak commented Aug 21, 2025

  • Add SAI_SWITCH_TUNNEL_ATTR_VXLAN_UDP_SPORT_SECURITY attribute to drop tunnel packets with UDP source port outside allowed range
  • Add documentation for UDP source port validation on VXLAN packet ingress
  • Update both saiswitch.h and saitunnel.h with security clarifications

@KrisNey-MSFT
Copy link
Copy Markdown

hi @marian-pritsak , would it be possible to accept the spelling change for this one?

@prsunny
Copy link
Copy Markdown
Collaborator

prsunny commented Oct 7, 2025

@marian-pritsak , gentle reminder to address the comments

@KrisNey-MSFT
Copy link
Copy Markdown

hello @marian-pritsak , would you please check this one? TY...

@KrisNey-MSFT
Copy link
Copy Markdown

Expected to look at this one tomorrow

@tjchadaga
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@marian-pritsak marian-pritsak changed the title Expand the definition of VxLAN UDP SRC Port Replicate VXLAN UDP sport security to switch level Nov 4, 2025
@marian-pritsak marian-pritsak force-pushed the tunnel-security branch 2 times, most recently from b36de10 to b21de56 Compare November 6, 2025 16:24
@tjchadaga
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@KrisNey-MSFT
Copy link
Copy Markdown

Discussed in meeting w/ @prsunny - AI is to review

inc/saitunnel.h Outdated
* @brief Tunnel UDP source port
*
* See also SAI_TUNNEL_ATTR_VXLAN_UDP_SPORT_SECURITY.
* This attribute is applied to VXLAN pockets ingressing the switch. If the incoming
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo on packets

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

inc/saiswitch.h Outdated
* @brief Tunnel UDP source port
*
* See also SAI_SWITCH_TUNNEL_ATTR_VXLAN_UDP_SPORT_SECURITY.
* This attribute is applied to VXLAN pockets ingressing the switch. If the incoming
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo on packets

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

- Add SAI_SWITCH_TUNNEL_ATTR_VXLAN_UDP_SPORT_SECURITY attribute to drop tunnel packets with UDP source port outside allowed range
- Add documentation for UDP source port validation on VXLAN packet ingress
- Update both saiswitch.h and saitunnel.h with security clarifications

Signed-off-by: Marian Pritsak <marianp@mellanox.com>
@prsunny
Copy link
Copy Markdown
Collaborator

prsunny commented Nov 20, 2025

@tjchadaga , would you help merge?

@prsunny
Copy link
Copy Markdown
Collaborator

prsunny commented Nov 20, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@tjchadaga
Copy link
Copy Markdown
Collaborator

@JaiOCP, @ashutosh-agrawal, @rck-innovium - could you please help take a quick look?

@tjchadaga tjchadaga merged commit 58d95ce into opencomputeproject:master Dec 2, 2025
3 checks passed
JaiOCP added a commit to JaiOCP/SAI that referenced this pull request Dec 19, 2025
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>

CSIG Port and Switch Attributes

Signed-off-by: JaiOCP <jai.kumar@broadcom.com>

CSIG ACL Attributes

Signed-off-by: JaiOCP <jai.kumar@broadcom.com>

CSIG TAM Attributes

Signed-off-by: JaiOCP <jai.kumar@broadcom.com>

CSIG Time Interval Unit

Signed-off-by: JaiOCP <jai.kumar@broadcom.com>

CSIG Document

Signed-off-by: JaiOCP <jai.kumar@broadcom.com>

CSIG Document

Signed-off-by: JaiOCP <jai.kumar@broadcom.com>

CSIG Document

Signed-off-by: JaiOCP <jai.kumar@broadcom.com>

Fix: "INVAILD" typo in enum '_sai_dash_flow_entry_bulk_get_session_filter_key_t' (opencomputeproject#2224)

This PR fixes a typo in the enum definition for dash_flow_entry_bulk_get_session_filter_key_t where the member INVAILD is corrected to INVALID.

Changes:

saitypesextensions.h: Renamed enum member INVAILD → INVALID.
Following will be pushed to DASH's repo once these SAI repo changes are merged.

dash_headers.p4: Renamed enum member INVAILD → INVALID.

Non UEC Member Agreement Form (opencomputeproject#2226)

Signed-off-by: JaiOCP <jai.kumar@broadcom.com>

Seamless BFD (S-BFD) (opencomputeproject#2220)

Signed-off-by: Jason Bos <jbos@cisco.com>

Replicate VXLAN UDP sport security to switch level (opencomputeproject#2195)

- Add SAI_SWITCH_TUNNEL_ATTR_VXLAN_UDP_SPORT_SECURITY attribute to drop tunnel packets with UDP source port outside allowed range
- Add documentation for UDP source port validation on VXLAN packet ingress
- Update both saiswitch.h and saitunnel.h with security clarifications

Signed-off-by: Marian Pritsak <marianp@mellanox.com>

SRv6 SID Marking (opencomputeproject#2222)

* SID Marking APIs

Signed-off-by: Jason Bos <jbos@cisco.com>

[DASH] Add flow bulk get session event data struct (opencomputeproject#2175)

* [DASH] Add flow bulk get session event data struct

Add flow bulk get event callback and supporting
structures to provide ability to query flows
in asynchronous manner.

Introducing SAI_PORT_ATTR_PORT_PG_PKT_DROP_STATUS (opencomputeproject#2234)

In this map, the key is the PG index and the status value (clear-on-read)
for each PG is from {0, 1}, where 0 indicates no drops were observed and 1
indicates packet drops.

Signed-off-by: Prasun Sinha <prasunsinha@google.com>

Add flow entry to the bulk session event data (opencomputeproject#2237)

Add the ability to query the flows with the
bulk get session event data callback.

The commit contains a fix for bad ordering of
classes generated by Thrift compiler for the nested
structures used in this callback.

Signed-off-by: Marian Pritsak <marianp@mellanox.com>
tjchadaga pushed a commit that referenced this pull request Jan 5, 2026
- Add SAI_SWITCH_TUNNEL_ATTR_VXLAN_UDP_SPORT_SECURITY attribute to drop tunnel packets with UDP source port outside allowed range
- Add documentation for UDP source port validation on VXLAN packet ingress
- Update both saiswitch.h and saitunnel.h with security clarifications

Signed-off-by: Marian Pritsak <marianp@mellanox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants