MSTP Traps for Control Packet

[ridahanif96]

This PR brings MSTP Trap for control packets. Modified saihostif.h for adding MSTP Trap

This is based on MSTP Support in SONIC

Signed-off-by: Rida Hanif [email protected]

[ridahanif96]

@rck-innovium Hi, this PR is created in reference to MSTP Traps. During the community review it was discussed that we don't need this trap as switch internal STP trap will be enough to handle control packet traps. Can you please help with this. Thanks.

[rlhui]

@rck-innovium Hi, this PR is created in reference to MSTP Traps. During the community review it was discussed that we don't need this trap as switch internal STP trap will be enough to handle control packet traps. Can you please help with this. Thanks.

Hi @ridahanif96 , what exact help is needed from @rck-innovium ? thanks.

[ridahanif96]

@rck-innovium Hi, this PR is created in reference to MSTP Traps. During the community review it was discussed that we don't need this trap as switch internal STP trap will be enough to handle control packet traps. Can you please help with this. Thanks.

Hi @ridahanif96 , what exact help is needed from @rck-innovium ? thanks.

Hi @rlhui , thanks for help.
Earlier, we purpose a separte trap for MSTP Control packet. Later, during HLD review @rck-innovium suggested that there is no need for this new trap.We can use SAI_HOSTIF_TRAP_TYPE_STP, as DMAC and LLC fields are identical for STP and MSTP. If we create a separate trap types for STP and MSTP , it would require the hardware to parse/match the BPDU protocol identifier.
We also agree with this, just created this PR for getting more suggestions from @rck-innovium so we can proceed further with our work as per suggestions/guidance.

[rck-innovium]

@ridahanif96 

Yes. We should be able to use the existing STP trap for STP, RSTP and MSTP.

Can you please explain about the other change in this PR about SAI_BRIDGE_PORT_TAGGING_MODE_HYBRID.

[ridahanif96]

@ridahanif96

Yes. We should be able to use the existing STP trap for STP, RSTP and MSTP.

Can you please explain about the other change in this PR about SAI_BRIDGE_PORT_TAGGING_MODE_HYBRID.

Thanks @rck-innovium , I will close this PR. The other change in this PR about SAI_BRIDGE_PORT_TAGGING_MODE_HYBRID is added by mistake with this PR. Actually we have another PR related to feature Switchport mode hybrid. In that PR we proposed a change in saibridge.h for bridge tagging mode hybrid to support both tagged and untagged traffic.

[ridahanif96]

It has been decided in SAI group call (08/24/23) that We should be able to use the existing STP trap for STP, RSTP and MSTP. Therefore changes proposed by this PR will not be required. As discussed in SAI call, this PR will be closed. Thanks!

[ridahanif96]

Closing PR!