Skip to content

SwitchPort Mode Hybrid support in saibridge.h file#1852

Closed
ridahanif96 wants to merge 3 commits intoopencomputeproject:masterfrom
ridahanif96:Mode-hybrid
Closed

SwitchPort Mode Hybrid support in saibridge.h file#1852
ridahanif96 wants to merge 3 commits intoopencomputeproject:masterfrom
ridahanif96:Mode-hybrid

Conversation

@ridahanif96
Copy link
Copy Markdown

@ridahanif96 ridahanif96 commented Aug 18, 2023

Currently, there are two tagging modes for a bridge port (untagged, tagged). A Hybrid Switchport Mode allows both untagged or tagged traffic which needs this hybrid bridge port tagging attribute.

This is in support of Hybrid Switchport Mode SONiC

Signed-off-by: Rida Hanif rida.hanif@xflowresearch.com

Signed-off-by: Rida Hanif <ridahanif958@gmail.com>
@ridahanif96 ridahanif96 changed the title DCO Error fixing PR SwitchPort Mode Hybrid support in saibridge.h file Aug 18, 2023
@ridahanif96 ridahanif96 marked this pull request as ready for review August 18, 2023 08:17
@ridahanif96
Copy link
Copy Markdown
Author

@kcudnik Hi, previous one was having issues, created this new PR. please review, thanks.

@rlhui
Copy link
Copy Markdown
Collaborator

rlhui commented Aug 18, 2023

@JaiOCP , would you like to review this? thanks

@ridahanif96
Copy link
Copy Markdown
Author

@JaiOCP , would you like to review this? thanks

Hi Jai ,

This change is proposed to support hybrid port mode in SONIC. Currently we have only two bridge tagging attribute (untagged,tagged). We proposed a new attribute hybrid, which will pass both tagged and untagged traffic. Can you please guide in this, Thanks.

ridahanif96 and others added 2 commits August 24, 2023 19:08
Signed-off-by: Rida Hanif <ridahanif958@gmail.com>
@ridahanif96
Copy link
Copy Markdown
Author

This PR suggests a change in saibridge.h. This change has been discussed in SAI community call (08/24/23) and it was decided that this proposed change is not requried for switchport mode hybrid. Hybrid port use case if required can be done using ACL as per suggestion. Based on these discussion this proposed change in PR is no longer requrired therefore closing this PR. Thanks!

@ridahanif96 ridahanif96 closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants