Saithriftv2 check null sai apis#1536
Closed
chrispsommers wants to merge 38 commits intoopencomputeproject:masterfrom
Closed
Saithriftv2 check null sai apis#1536chrispsommers wants to merge 38 commits intoopencomputeproject:masterfrom
chrispsommers wants to merge 38 commits intoopencomputeproject:masterfrom
Conversation
…1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <[email protected]>
…file or meta/Makefile Signed-off-by: Chris Sommers <[email protected]>
… SAI extensions. Signed-off-by: Chris Sommers <[email protected]>
…kage of saiserver, so user can pass in additional libraries. Signed-off-by: Chris Sommers <[email protected]>
Signed-off-by: Chris Sommers <[email protected]>
Signed-off-by: Chris Sommers <[email protected]>
* Add VLAN and PortChannel test plan
For vlan, it includes:
1. Vlan functionalities
- Flooding
- Forwarding
- Trunk/Access
- Tagging/Untagging(802.1Q)
- VLAN interface (RIF/SVI)
2. SAI APIs operations
- Vlan Counters
- Vlan and member list operations
For PortChannel, it includes:
1. Lag functionalities
- Loadbalance
2. Lag SAI APIs
- create/check/remove lag and lag member
Signed-off-by: richardyu-ms <[email protected]>
* Update lag_test_plan.md
Signed-off-by: richardyu-ms <[email protected]>
* Update lag_test_plan.md
Signed-off-by: richardyu-ms <[email protected]>
* remove cases not related to T0
Signed-off-by: richardyu-ms <[email protected]>
* Update lag_test_plan.md
Signed-off-by: richardyu-ms <[email protected]>
* Add VLAN and Lag test plan and put topo config in seperated files
Signed-off-by: richardyu <[email protected]>
* fix typo and more description more clear
Signed-off-by: richardyu-ms <[email protected]>
* fix lag test typo (opencomputeproject#29)
Signed-off-by: zhoudongxu <[email protected]>
* refactor vlan test plan and config
Signed-off-by: richardyu-ms <[email protected]>
* refactor lag test plan (opencomputeproject#33)
Signed-off-by: zhoudongxu <[email protected]>
* refactor pc and vlan test
Signed-off-by: zhoudongxu <[email protected]>
* Improve pc and vlan test Doc (opencomputeproject#35)
* fix typo
Signed-off-by: zhoudongxu <[email protected]>
* remove some unnecessary comments
Signed-off-by: zhoudongxu <[email protected]>
* reformat and adjust the description of the tests
Signed-off-by: richardyu-ms <[email protected]>
* set hash algorithm (opencomputeproject#36)
Signed-off-by: zhoudongxu <[email protected]>
* refine lag test (opencomputeproject#37)
Signed-off-by: zhoudongxu <[email protected]>
* correct vlan interface test (opencomputeproject#38)
Signed-off-by: zhoudongxu <[email protected]>
* workaround for the sequence number issue in github and correct typo
standardise the ip and mac naming in config
add lag test for ingress port indifferenate in lag hash
redesign the mac and ip namin convention and reformat
Signed-off-by: richardyu-ms <[email protected]>
* adjust the case numbers and vlan id
Signed-off-by: richardyu-ms <[email protected]>
Co-authored-by: zhoudongxu <[email protected]>
Co-authored-by: richardyu <[email protected]>
Co-authored-by: zhoudongxu <[email protected]>
Signed-off-by: Chris Sommers <[email protected]>
opencomputeproject#1499) * [SAI-PTF] Add SAI ptf test structure for T0 test Create SAI PTF test structure for T0 1. Create configuration structure for different components configu 2. Add FDB, PORT, switch, vlan configurations 3. Create Test structure base on PTF 4. Add T0 test case samples for FDB Test Done: Checked the ports functionality with port flooding Checked port forwarding base on FDB configurations Signed-off-by: richardyu-ms <[email protected]> * add vlan config and vlan test sample case Signed-off-by: richardyu-ms <[email protected]> * add dx010 config Signed-off-by: richardyu-ms <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
Signed-off-by: Chris Sommers <[email protected]>
Signed-off-by: Yang Wang <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
…ct#1504) * Bulk support for Neighbor entries Signed-off-by: Chris Sommers <[email protected]>
Signed-off-by: Yang Wang <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
…rt added earlier for Route counters. (opencomputeproject#1497) Support counters on IP MC route entries. This is similar to the support added earlier for Route counters. API sequence: sai_attribute_t counter_attr; attr.id = SAI_COUNTER_ATTR_TYPE; attr.value.s32 = SAI_COUNTER_TYPE_REGULAR; sai_object_id_t counter_id; sai_status_t rc = sai_counter_api->create_counter(&counter_id, g_switch_id, 1, &attr); sai_attribute_t ipmc_attr; attr.id = SAI_IPMC_ENTRY_ATTR_COUNTER_ID; attr.value.oid = counter_id; rc = sai_ipmc_api->set_ipmc_entry_attribute(route_entry, ipmc_attr); sai_stat_id_t stat_ids[] = { SAI_COUNTER_STAT_PACKETS, SAI_COUNTER_STAT_BYTES }; uint64_t stats[2]; rc = sai_counter_api->sai_get_counter_stats_ext(counter_id, 2, stat_ids, stats); Signed-off-by: rck-innovium <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
…oject#1484) saithriftv1 offers start_sai_thrift_rpc_server API to start the saithrift server and syncd is currently using that API https://github.com/Azure/sonic-sairedis/blob/master/syncd/syncd_main.cpp#L60 But this API is missing from the for saithriftv2. Made the relevant changes to provide a similar API for saithriftv2 library The start_sai_thrift_rpc_server API currently resides in saiserver.cpp which is not included in librpcserver.a and is not available for the users of the static library. Thus moved the function definition into sai_rpc_frontend.cpp for including it in the static library. Signed-off-by: Vivek Reddy Karri <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
Signed-off-by: ms-junyi <[email protected]> add vlan test case edit FilteringTest Signed-off-by: ms-junyi <[email protected]> edit vlan test case Signed-off-by: ms-junyi <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
* add more waiting time for test Signed-off-by: richardyu-ms <[email protected]> * Update fdb_configer.py increase the waiting time for fdb entries update Signed-off-by: richardyu-ms <[email protected]> * remove useless change Signed-off-by: richardyu-ms <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
Signed-off-by: ms-junyi <[email protected]> format Signed-off-by: ms-junyi <[email protected]> addomment for each function Signed-off-by: ms-junyi <[email protected]> add comment for each function Signed-off-by: ms-junyi <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
In order to set up the port on different platforms, need to read the data for port configuration when turning on the admin state This PR is a bug fix for adding the config_db into test resources folder. Test Done: Test within SONiC mgmt container Signed-off-by: richardyu-ms <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
* add lag config Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * enable lag config in test base Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * fix lag config Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * add remove_lag_member in lag_configer Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * add sai_ipprefix() in utils Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * fix typo Signed-off-by: zitingguo <[email protected]> * import LagConfiger in sai_test_base Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * add a simple lag test Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * fix typo Signed-off-by: zitingguo <[email protected]> * fix a config error in lag Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * add lag lb test based on scr port Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * fix Signed-off-by: zitingguo <[email protected]> * set lag v4 hash Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * add lag disable egress test case Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * add IndifferenceIngressPortTest Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * fix set hash function Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * separate route configuration from lag Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * disable setting lag hash Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * add virtual interface Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * Config default v4&v6 route Signed-off-by: zitingguo <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
…#1521) * add read config_db.json Signed-off-by: ms-junyi <[email protected]> format Signed-off-by: ms-junyi <[email protected]> addomment for each function Signed-off-by: ms-junyi <[email protected]> add comment for each function Signed-off-by: ms-junyi <[email protected]> * tear down Signed-off-by: ms-junyi <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
…roject#1492) Fixes opencomputeproject#1490 Co-authored-by: Chris Sommers <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
Attribute is introduced to configure IPFIX template reporting interval as per the RFC7011. https://datatracker.ietf.org/doc/html/rfc7011#section-8.4 Signed-off-by: Jai Kumar <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
Signed-off-by: Chris Sommers <[email protected]>
Signed-off-by: Chris Sommers <[email protected]>
da35b21 to
38d15a8
Compare
…hanges were not necessary if all extension headers are copied into /usr/include/sai at build time.
Collaborator
|
please resolve the merge conflict |
* Add bulk create and remove for tunnel * Fix api order Signed-off-by: Chris Sommers <[email protected]>
* add fdb test Signed-off-by: richardyu-ms <[email protected]> * add more comment, debugging and submit bug base on test result, add more method to clear the environment Signed-off-by: richardyu-ms <[email protected]> * refactor code, add fdb test cases and restore steps Signed-off-by: richardyu-ms <[email protected]> * reformat code, add comment and remove unnessary import Signed-off-by: richardyu-ms <[email protected]> * reformat code Signed-off-by: richardyu-ms <[email protected]> * change the doc Signed-off-by: richardyu-ms <[email protected]> * add comment for failed cases Signed-off-by: richardyu-ms <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
* Build saithrift with python3.9 in bullseye Bullseye upgrade the python to python3.9 and other image, like buster still using python 2.7. To build with different python in different image, add a condition for copy differernt install file in different type of image. Signed-off-by: richardyu-ms <[email protected]> * change the release name to version number and reuse existing files Signed-off-by: richardyu-ms <[email protected]> Co-authored-by: richardyu <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
* Create SAI_PTF_user-guide.md SAI-PTF-V2 User Guide has details on how a user can build the SAI Thrift server and integrate it with their own specific libsai Signed-off-by: Reshma Sudarshan <[email protected]> * Create readme.md Signed-off-by: Reshma Sudarshan <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
opencomputeproject#1514) * [doc] Add SAI metadata introduction presentation (opencomputeproject#1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <[email protected]> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Makefile or meta/Makefile Signed-off-by: Chris Sommers <[email protected]> Co-authored-by: Kamil Cudnik <[email protected]> Co-authored-by: Chris Sommers <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
…pencomputeproject#1546) * move the mac generate method to util Signed-off-by: richardyu-ms <[email protected]> * [SAI Test] Add Mac generate method and retry when turnning up port Add mac method for generating MAC address Retry when tunning up ports Test done: Test on DUT Signed-off-by: richardyu-ms <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
…eproject#1524) * [Test Plan] SAI test plan for tunnel QoS remapping (pcbb) Add sai test plan for tunnel QoS remapping (pcbb) Signed-off-by: richardyu-ms <[email protected]> * fix typo and correct gramma Signed-off-by: richardyu-ms <[email protected]> * specify the condition for ECN testing Signed-off-by: richardyu-ms <[email protected]> * add dscp table with 63 values, add global config, add priority check attribute, add pfc check details, add test obj Signed-off-by: richardyu-ms <[email protected]> * Change test description for global_dscp_remap Signed-off-by: richardyu-ms <[email protected]> * change the decription Signed-off-by: richardyu-ms <[email protected]> * reformat the doc Signed-off-by: richardyu-ms <[email protected]> * correct the description base on the comment in the PR Signed-off-by: richardyu-ms <[email protected]> * add pcbb config Signed-off-by: richardyu-ms <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
* add lag cases Signed-off-by: ms-junyi <[email protected]> * put locol cofig from router_configer to lag case Signed-off-by: ms-junyi <[email protected]> * fix bug Signed-off-by: ms-junyi <[email protected]> * edit pydoc Signed-off-by: ms-junyi <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
…#1553) * config lag according to new config Signed-off-by: zitingguo <[email protected]> Signed-off-by: zitingguo-ms <[email protected]> * Add port1 route interface into default route config Signed-off-by: zitingguo-ms <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
This change includes support for reading the following PHY layer diagnostics in SAI - Per PMD Lane Rx Signal Detect Per PMD Lane Rx Lock Status (aka CDR status) PCS Rx Link Status Per FEC Lane Alignment Marker Lock Signed-off-by: Chris Sommers <[email protected]>
* [doc] Add SAI metadata introduction presentation (opencomputeproject#1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <[email protected]> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Makefile or meta/Makefile Signed-off-by: Chris Sommers <[email protected]> * Add static_cast<> to sairpcgen templates to avoid type mismatches for SAI extensions. Signed-off-by: Chris Sommers <[email protected]> * Add new env variable SAIRPC_EXTRA_LIBS which gets passed to final linkage of saiserver, so user can pass in additional libraries. Signed-off-by: Chris Sommers <[email protected]> * Add experimental to include path. Signed-off-by: Chris Sommers <[email protected]> * Add experimental headers to CPPFLAGS passed to ctypesgen. Signed-off-by: Chris Sommers <[email protected]> * Add VLAN and PortChannel test plan (opencomputeproject#1480) * Add VLAN and PortChannel test plan For vlan, it includes: 1. Vlan functionalities - Flooding - Forwarding - Trunk/Access - Tagging/Untagging(802.1Q) - VLAN interface (RIF/SVI) 2. SAI APIs operations - Vlan Counters - Vlan and member list operations For PortChannel, it includes: 1. Lag functionalities - Loadbalance 2. Lag SAI APIs - create/check/remove lag and lag member Signed-off-by: richardyu-ms <[email protected]> * Update lag_test_plan.md Signed-off-by: richardyu-ms <[email protected]> * Update lag_test_plan.md Signed-off-by: richardyu-ms <[email protected]> * remove cases not related to T0 Signed-off-by: richardyu-ms <[email protected]> * Update lag_test_plan.md Signed-off-by: richardyu-ms <[email protected]> * Add VLAN and Lag test plan and put topo config in seperated files Signed-off-by: richardyu <[email protected]> * fix typo and more description more clear Signed-off-by: richardyu-ms <[email protected]> * fix lag test typo (opencomputeproject#29) Signed-off-by: zhoudongxu <[email protected]> * refactor vlan test plan and config Signed-off-by: richardyu-ms <[email protected]> * refactor lag test plan (opencomputeproject#33) Signed-off-by: zhoudongxu <[email protected]> * refactor pc and vlan test Signed-off-by: zhoudongxu <[email protected]> * Improve pc and vlan test Doc (opencomputeproject#35) * fix typo Signed-off-by: zhoudongxu <[email protected]> * remove some unnecessary comments Signed-off-by: zhoudongxu <[email protected]> * reformat and adjust the description of the tests Signed-off-by: richardyu-ms <[email protected]> * set hash algorithm (opencomputeproject#36) Signed-off-by: zhoudongxu <[email protected]> * refine lag test (opencomputeproject#37) Signed-off-by: zhoudongxu <[email protected]> * correct vlan interface test (opencomputeproject#38) Signed-off-by: zhoudongxu <[email protected]> * workaround for the sequence number issue in github and correct typo standardise the ip and mac naming in config add lag test for ingress port indifferenate in lag hash redesign the mac and ip namin convention and reformat Signed-off-by: richardyu-ms <[email protected]> * adjust the case numbers and vlan id Signed-off-by: richardyu-ms <[email protected]> Co-authored-by: zhoudongxu <[email protected]> Co-authored-by: richardyu <[email protected]> Co-authored-by: zhoudongxu <[email protected]> Signed-off-by: Chris Sommers <[email protected]> * [SAI-PTF] SAI PTF test structure for T0 test and VLAN,FDB sample cases (opencomputeproject#1499) * [SAI-PTF] Add SAI ptf test structure for T0 test Create SAI PTF test structure for T0 1. Create configuration structure for different components configu 2. Add FDB, PORT, switch, vlan configurations 3. Create Test structure base on PTF 4. Add T0 test case samples for FDB Test Done: Checked the ports functionality with port flooding Checked port forwarding base on FDB configurations Signed-off-by: richardyu-ms <[email protected]> * add vlan config and vlan test sample case Signed-off-by: richardyu-ms <[email protected]> * add dx010 config Signed-off-by: richardyu-ms <[email protected]> Signed-off-by: Chris Sommers <[email protected]> * [meta] Add sai_status_t to ancestry check (opencomputeproject#1501) Signed-off-by: Chris Sommers <[email protected]> * reset sleep time during turning up ports (opencomputeproject#1502) Signed-off-by: Yang Wang <[email protected]> Signed-off-by: Chris Sommers <[email protected]> * [saineighbor] Bulk API support for Neighbor entries (opencomputeproject#1504) * Bulk support for Neighbor entries Signed-off-by: Chris Sommers <[email protected]> * add vlan testcases from Group6 to Group10 (opencomputeproject#1506) Signed-off-by: Yang Wang <[email protected]> Signed-off-by: Chris Sommers <[email protected]> * Support counters on IP MC route entries. This is similar to the support added earlier for Route counters. (opencomputeproject#1497) Support counters on IP MC route entries. This is similar to the support added earlier for Route counters. API sequence: sai_attribute_t counter_attr; attr.id = SAI_COUNTER_ATTR_TYPE; attr.value.s32 = SAI_COUNTER_TYPE_REGULAR; sai_object_id_t counter_id; sai_status_t rc = sai_counter_api->create_counter(&counter_id, g_switch_id, 1, &attr); sai_attribute_t ipmc_attr; attr.id = SAI_IPMC_ENTRY_ATTR_COUNTER_ID; attr.value.oid = counter_id; rc = sai_ipmc_api->set_ipmc_entry_attribute(route_entry, ipmc_attr); sai_stat_id_t stat_ids[] = { SAI_COUNTER_STAT_PACKETS, SAI_COUNTER_STAT_BYTES }; uint64_t stats[2]; rc = sai_counter_api->sai_get_counter_stats_ext(counter_id, 2, stat_ids, stats); Signed-off-by: rck-innovium <[email protected]> Signed-off-by: Chris Sommers <[email protected]> * Add thr missing API into saithriftv2 missing for syncd (opencomputeproject#1484) saithriftv1 offers start_sai_thrift_rpc_server API to start the saithrift server and syncd is currently using that API https://github.com/Azure/sonic-sairedis/blob/master/syncd/syncd_main.cpp#L60 But this API is missing from the for saithriftv2. Made the relevant changes to provide a similar API for saithriftv2 library The start_sai_thrift_rpc_server API currently resides in saiserver.cpp which is not included in librpcserver.a and is not available for the users of the static library. Thus moved the function definition into sai_rpc_frontend.cpp for including it in the static library. Signed-off-by: Vivek Reddy Karri <[email protected]> Signed-off-by: Chris Sommers <[email protected]> * add vlan test case (opencomputeproject#1510) Signed-off-by: ms-junyi <[email protected]> add vlan test case edit FilteringTest Signed-off-by: ms-junyi <[email protected]> edit vlan test case Signed-off-by: ms-junyi <[email protected]> Signed-off-by: Chris Sommers <[email protected]> * add more waiting time for test (opencomputeproject#1511) * add more waiting time for test Signed-off-by: richardyu-ms <[email protected]> * Update fdb_configer.py increase the waiting time for fdb entries update Signed-off-by: richardyu-ms <[email protected]> * remove useless change Signed-off-by: richardyu-ms <[email protected]> Signed-off-by: Chris Sommers <[email protected]> * add read config_db.json (opencomputeproject#1519) Signed-off-by: ms-junyi <[email protected]> format Signed-off-by: ms-junyi <[email protected]> addomment for each function Signed-off-by: ms-junyi <[email protected]> add comment for each function Signed-off-by: ms-junyi <[email protected]> Signed-off-by: Chris Sommers <[email protected]> * [Fix]Add necessary test data file for sai test (opencomputeproject#1520) In order to set up the port on different platforms, need to read the data for port configuration when turning on the admin state This PR is a bug fix for adding the config_db into test resources folder. Test Done: Test within SONiC mgmt container Signed-off-by: richardyu-ms <[email protected]> Signed-off-by: Chris Sommers <[email protected]> * Zitingguo/add lag test (opencomputeproject#1522) * add lag config Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * enable lag config in test base Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * fix lag config Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * add remove_lag_member in lag_configer Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * add sai_ipprefix() in utils Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * fix typo Signed-off-by: zitingguo <[email protected]> * import LagConfiger in sai_test_base Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * add a simple lag test Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * fix typo Signed-off-by: zitingguo <[email protected]> * fix a config error in lag Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * add lag lb test based on scr port Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * fix Signed-off-by: zitingguo <[email protected]> * set lag v4 hash Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * add lag disable egress test case Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * add IndifferenceIngressPortTest Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * fix set hash function Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * separate route configuration from lag Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * disable setting lag hash Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * add virtual interface Signed-off-by: Ziting Guo <[email protected]> Signed-off-by: zitingguo <[email protected]> * Config default v4&v6 route Signed-off-by: zitingguo <[email protected]> Signed-off-by: Chris Sommers <[email protected]> * add teardown for testing multiple cases at a time (opencomputeproject#1521) * add read config_db.json Signed-off-by: ms-junyi <[email protected]> format Signed-off-by: ms-junyi <[email protected]> addomment for each function Signed-off-by: ms-junyi <[email protected]> add comment for each function Signed-off-by: ms-junyi <[email protected]> * tear down Signed-off-by: ms-junyi <[email protected]> Signed-off-by: Chris Sommers <[email protected]> * Added missing dependencies required to run gensairpc.pl (opencomputeproject#1492) Fixes opencomputeproject#1490 Co-authored-by: Chris Sommers <[email protected]> Signed-off-by: Chris Sommers <[email protected]> * Update saitam.h (opencomputeproject#1496) Attribute is introduced to configure IPFIX template reporting interval as per the RFC7011. https://datatracker.ietf.org/doc/html/rfc7011#section-8.4 Signed-off-by: Jai Kumar <[email protected]> Signed-off-by: Chris Sommers <[email protected]> * Pass SAIRPC_EXTRA_LIBS flag in Makefile Signed-off-by: Chris Sommers <[email protected]> * Removed changes to include paths for SAI extension headers; as it turns out these changes were not required as originally reported in opencomputeproject#1531. Signed-off-by: Chris Sommers <[email protected]> Co-authored-by: Kamil Cudnik <[email protected]> Co-authored-by: Chris Sommers <[email protected]> Co-authored-by: Richard.Yu <[email protected]> Co-authored-by: zhoudongxu <[email protected]> Co-authored-by: richardyu <[email protected]> Co-authored-by: zhoudongxu <[email protected]> Co-authored-by: Yang Wang <[email protected]> Co-authored-by: Prince Sunny <[email protected]> Co-authored-by: Ravindranath C K <[email protected]> Co-authored-by: Vivek R <[email protected]> Co-authored-by: ms-junyi <[email protected]> Co-authored-by: zitingguo-ms <[email protected]> Co-authored-by: Jai Kumar <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
…eproject#1552) In Syncd starting process, it will try to start the switch and assign the gSwtichId to the sai implementation. In the syncd rpc container, in order to get the swtich id after syncd initalization, we need to get and check the switch id. Signed-off-by: richardyu-ms <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
Contributor
Author
|
Superceded by #1558, this PR had rebasing artifacts and was not clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1535. I modified the code-generator template to check for null SAI function pointers before calling, and throwing an exception with helpful message on the console.
The changed file of interest is actually just
meta/templates/sai_rpc_server_functions.tt. There are more files in the change list because this PR includes changes from unmerged #1514 and #1533Example console trace when calling
switch_api->get_switch_attribute()which isn't implemented and has a null pointer. The process does not crash anymore.To understand how this works, the template inserts the following code (as an example) automatically:
right before making any API call such as: