Sai ptf server v2 user guide#1512
Conversation
|
LGTM, I was able to execute these instructions. If #1514 gets merged, the instructions should be updated to show how to pass option flags. If this gets merged first, I can add that to https://github.com/opencomputeproject/SAI/pull/1514as well (i.e. update this README). |
|
Hi @reshmaintel you need to rebase and signoff for the DCO to pass, instructions for this are here: https://github.com/opencomputeproject/SAI/pull/1512/checks?check_run_id=7046496912 (I did same on my #1514 and had to fix, oops) |
|
#1514 LGTM, so once DCO is fixed, it is good to go. @chrispsommers don't you mind to update the user guide as separate PR once the #1514 is merged ? |
SAI-PTF-V2 User Guide has details on how a user can build the SAI Thrift server and integrate it with their own specific libsai Signed-off-by: Reshma Sudarshan <[email protected]>
Signed-off-by: Reshma Sudarshan <[email protected]>
reshmaintel
force-pushed
the
sai-ptf-user-guide
branch
from
088627d to
42611d5
Compare
| pip install ctypesgen | ||
| ``` | ||
|
|
||
| Apache thrift 0.11.0 |
There was a problem hiding this comment.
sonic-net/sonic-buildimage#9884
it should be able to build it with thrift 0.14.0?
There was a problem hiding this comment.
@richardyu-ms yes, the saithrift can be built with thrift 0.14.1 also. Verified already. Once this PR is merged, I will update the doc with thrift 0.14 info included.
richardyu-ms
left a comment
richardyu-ms
left a comment
There was a problem hiding this comment.
Besides the thrift version, others are LGTM. Thanks for this useful doc!
* Create SAI_PTF_user-guide.md SAI-PTF-V2 User Guide has details on how a user can build the SAI Thrift server and integrate it with their own specific libsai Signed-off-by: Reshma Sudarshan <[email protected]> * Create readme.md Signed-off-by: Reshma Sudarshan <[email protected]> Signed-off-by: Chris Sommers <[email protected]>
4 participants
User Guide for SAI thrift server. Adds info on how a user can generate automated test framework and integrate it with the user libsai.