Distributed HW resource management infrastructure

[JaiOCP]

This PR introduces an infrastructure to be able to query the HW resource for its ingress, egress or both stages i.e. that if physical resource belongs to ingress pipeline, egress pipeline or is a shared resource across ingress/egress stages of pipeline.

Additionally hostif trap group and policer pool object is enhancement with an attribute to specific which stage of the pipeline trap group and/or policer pool belongs.

For details and sample workflow please refer to the spec.

[JaiOCP]

@rck-innovium @marian-pritsak @rlhui @ravi861 I have to create a new PR as the old branch was corrupted because of enum values changes and squash was not able to recover it.

[rlhui]

@abdosi - would we please help review? Thanks.

[JaiOCP]

I will fix this. There is no constraint from tooling or SAI spec but you are correct, create does not have same attribute id present multiple times in the same create API.

…

On Wed, Jul 27, 2022 at 11:16 PM Ravindranath C K ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In doc/SAI-Proposal-HW-Resource.md <#1528 (comment)> : > + 3, + trap_group_attrs); + +4. Create hostif trap for ingress stage + sai_object_id_t trap_id; + sai_attribute_t trap_attrs[3]; + + trap_attrs[0].id = + (sai_attr_id_t) SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE; + trap_attrs[0].value = + SAI_HOSTIF_TRAP_TYPE_DNAT_MISS; + + trap_attrs[1].id = + (sai_attr_id_t) SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE; + trap_attrs[1].value = + SAI_HOSTIF_TRAP_TYPE_NAT_HAIRPIN; We cannot use the same attribute-id twice for a given create API call. Please remove lines 162 to 165 — Reply to this email directly, view it on GitHub <#1528 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKCSHLM65XN26OEVX7IX673VWIQTDANCNFSM53ITLHFQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.

[JaiOCP]

@gechiang @rck-innovium All the comments are taken care off. Please approve

[JaiOCP]

Hi Ravi, There is no constraint from the SAI spec perspective but we do not provide the same attribute id in the create call in current SAI implementation. As far as the query is concerned, it is for a specific attribute id value. Attribute in itself is not very useful and similarly querying at the object level is not useful either. We want granularity at each attribute id and its value.

…

-Jai

On Wed, Jul 27, 2022 at 11:15 PM Ravindranath C K ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In doc/SAI-Proposal-HW-Resource.md <#1528 (comment)> : > +- SAI_OBJECT_STAGE_BOTH: + Resource is a common shared resource between ingress and egress HW pipeline +- SAI_OBJECT_STAGE_INGRESS: + Resource belongs to ingress stage of HW pipeline +- SAI_OBJECT_STAGE_EGRESS: + Resource belongs to egress stage of HW pipeline + +## Capability Query +---------------- +New query API is introduced for an attribute's stage. NOS can query the stage of an object's attribute for a given HW support. One of the following stage is returned as part the API +- SAI_ATTR_STAGE_NA: Stage is not applicable +- SAI_ATTR_STAGE_BOTH: Attribute is common to ingress and egress stage +- SAI_ATTR_STAGE_INGRESS: Attribute is applicable only to ingress stage +- SAI_ATTR_STAGE_EGRESS: Attribute is applicabe only to egress stage + +Length of the returned array "stage" is attr_count. Caller must provide the buffer for array "stage". Jai, Can we discuss this in the upcoming call? The confusion is can the attribute_id be passed multiple times with difference values in a single call to sai_query_object_stage(). The workflow example does this but it looks a little confusing. The intent of passing an array of sai_attribute_t to the API was since the called would not know which attribute-id decides the stage for a given vendor... — Reply to this email directly, view it on GitHub <#1528 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKCSHLJRAT7OAUTACWZQUNLVWIQPZANCNFSM53ITLHFQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.