Skip to content

Add fabric port isolation attribute #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rlhui merged 6 commits into from
Sep 19, 2022
Merged

Add fabric port isolation attribute #1498

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
27fe9f2
Add fabric port isolation attribute
jfeng-arista Jun 17, 2022
68650d4
Update discription of SAI_PORT_ATTR_FABRIC_ISOLATE
jfeng-arista Jul 9, 2022
f5d5e9d
Update description.
jfeng-arista Jul 11, 2022
e9e9768
Add condition for fabric port isolation
jfeng-arista Jul 18, 2022
990ce4c
Add condition tag for fabric port isolation
jfeng-arista Jul 18, 2022
6e067bc
remove the condition for fabric port isolation api
jfeng-arista Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions inc/saiport.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2136,6 +2136,21 @@ typedef enum _sai_port_attr_t
*/
SAI_PORT_ATTR_FEC_ALIGNMENT_LOCK,

/**
* @brief Fabric port isolation setting.
*
* true: The link may be enabled in serdes level and the
* MAC level, but the link partner will not use
* it for traffic distribution.
* false: Undo the isolation operation.
* This attribute is for fabric links only.
Copy link
Copy Markdown
Collaborator

@abdosi abdosi Jul 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add something like this in the comment section.
Refer sairouterinterface.h

@condition SAI_PORT_ATTR_TYPE == SAI_PORT_TYPE_FABRIC

Copy link
Copy Markdown
Contributor Author

@jfeng-arista jfeng-arista Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

SAI_PORT_ATTR_TYPE is a read only attribute , and as far as I know that @condition not works for read only attribute. So checking with you again about if we need to make this change ?

thank you

Jie

Copy link
Copy Markdown
Contributor Author

@jfeng-arista jfeng-arista Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried add the @condition, and the metadata check failed,

it looks like based on the following 3 checks, we can not use @condition check for read only attribute. thank you

SAI/meta/saisanitycheck.c

Line 1284 in f69394f

switch ((int)md->flags)

SAI/meta/saisanitycheck.c

Line 1455 in f69394f

switch ((int)md->flags)

SAI/meta/saisanitycheck.c

Line 1489 in f69394f

META_MD_ASSERT_FAIL(md, "read only attribute can't be valid only");

*
* @type bool
* @flags CREATE_AND_SET
* @default false
*/
SAI_PORT_ATTR_FABRIC_ISOLATE,

/**
* @brief End of attributes
*/
Expand Down