Add fabric port isolation attribute#1498
Conversation
jfeng-arista
force-pushed
the
add_fabric_port_isolation_api
branch
from
45afea2 to
74a6a05
Compare
|
WARNING: line ends in whitespace saiport.h 1888: * @brief Fabric port isolation setting |
jfeng-arista
force-pushed
the
add_fabric_port_isolation_api
branch
from
d8646a9 to
cffac35
Compare
|
still some issues with build, please fix |
jfeng-arista
force-pushed
the
add_fabric_port_isolation_api
branch
2 times, most recently
from
ff38010 to
7f85b00
Compare
jfeng-arista
force-pushed
the
add_fabric_port_isolation_api
branch
2 times, most recently
from
c1a76a7 to
457edbf
Compare
| * MAC level, but the link partner will not use | ||
| * it for traffic distribution. | ||
| * false: Undo the isolation operation. | ||
| * This attribute is for fabric links only. |
There was a problem hiding this comment.
can we add something like this in the comment section.
Refer sairouterinterface.h
@condition SAI_PORT_ATTR_TYPE == SAI_PORT_TYPE_FABRIC
There was a problem hiding this comment.
Hi,
SAI_PORT_ATTR_TYPE is a read only attribute , and as far as I know that @condition not works for read only attribute. So checking with you again about if we need to make this change ?
thank you
Jie
There was a problem hiding this comment.
I tried add the @condition, and the metadata check failed,
it looks like based on the following 3 checks, we can not use @condition check for read only attribute. thank you
Line 1284 in f69394f
Line 1455 in f69394f
Line 1489 in f69394f
abdosi
left a comment
abdosi
left a comment
There was a problem hiding this comment.
please check above comment.
jfeng-arista
force-pushed
the
add_fabric_port_isolation_api
branch
3 times, most recently
from
7dc052f to
1c3ecd5
Compare
inc/saiport.h
Outdated
| * @type bool | ||
| * @flags CREATE_AND_SET | ||
| * @default false | ||
| */ |
There was a problem hiding this comment.
Add a comment that this attribute is valid only for
SAI_PORT_ATTR_TYPE == SAI_PORT_TYPE_FABRIC
@kcudnik
I believe since SAI_PORT_ATTR_TYPE is a read only attribute, tooling will now allow validonly check.
There was a problem hiding this comment.
@kcudnik I agree, thats why request for adding a text to clarify the intent
|
@jfeng-arista - would you please resolve conflicts? |
jfeng-arista
force-pushed
the
add_fabric_port_isolation_api
branch
from
8db00a4 to
1c3ecd5
Compare
|
/azpw run |
|
Hi, |
jfeng-arista
force-pushed
the
add_fabric_port_isolation_api
branch
from
94abf9f to
a5e365a
Compare
Signed-off-by: Jie Feng <[email protected]> remove extra line end space. Signed-off-by: Jie Feng <[email protected]> Move the new attribute to the end of the list Signed-off-by: Jie Feng <[email protected]>
Signed-off-by: Jie Feng <[email protected]>
Signed-off-by: Jie Feng <[email protected]>
Signed-off-by: Jie Feng <[email protected]>
Signed-off-by: Jie Feng <[email protected]>
Signed-off-by: Jie Feng <[email protected]>
jfeng-arista
force-pushed
the
add_fabric_port_isolation_api
branch
from
a5e365a to
6e067bc
Compare
|
thank you !
…On Mon, Sep 19, 2022 at 2:43 PM rlhui ***@***.***> wrote:
Merged #1498 <#1498> into
master.
—
Reply to this email directly, view it on GitHub
<#1498 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXO4THROHZXCIH4YQSCX4GDV7DNBTANCNFSM5ZDEIMXQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
7 participants
Add fabric port isolation attribute