Add Thrift 0.14.1 compatibility#1403
Merged
richardyu-ms merged 1 commit intoopencomputeproject:masterfrom Feb 18, 2022
Merged
Conversation
5 tasks
Signed-off-by: Myron Sosyak <myronx.sosyak@intel.com>
Contributor
Author
|
@richardyu-ms @kcudnik Please review |
richardyu-ms
reviewed
Feb 8, 2022
6 tasks
richardyu-ms
approved these changes
Feb 9, 2022
Megathrone
approved these changes
Feb 9, 2022
RyoYang
approved these changes
Feb 9, 2022
Contributor
Author
|
@richardyu-ms Could we merge this? |
msosyak
pushed a commit
to msosyak/SAI
that referenced
this pull request
Feb 18, 2022
Signed-off-by: Myron Sosyak <myronx.sosyak@intel.com>
richardyu-ms
pushed a commit
that referenced
this pull request
Feb 23, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make saithrift compatible with thrift 0.14.1
How I did it:
unionbystructin *.thrift files as saithrift code relays on an old thrift bug which was fixed in thrift 0.11.0. Due to that BUGuniosbehaves asstruct. In SONiC there is patch to revert the fix in 0.11.0 .shared_ptrbased on thrift version. In Thrift 0.11.0 theboost::shared_ptris usually used. But star from 0.13.0 the boost dependency was dropped in Thrift.Verified these changes in SONIC build env with different thrift version: