Conversation
7daa75e to
a4a59f9
Compare
nornagon-openai
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This is the
exec-serverfollow-up to theshell-escalationAPI prep in #12614, split out of PR #12584 to keep review scope smaller.Separating the
exec-serveradoption from thecorezsh-fork migration makes it easier to review the adapter wiring and confirm this remains behavior-preserving.What Changed
exec-serverimports to the newcodex_shell_escalation::unix::*module layout.McpShellCommandExecutorinexec-server/src/unix/mcp.rsto implementshell-escalation's newShellCommandExecutortrait by delegating tocodex_core::exec::process_exec_tool_call.codex_core::SandboxStateintoshell-escalation's crate-localSandboxStatebefore invokingrun_escalate_server.exec-server/src/unix.rs.tokio-utildependency/lockfile wiring forCancellationTokenuse in the adapter.Verification
Stack created with Sapling. Best reviewed with ReviewStack.