Skip to content

refactor: decouple MCP policy construction from escalate server#12555

Merged
bolinfest merged 1 commit intomainfrom
pr12555
Feb 23, 2026
Merged

refactor: decouple MCP policy construction from escalate server#12555
bolinfest merged 1 commit intomainfrom
pr12555

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented Feb 23, 2026

Why

The current escalate path in codex-rs/exec-server still had policy creation coupled to MCP details, which makes it hard to reuse the shell execution flow outside the MCP server. This change is part of a broader goal to split MCP-specific behavior from shared escalation execution so other handlers (for example a future ShellCommandHandler) can reuse it without depending on MCP request context types.

What changed

Verification

  • Build and test execution was not re-run in this pass; changes are limited to mcp.rs and preserve the existing escalation flow semantics by only extracting policy construction behind a factory.

Stack created with Sapling. Best reviewed with ReviewStack.

@bolinfest bolinfest changed the title feat: refactor logic in exec-server for general use refactor: decouple MCP policy construction from escalate server Feb 23, 2026
@bolinfest bolinfest merged commit 956f2f4 into main Feb 23, 2026
32 of 33 checks passed
@bolinfest bolinfest deleted the pr12555 branch February 23, 2026 08:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants