Conversation
arix-oai
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The current escalate path in
codex-rs/exec-serverstill had policy creation coupled to MCP details, which makes it hard to reuse the shell execution flow outside the MCP server. This change is part of a broader goal to split MCP-specific behavior from shared escalation execution so other handlers (for example a futureShellCommandHandler) can reuse it without depending on MCP request context types.What changed
EscalationPolicyFactoryabstraction inmcp.rs:crate-relative path:codex-rs/exec-server/src/posix/mcp.rsrun_escalate_serverinmcp.rsaccept a policy factory instead of constructingMcpEscalationPolicydirectly.McpEscalationPolicyFactorythat stores MCP-only state (RequestContext,preserve_program_paths) and implements the new trait.shell()to pass aMcpEscalationPolicyFactoryinstance intorun_escalate_server, so the server remains the MCP-specific wiring layer.Verification
mcp.rsand preserve the existing escalation flow semantics by only extracting policy construction behind a factory.Stack created with Sapling. Best reviewed with ReviewStack.