Skip to content

Remove note about voting not emitting any events #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xlc merged 1 commit into from
Feb 27, 2025
Merged

Remove note about voting not emitting any events #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions packages/shared/src/governance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,11 +321,7 @@ export async function referendumLifecycleTest<

unwantedFields = /alarm|when|since|submitted/

// Filtering for events only from the `convictionVoting` pallet would leave them empty.
// Voting events were only introduced in
// https://github.com/paritytech/polkadot-sdk/pull/4613, and will take a few releases until they
// are visible here - this will trigger a failure in tests, which can then be addressed.
await checkEvents(voteEvents, 'convictionVoting', 'referenda')
await checkEvents(voteEvents, 'convictionVoting')
.redact({ removeKeys: unwantedFields, redactKeys: unwantedFields })
.toMatchSnapshot("events for charlie's vote")

Expand Down Expand Up @@ -395,7 +391,7 @@ export async function referendumLifecycleTest<

await client.dev.newBlock()

await checkEvents(voteEvents, 'convictionVoting', 'referenda')
await checkEvents(voteEvents, 'convictionVoting')
.redact({ removeKeys: unwantedFields })
.toMatchSnapshot("events for dave's vote")

Expand Down Expand Up @@ -465,7 +461,7 @@ export async function referendumLifecycleTest<

await client.dev.newBlock()

await checkEvents(voteEvents, 'convictionVoting', 'referenda')
await checkEvents(voteEvents, 'convictionVoting')
.redact({ removeKeys: unwantedFields })
.toMatchSnapshot("events for eve's vote")

Expand Down