-
Notifications
You must be signed in to change notification settings - Fork 323
container: add CSI attributes #1337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 17 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
1df3be8
k8s: add CSI driver attributes
gdvalle b27dfa5
Update model/registry/k8s.yaml
gdvalle 2069ea8
Update model/registry/k8s.yaml
gdvalle c352b3d
put CSI into its own component, ref from k8s
gdvalle 2530d8c
Merge remote-tracking branch 'origin/main' into gtd.csi
gdvalle 9707599
remove csi from k8s, doesn't go here
gdvalle 5e86006
make fix generate-gh-issue-templates
gdvalle a0b2262
remove k8s attr bits from changelog
gdvalle 75a4570
clarify this is a new component
gdvalle 62ce92d
simplify changelog note
gdvalle 67a2e1d
Add CSI to acronyms
gdvalle 05434b2
Csi->CSI
gdvalle da3edad
manually fix sort order
gdvalle ab50427
Merge branch 'main' into gtd.csi
joaopgrassi ce7a5e8
Merge remote-tracking branch 'origin/main' into gtd.csi
gdvalle ba336ad
move csi attrs underneath container registry
gdvalle 08daa79
make
gdvalle 90150cf
link to CSI spec
gdvalle cefc652
remove erroneous generated file
gdvalle 1e24818
link in both attrs, run make
gdvalle f3e5175
Merge remote-tracking branch 'origin/main' into gtd.csi
gdvalle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| change_type: enhancement | ||
| component: container | ||
| note: >- | ||
| Add CSI (Container Storage Interface) attributes: | ||
| `container.csi.plugin.name` and `container.csi.volume.id`. | ||
| issues: [1119] | ||
| subtext: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| <!--- Hugo front matter used to generate the website version of this page: | ||
| ---> | ||
|
|
||
| <!-- NOTE: THIS FILE IS AUTOGENERATED. DO NOT EDIT BY HAND. --> | ||
| <!-- see templates/registry/markdown/attribute_namespace.md.j2 --> | ||
|
|
||
| # CSI | ||
|
|
||
| ## Container Storage Interface (CSI) Attributes | ||
|
|
||
| Attributes related to the Container Storage Interface (CSI). | ||
|
|
||
| | Attribute | Type | Description | Examples | Stability | | ||
| | ----------------- | ------ | ---------------------------------------------------- | ------------------------------------------------------------- | ---------------------------------------------------------------- | | ||
| | `csi.plugin.name` | string | The name of the CSI plugin used by the volume. [1] | `pd.csi.storage.gke.io` |  | | ||
lmolkova marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| | `csi.volume.id` | string | The unique volume ID returned by the CSI plugin. [2] | `projects/my-gcp-project/zones/my-gcp-zone/disks/my-gcp-disk` |  | | ||
|
|
||
| **[1]:** This can sometimes be referred to as a "driver" in CSI implementations. This should represent the `name` field of the GetPluginInfo RPC. | ||
|
|
||
| **[2]:** This can sometimes be referred to as a "volume handle" in CSI implementations. This should represent the `Volume.volume_id` field in CSI spec. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.