container: add CSI attributes#1337
Conversation
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
|
I ran into a couple little snags:
|
|
/cc @open-telemetry/semconv-container-approvers @open-telemetry/semconv-k8s-approvers |
|
@jmacd could you please take another look? I believe your feedback is addressed. |
Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com> Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com> Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
|
Hey @gdvalle, is there a reason why those were only added in the registry and not as Resource Attributes as well? |
No, just my oversight. See #1499 for adding to resource attributes. |
Fixes #1119
Changes
Add CSI (Container Storage Interface) attributes:
container.csi.plugin.nameandcontainer.csi.volume.id.Merge requirement checklist
[chore]xref open-telemetry/opentelemetry-collector-contrib#32055 (comment)